Patch Detail
Show a patch.
GET /api/1.1/patches/15172/?format=api
{ "id": 15172, "url": "https://patchwork.libcamera.org/api/1.1/patches/15172/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15172/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211220232629.1485890-2-paul.elder@ideasonboard.com>", "date": "2021-12-20T23:26:24", "name": "[libcamera-devel,v2,1/6] android: camera_capabilities: Add messages for lack of FULL support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6bf66a125759dac26d949ad16592bee3e6e4e5b1", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15172/mbox/", "series": [ { "id": 2848, "url": "https://patchwork.libcamera.org/api/1.1/series/2848/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2848", "date": "2021-12-20T23:26:23", "name": "android: Miscellaneous fixes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2848/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15172/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15172/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC09CC3258\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Dec 2021 23:26:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6CC28608F8;\n\tTue, 21 Dec 2021 00:26:47 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1976A60868\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Dec 2021 00:26:45 +0100 (CET)", "from pyrite.mediacom.info (unknown\n\t[IPv6:2604:2d80:ad90:fb00:96fd:8874:873:6c16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6BE04FD7;\n\tTue, 21 Dec 2021 00:26:44 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BsIrXDOc\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640042804;\n\tbh=5ShqKvB4tAmbmPpPVg2CCf6TooLNTQlMBVt2nKauTmE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=BsIrXDOcsFcSXZyu8qbbweyfXzu/ivPgZcDcWmoVq4BTuyoS9EJOb45lCWcP/OECD\n\tEPWNrk5X2h87c+RSyYu4dQsF3VH5DQaKEvXApwRKEtdEaBegfGW3DjKS6c+qbf6knM\n\tj8mLxQkvq/FQ9/OoU73qV6fQoBEvywAIMISB6Ils=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 20 Dec 2021 17:26:24 -0600", "Message-Id": "<20211220232629.1485890-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20211220232629.1485890-1-paul.elder@ideasonboard.com>", "References": "<20211220232629.1485890-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/6] android: camera_capabilities: Add\n\tmessages for lack of FULL support", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Print messages when some feature is missing that causes hardware level\nFULL to not be supported.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/android/camera_capabilities.cpp | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex c4c26089..6ae2cd4d 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -359,6 +359,9 @@ void CameraCapabilities::computeHwLevel(\n {\n \tcamera_metadata_ro_entry_t entry;\n \tbool found;\n+\n+\tconst char *noFull = \"Hardware level FULL unavailable: \";\n+\n \tcamera_metadata_enum_android_info_supported_hardware_level\n \t\thwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_FULL;\n \n@@ -372,8 +375,10 @@ void CameraCapabilities::computeHwLevel(\n \t\thwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;\n \n \tfound = staticMetadata_->getEntry(ANDROID_SYNC_MAX_LATENCY, &entry);\n-\tif (!found || *entry.data.i32 != 0)\n+\tif (!found || *entry.data.i32 != 0) {\n+\t\tLOG(HAL, Info) << noFull << \"missing or invalid max sync latency\";\n \t\thwLevel = ANDROID_INFO_SUPPORTED_HARDWARE_LEVEL_LIMITED;\n+\t}\n \n \thwLevel_ = hwLevel;\n }\n", "prefixes": [ "libcamera-devel", "v2", "1/6" ] }