Patch Detail
Show a patch.
GET /api/1.1/patches/15063/?format=api
{ "id": 15063, "url": "https://patchwork.libcamera.org/api/1.1/patches/15063/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15063/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211206233948.1351206-8-kieran.bingham@ideasonboard.com>", "date": "2021-12-06T23:39:47", "name": "[libcamera-devel,7/8] gstreamer: gstlibcamerasrc: Fix include ordering", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f90f4fece9cae08e66e2864aed39d1e3ac3a7c13", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/15063/mbox/", "series": [ { "id": 2822, "url": "https://patchwork.libcamera.org/api/1.1/series/2822/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2822", "date": "2021-12-06T23:39:40", "name": "Request metadata: SensorSequence", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2822/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15063/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15063/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AFAA7C325A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 Dec 2021 23:40:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F247960898;\n\tTue, 7 Dec 2021 00:40:01 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C97B60890\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Dec 2021 00:39:56 +0100 (CET)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CAC4B556;\n\tTue, 7 Dec 2021 00:39:55 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M1yHlJd3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638833995;\n\tbh=yRFK2wQI0wUltPLmYwPF+UXyW4E8vwk15FVtH27Mkos=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=M1yHlJd3Rxsn0Z4rt4vM+O0/2dtKY92SbSiWbxQ7kIJ9rllnDNiMtKbs/ANg9hk8/\n\tibwfhVUSfxpuE/piZB3ZbVvyKtT0eS+nrpfSq0rk1staUGMCquRtcz2XypdbO77LkR\n\tMPtw7/CIDMsIEHLv7JvfOEFtLW2u2bsXRZ8fZBfk=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 6 Dec 2021 23:39:47 +0000", "Message-Id": "<20211206233948.1351206-8-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20211206233948.1351206-1-kieran.bingham@ideasonboard.com>", "References": "<20211206233948.1351206-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 7/8] gstreamer: gstlibcamerasrc: Fix\n\tinclude ordering", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The libcamera coding style has libcamera headers after system headers,\nand before any other library headers.\n\nMove the libcamera headers above the Gst headers accordingly.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 812ba7a2bd6e..c7292f66b17b 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -32,11 +32,11 @@\n #include <queue>\n #include <vector>\n \n-#include <gst/base/base.h>\n-\n #include <libcamera/camera.h>\n #include <libcamera/camera_manager.h>\n \n+#include <gst/base/base.h>\n+\n #include \"gstlibcameraallocator.h\"\n #include \"gstlibcamerapad.h\"\n #include \"gstlibcamerapool.h\"\n", "prefixes": [ "libcamera-devel", "7/8" ] }