Patch Detail
Show a patch.
GET /api/1.1/patches/15061/?format=api
{ "id": 15061, "url": "https://patchwork.libcamera.org/api/1.1/patches/15061/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15061/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211206233948.1351206-6-kieran.bingham@ideasonboard.com>", "date": "2021-12-06T23:39:45", "name": "[libcamera-devel,5/8] qcam: main_window: Fix include ordering", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "101b169fb179e85d123f111bcb27814d4856b6bb", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/15061/mbox/", "series": [ { "id": 2822, "url": "https://patchwork.libcamera.org/api/1.1/series/2822/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2822", "date": "2021-12-06T23:39:40", "name": "Request metadata: SensorSequence", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2822/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15061/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15061/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09CFCC324B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 Dec 2021 23:40:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 979CE60882;\n\tTue, 7 Dec 2021 00:40:00 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 965816086C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Dec 2021 00:39:55 +0100 (CET)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 41A4A5B0;\n\tTue, 7 Dec 2021 00:39:55 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uZ3l5kIX\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638833995;\n\tbh=jAuFgW3uGmumLGQnnchfLuWmm3zBGqHn9+ADZgD5aEU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=uZ3l5kIXZu7zbjFU8hHgEfFVcdgQLH28raBnWA6xWfBJaNsESegSHR4wisuWgeT0O\n\tgiEbPRsQ+1/op7UgknW7iUw/VtzAtoPXsg7CcHqwARyWZmOLpYrNikjOhadzKnlkqz\n\tpxXKi/I69vIvXTVSB8J858BI4HaiwvlQTvNyK3bM=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 6 Dec 2021 23:39:45 +0000", "Message-Id": "<20211206233948.1351206-6-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20211206233948.1351206-1-kieran.bingham@ideasonboard.com>", "References": "<20211206233948.1351206-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 5/8] qcam: main_window: Fix include\n\tordering", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The libcamera coding style has libcamera headers after system headers,\nand before any other library headers.\n\nMove the libcamera headers above the QT headers accordingly.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/qcam/main_window.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex ae51fa672a8c..dd0e51f55b70 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -11,6 +11,9 @@\n #include <iomanip>\n #include <string>\n \n+#include <libcamera/camera_manager.h>\n+#include <libcamera/version.h>\n+\n #include <QComboBox>\n #include <QCoreApplication>\n #include <QFileDialog>\n@@ -25,9 +28,6 @@\n #include <QToolButton>\n #include <QtDebug>\n \n-#include <libcamera/camera_manager.h>\n-#include <libcamera/version.h>\n-\n #include \"../cam/image.h\"\n #include \"dng_writer.h\"\n #ifndef QT_NO_OPENGL\n", "prefixes": [ "libcamera-devel", "5/8" ] }