Patch Detail
Show a patch.
GET /api/1.1/patches/15001/?format=api
{ "id": 15001, "url": "https://patchwork.libcamera.org/api/1.1/patches/15001/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15001/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211203071512.1197248-1-umang.jain@ideasonboard.com>", "date": "2021-12-03T07:15:12", "name": "[libcamera-devel] android: Apply 1% tolerance to minFrameDuration capping", "commit_ref": "37c41aa6a69985f99f9540dc89d094df61770fdc", "pull_url": null, "state": "accepted", "archived": false, "hash": "59882c6f6b80c05d9b9bda4f97cdf6918c399954", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15001/mbox/", "series": [ { "id": 2806, "url": "https://patchwork.libcamera.org/api/1.1/series/2806/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2806", "date": "2021-12-03T07:15:12", "name": "[libcamera-devel] android: Apply 1% tolerance to minFrameDuration capping", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2806/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15001/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15001/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3BB6BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 3 Dec 2021 07:15:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49A21607DE;\n\tFri, 3 Dec 2021 08:15:20 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB02B60118\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 3 Dec 2021 08:15:18 +0100 (CET)", "from perceval.ideasonboard.com (unknown [103.251.226.170])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CE38BA59;\n\tFri, 3 Dec 2021 08:15:17 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hju8hPZL\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638515718;\n\tbh=PTWXuGBqsfZrrFJGvETV2Ga/hbh5pg+37eTBbPK12YQ=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=hju8hPZLWYRmO9/Vfdeh1I29MKoW7+098uE9GVO87qWxwNW51aFyE82/aI5PrJa3C\n\tj0wQJ38z4WoOahR8VNqTI+A6PaOQKPZWqbDwiXgq8/NI2jk5fK9jsDS49outwrV4Jw\n\tqQ0WBnugp01q1LyevEbjLHF29N71ObKbj9Eb6Q+0=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 3 Dec 2021 12:45:12 +0530", "Message-Id": "<20211203071512.1197248-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] android: Apply 1% tolerance to\n\tminFrameDuration capping", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We have some stream resolution which can provide slightly better\nframe duration than what we cap (i.e. 1/30 fps). The problem with\nthis is CTS complains if the camera goes faster during the test\nthan minFrameDuration reported for that resolution. For instance,\n\n1080p minFrameDuration:\n\t- Nautilus : 33282000ns\n\t- Soraka : 33147000ns\n\nBoth are less than capped minFrameDuration 1/30 fps (33333333.33ns).\n\nThis patch considers this situation and doesn't cap the\nminFrameDuration if the hardware can provide frame durations slightly\nbetter. The tolerance considered is 1% only from the cap.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\nOn LIMITED level - no regressions were found : 230/231 pass rate\n\nOn FULL level - this fixes the test:\nandroid.hardware.camera2.cts.SurfaceViewPreviewTest#testPreviewFpsRange\n---\n src/android/camera_capabilities.cpp | 16 +++++++++++++---\n 1 file changed, 13 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex f357902e..c4c26089 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -648,7 +648,7 @@ int CameraCapabilities::initializeStreamConfigurations()\n \t\t\tint64_t maxFrameDuration = frameDurations->second.max().get<int64_t>() * 1000;\n \n \t\t\t/*\n-\t\t\t * Cap min frame duration to 30 FPS.\n+\t\t\t * Cap min frame duration to 30 FPS with 1% tolerance.\n \t\t\t *\n \t\t\t * 30 frames per second has been validated as the most\n \t\t\t * opportune frame rate for quality tuning, and power\n@@ -667,8 +667,18 @@ int CameraCapabilities::initializeStreamConfigurations()\n \t\t\t * control to be specified for each Request. Defer this\n \t\t\t * to the in-development configuration API rework.\n \t\t\t */\n-\t\t\tif (minFrameDuration < 1e9 / 30.0)\n-\t\t\t\tminFrameDuration = 1e9 / 30.0;\n+\t\t\tint64_t minFrameDurationCap = 1e9 / 30.0;\n+\t\t\tif (minFrameDuration < minFrameDurationCap) {\n+\t\t\t\tfloat tolerance =\n+\t\t\t\t\t(minFrameDurationCap - minFrameDuration) * 100.0 / minFrameDurationCap;\n+\n+\t\t\t\t/*\n+\t\t\t\t * If the tolerance is less than 1%, do not cap\n+\t\t\t\t * the frame duration.\n+\t\t\t\t */\n+\t\t\t\tif (tolerance > 1.0)\n+\t\t\t\t\tminFrameDuration = minFrameDurationCap;\n+\t\t\t}\n \n \t\t\tstreamConfigurations_.push_back({\n \t\t\t\tres, androidFormat, minFrameDuration, maxFrameDuration,\n", "prefixes": [ "libcamera-devel" ] }