Patch Detail
Show a patch.
GET /api/1.1/patches/14987/?format=api
{ "id": 14987, "url": "https://patchwork.libcamera.org/api/1.1/patches/14987/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14987/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211202134644.1094233-1-umang.jain@ideasonboard.com>", "date": "2021-12-02T13:46:44", "name": "[libcamera-devel,RFC,v2] android: Do not cap those minFrameDuration nearabout 30fps", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c88e9cb6b33af9b81c28f80523a89e0acb477803", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14987/mbox/", "series": [ { "id": 2803, "url": "https://patchwork.libcamera.org/api/1.1/series/2803/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2803", "date": "2021-12-02T13:46:44", "name": "[libcamera-devel,RFC,v2] android: Do not cap those minFrameDuration nearabout 30fps", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2803/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14987/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14987/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EBDEFBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 2 Dec 2021 13:46:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E84460592;\n\tThu, 2 Dec 2021 14:46:54 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6132D6011A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 2 Dec 2021 14:46:52 +0100 (CET)", "from perceval.ideasonboard.com (unknown [103.251.226.170])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3510D8C;\n\tThu, 2 Dec 2021 14:46:50 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"A6+lBa3B\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638452812;\n\tbh=hTLTpp/Ps8p9qawjh1CONOj9Gr5Yjp50ghtevY2QOoU=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=A6+lBa3B58tqqrQWxGgQbQNpYi+c7vOztGKeHt4jn/n7feRTyDt0v9rUoBk5H6UCv\n\tX9zj29JTt6Nd9EFxkfffZgECPs1kG3kJEBQQqBCJXbRJDqQ1Xm/Kk4NMGKyFddy+1N\n\t6vhFXPMaAb5Gwu/Ue2f48TLvdohKUtNtoQilBaxc=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 2 Dec 2021 19:16:44 +0530", "Message-Id": "<20211202134644.1094233-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH v2] android: Do not cap those\n\tminFrameDuration nearabout 30fps", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We have some stream resolution which can provide slightly better\nframe duration than what we cap (i.e. 1/30 fps). The problem with\nthis is CTS complains if the camera goes faster during the test\nthan minFrameDuration reported for that stream. For instance,\n\n1080p minFrameDuration:\n\t- Nautilus : 33282000\n\t- Soraka : 33147000\n\nBoth are less than capped minFrameDuration (3333333).\n\nThis patch considers this situation and doesn't cap the\nminFrameDuration if the hardware can provide frame durations slightly\nbetter. The delta considered is 1% only from the cap.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n\nOn LIMITED level - no regressions were found : 230/231 pass rate\n(retested locally from RFC v1)\n\nOn FULL level - this fixes the test:\nandroid.hardware.camera2.cts.SurfaceViewPreviewTest#testPreviewFpsRange\n---\n src/android/camera_capabilities.cpp | 13 +++++++++++--\n 1 file changed, 11 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex f357902e..66ff1274 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -667,8 +667,17 @@ int CameraCapabilities::initializeStreamConfigurations()\n \t\t\t * control to be specified for each Request. Defer this\n \t\t\t * to the in-development configuration API rework.\n \t\t\t */\n-\t\t\tif (minFrameDuration < 1e9 / 30.0)\n-\t\t\t\tminFrameDuration = 1e9 / 30.0;\n+\t\t\tint64_t capMinFrameDuration = 1e9 / 30.0;\n+\t\t\tif (minFrameDuration < capMinFrameDuration) {\n+\t\t\t\tfloat delta = (capMinFrameDuration - minFrameDuration) * 100 / capMinFrameDuration;\n+\n+\t\t\t\t/*\n+\t\t\t\t * If the delta is less than 1%, do not cap the\n+\t\t\t\t * frame duration.\n+\t\t\t\t */\n+\t\t\t\tif (delta > 1)\n+\t\t\t\t\tminFrameDuration = capMinFrameDuration;\n+\t\t\t}\n \n \t\t\tstreamConfigurations_.push_back({\n \t\t\t\tres, androidFormat, minFrameDuration, maxFrameDuration,\n", "prefixes": [ "libcamera-devel", "RFC", "v2" ] }