Patch Detail
Show a patch.
GET /api/1.1/patches/14983/?format=api
{ "id": 14983, "url": "https://patchwork.libcamera.org/api/1.1/patches/14983/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14983/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211201201430.2022636-1-raj.khem@gmail.com>", "date": "2021-12-01T20:14:30", "name": "[libcamera-devel] backtracre: Include cxxabi.h without HAVE_DW", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "40fbaf2a6b8472ee0f4f413487fe1bdcd35789bb", "submitter": { "id": 62, "url": "https://patchwork.libcamera.org/api/1.1/people/62/?format=api", "name": "Khem Raj", "email": "raj.khem@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14983/mbox/", "series": [ { "id": 2799, "url": "https://patchwork.libcamera.org/api/1.1/series/2799/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2799", "date": "2021-12-01T20:14:30", "name": "[libcamera-devel] backtracre: Include cxxabi.h without HAVE_DW", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2799/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14983/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14983/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 300E5BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 1 Dec 2021 20:14:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 46D166082A;\n\tWed, 1 Dec 2021 21:14:38 +0100 (CET)", "from mail-pl1-x630.google.com (mail-pl1-x630.google.com\n\t[IPv6:2607:f8b0:4864:20::630])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 32FA8607DE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 1 Dec 2021 21:14:36 +0100 (CET)", "by mail-pl1-x630.google.com with SMTP id u11so18586419plf.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 01 Dec 2021 12:14:36 -0800 (PST)", "from apollo.hsd1.ca.comcast.net ([2601:646:9200:a0f0::ce68])\n\tby smtp.gmail.com with ESMTPSA id\n\tc21sm659929pfl.138.2021.12.01.12.14.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 01 Dec 2021 12:14:33 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"dXYuMuCB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=q57qJwPciihl01wikFylzO4Zue0E3EXoAx7oLkZ2g+k=;\n\tb=dXYuMuCBVK7oopjpSWEh+3sEP3BDIkqPmLtyyTlefk0+j1gvN9v/ByI4fjDfuIYtRb\n\tyVj53op+5y636QP9lvkAV/lFeK6G/n77+gAtQGUWOqOh7lUiOx1WcZ3EGq2Cyn9aT/zL\n\t77YKfBwGItZmbGQCIniMq987dJYS0UhvzLNGUyIkEIXSGEk9IpIlo8MUWRW7VOcQdP8n\n\tX+0e75+7ztVXtDaugoCpsa4N8XHw9OgVFTI7o35KohZEHD3TLzQcxSvdBTINwYJgLISf\n\t/zwR+g7bOtRqs4Diae5kJxAKhy6tWl8jvtVH+Bvzc1qTyM/LpTFbdMxfC7UDYZtCqNJ9\n\tHp0Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=q57qJwPciihl01wikFylzO4Zue0E3EXoAx7oLkZ2g+k=;\n\tb=mE/+pCIkLSSe6j414Q2yiEGwJFN+QSRVMlfT65U23z04YCoJ0oV6NA7itRPJqoOCLj\n\tOnTFCVA+kTf+/h62FzaZTGCYuYrmnNmxlcnjsbOK1NCawR6gaov6oA7JV6o1+0gCBTuK\n\tgcmB9vADaICMzjlNpclbME65zA2E7EddK8v5jpzUIc77JwhxE2a1R40JU6IbCpAnLvbo\n\tBnXubJDY+zcGxRUu53R+ImouXuXzOVvGNYWA0YrHAjHvQF2BDGJsSgVsaXsg3UV4kq80\n\tvzCVXsdQ7kepgOh9MdtJ93IiWA3zLudxVbCGtpdE/Zee15mvw7/eyCGA8tt7TLRtA/qk\n\tj7iQ==", "X-Gm-Message-State": "AOAM531kw58alhCaf9ub0+qMUUp7nMkQH1i8yfrvJviFPID6hCBRJ7rn\n\tzRDnm/wwl6HcXmuYOigawGAfiHY90b/wFA==", "X-Google-Smtp-Source": "ABdhPJyrLWCyr/VBiBKnT+5RJrPcb3QaoAl0OOLEjQa4NJifselxwMiggrmVfEEUqDX/VOM0Q8SB+A==", "X-Received": "by 2002:a17:90a:f182:: with SMTP id\n\tbv2mr501905pjb.139.1638389674169; \n\tWed, 01 Dec 2021 12:14:34 -0800 (PST)", "From": "Khem Raj <raj.khem@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 1 Dec 2021 12:14:30 -0800", "Message-Id": "<20211201201430.2022636-1-raj.khem@gmail.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] backtracre: Include cxxabi.h without\n\tHAVE_DW", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Khem Raj <raj.khem@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since its used in code without HAVE_DW, it fails to compile on such\nsystems e.g. linux/musl\n\nFixes\nsrc/libcamera/base/backtrace.cpp:235:16: error: use of undeclared identifier 'abi'\n char *name = abi::__cxa_demangle(symbol, nullptr, nullptr, nullptr);\n ^\n1 error generated.\n\nSigned-off-by: Khem Raj <raj.khem@gmail.com>\n---\n src/libcamera/base/backtrace.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/base/backtrace.cpp b/src/libcamera/base/backtrace.cpp\nindex d93e5518..42c60f7c 100644\n--- a/src/libcamera/base/backtrace.cpp\n+++ b/src/libcamera/base/backtrace.cpp\n@@ -13,11 +13,12 @@\n #endif\n \n #ifdef HAVE_DW\n-#include <cxxabi.h>\n #include <elfutils/libdwfl.h>\n #include <unistd.h>\n #endif\n \n+#include <cxxabi.h>\n+\n #if HAVE_UNWIND\n /*\n * Disable support for remote unwinding to enable a more optimized\n", "prefixes": [ "libcamera-devel" ] }