Patch Detail
Show a patch.
GET /api/1.1/patches/14927/?format=api
{ "id": 14927, "url": "https://patchwork.libcamera.org/api/1.1/patches/14927/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14927/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211201070728.3114247-2-hiroh@chromium.org>", "date": "2021-12-01T07:07:17", "name": "[libcamera-devel,v4,01/12] libcamera: base: Introduce ConditionVariable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "07196e708571922015eab0544c114f52e57bac4f", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14927/mbox/", "series": [ { "id": 2789, "url": "https://patchwork.libcamera.org/api/1.1/series/2789/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2789", "date": "2021-12-01T07:07:16", "name": "Introduce clang thread safety annotations", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2789/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14927/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14927/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83C95BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 1 Dec 2021 07:07:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A79160729;\n\tWed, 1 Dec 2021 08:07:40 +0100 (CET)", "from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com\n\t[IPv6:2607:f8b0:4864:20::1031])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C89D60718\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 1 Dec 2021 08:07:38 +0100 (CET)", "by mail-pj1-x1031.google.com with SMTP id\n\tgf14-20020a17090ac7ce00b001a7a2a0b5c3so20280982pjb.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Nov 2021 23:07:38 -0800 (PST)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:3892:a049:59ba:c772])\n\tby smtp.gmail.com with ESMTPSA id\n\tm10sm16598962pgv.75.2021.11.30.23.07.34\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 30 Nov 2021 23:07:35 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"JMcenpf8\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=RfQVNtG/v2bEcPhs3B2DWL5RmPs7AC4Gxpfmf3NMFrs=;\n\tb=JMcenpf8dH7NwKRwY8hrOWG0uS3BL8IeXdCsLY3mkn0HgnSsWmNY8eJFd0TpCygPdT\n\tis4kYOc0TUsRuLTnEoxaJKQOy1DIcL/tz7ayIObaVD7XcFlLNjT2KU7ZZ6qVt/khDWLy\n\tZvTV3s0UTAfuUPabsO0XkNYfgoiMhETL8dluc=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=RfQVNtG/v2bEcPhs3B2DWL5RmPs7AC4Gxpfmf3NMFrs=;\n\tb=FMc7//2qh1eh/dOCzI715FISZPHo/HwnW6V55j1nugB52rzaywUfDZ7DA7FdlDfvsb\n\tkczXWIeP/BRbfzMhYPDOP5ooVhQlM0KPXxm+4+zDjePrGhwry5hXaKW+rvp9UU9geu/o\n\tWCkKDqb9+59hDaroWeywoNhqyvEuvJzX2Vbky+FdkLiRqmEsBHpyAnSZhHGEGF0OzphR\n\tUKGulgCJFI9s03iO7JaCTrmwtdcPnTl4HCtTRdBb4gaKipqU1glUCRC2+Y23g0eNshd6\n\tVIgiMJjNmw+dA8eFT22rm+/uotye0mfqngiVRIYgQlh0/lpS67wt4F6nZPJ+aZCpQlkH\n\t+dhw==", "X-Gm-Message-State": "AOAM531/xY/gy7yWYRNDNjlYyrsH9xLXTqEQ9tSSBnPD9G8DUkAGSick\n\tlfeRDkmI7EOlfmNS4BfyVBJ8o0N2kYo3Tw==", "X-Google-Smtp-Source": "ABdhPJzO2ttrZ+Ix4PpCys49FEAVGqiqjmu2L4drqppiJ7lMBBGuC+MR+mdRtyVO0oEu8w+IbiM53A==", "X-Received": "by 2002:a17:902:6a8a:b0:143:905f:aec7 with SMTP id\n\tn10-20020a1709026a8a00b00143905faec7mr5482176plk.8.1638342456322; \n\tTue, 30 Nov 2021 23:07:36 -0800 (PST)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 1 Dec 2021 16:07:17 +0900", "Message-Id": "<20211201070728.3114247-2-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.34.0.rc2.393.gf8c9666880-goog", "In-Reply-To": "<20211201070728.3114247-1-hiroh@chromium.org>", "References": "<20211201070728.3114247-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 01/12] libcamera: base: Introduce\n\tConditionVariable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "ConditionVariable is alias to std::condition_variable. This replaces\nstd::condition_variable with the ConditionVariable. It enables\nreplacing ConditionVariable implementation easily in the following\npatches.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/base/semaphore.h | 4 +---\n include/libcamera/base/thread.h | 2 ++\n src/android/camera_stream.h | 3 +--\n src/libcamera/base/thread.cpp | 8 ++++++--\n src/libcamera/camera_manager.cpp | 3 +--\n src/v4l2/v4l2_camera.h | 2 +-\n 6 files changed, 12 insertions(+), 10 deletions(-)", "diff": "diff --git a/include/libcamera/base/semaphore.h b/include/libcamera/base/semaphore.h\nindex ae87d319..ec05fad3 100644\n--- a/include/libcamera/base/semaphore.h\n+++ b/include/libcamera/base/semaphore.h\n@@ -7,8 +7,6 @@\n \n #pragma once\n \n-#include <condition_variable>\n-\n #include <libcamera/base/private.h>\n #include <libcamera/base/thread.h>\n \n@@ -26,7 +24,7 @@ public:\n \n private:\n \tMutex mutex_;\n-\tstd::condition_variable cv_;\n+\tConditionVariable cv_;\n \tunsigned int available_;\n };\n \ndiff --git a/include/libcamera/base/thread.h b/include/libcamera/base/thread.h\nindex 32ebc80a..1ebf8363 100644\n--- a/include/libcamera/base/thread.h\n+++ b/include/libcamera/base/thread.h\n@@ -7,6 +7,7 @@\n \n #pragma once\n \n+#include <condition_variable>\n #include <memory>\n #include <mutex>\n #include <sys/types.h>\n@@ -26,6 +27,7 @@ class Object;\n class ThreadData;\n class ThreadMain;\n \n+using ConditionVariable = std::condition_variable;\n using Mutex = std::mutex;\n using MutexLocker = std::unique_lock<std::mutex>;\n \ndiff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\nindex e9da75f0..e4808369 100644\n--- a/src/android/camera_stream.h\n+++ b/src/android/camera_stream.h\n@@ -7,7 +7,6 @@\n \n #pragma once\n \n-#include <condition_variable>\n #include <memory>\n #include <mutex>\n #include <queue>\n@@ -154,7 +153,7 @@ private:\n \t\tPostProcessor *postProcessor_;\n \n \t\tlibcamera::Mutex mutex_;\n-\t\tstd::condition_variable cv_;\n+\t\tlibcamera::ConditionVariable cv_;\n \n \t\tstd::queue<Camera3RequestDescriptor::StreamBuffer *> requests_;\n \t\tState state_ = State::Stopped;\ndiff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp\nindex d0ca30e3..b893135f 100644\n--- a/src/libcamera/base/thread.cpp\n+++ b/src/libcamera/base/thread.cpp\n@@ -8,7 +8,6 @@\n #include <libcamera/base/thread.h>\n \n #include <atomic>\n-#include <condition_variable>\n #include <list>\n #include <sys/syscall.h>\n #include <sys/types.h>\n@@ -158,7 +157,7 @@ private:\n \n \tstd::atomic<EventDispatcher *> dispatcher_;\n \n-\tstd::condition_variable cv_;\n+\tConditionVariable cv_;\n \tstd::atomic<bool> exit_;\n \tint exitCode_;\n \n@@ -205,6 +204,11 @@ ThreadData *ThreadData::current()\n \treturn data;\n }\n \n+/**\n+ * \\typedef ConditionVariable\n+ * \\brief An alias for std::condition_variable\n+ */\n+\n /**\n * \\typedef Mutex\n * \\brief An alias for std::mutex\ndiff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex e78bb1d7..77ff3bd1 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -7,7 +7,6 @@\n \n #include <libcamera/camera_manager.h>\n \n-#include <condition_variable>\n #include <map>\n \n #include <libcamera/camera.h>\n@@ -63,7 +62,7 @@ private:\n \tvoid createPipelineHandlers();\n \tvoid cleanup();\n \n-\tstd::condition_variable cv_;\n+\tConditionVariable cv_;\n \tbool initialized_;\n \tint status_;\n \ndiff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\nindex 94263b2f..4afbb331 100644\n--- a/src/v4l2/v4l2_camera.h\n+++ b/src/v4l2/v4l2_camera.h\n@@ -82,6 +82,6 @@ private:\n \tint efd_;\n \n \tlibcamera::Mutex bufferMutex_;\n-\tstd::condition_variable bufferCV_;\n+\tlibcamera::ConditionVariable bufferCV_;\n \tunsigned int bufferAvailableCount_;\n };\n", "prefixes": [ "libcamera-devel", "v4", "01/12" ] }