Patch Detail
Show a patch.
GET /api/1.1/patches/14904/?format=api
{ "id": 14904, "url": "https://patchwork.libcamera.org/api/1.1/patches/14904/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14904/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211130155600.2203123-8-hiroh@chromium.org>", "date": "2021-11-30T15:55:55", "name": "[libcamera-devel,v3,07/12] android: camera_hal_manager: Add thread safety annotation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "28d2cfdff8b8aab564be99d346c7f287f9790c19", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14904/mbox/", "series": [ { "id": 2785, "url": "https://patchwork.libcamera.org/api/1.1/series/2785/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2785", "date": "2021-11-30T15:55:48", "name": "Introduce clang thread safety annotations", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2785/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14904/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14904/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D463CBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Nov 2021 15:56:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6979160733;\n\tTue, 30 Nov 2021 16:56:25 +0100 (CET)", "from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com\n\t[IPv6:2607:f8b0:4864:20::62a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 78C7B6071A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Nov 2021 16:56:21 +0100 (CET)", "by mail-pl1-x62a.google.com with SMTP id o14so15275749plg.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Nov 2021 07:56:21 -0800 (PST)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:c90a:5a53:b139:1336])\n\tby smtp.gmail.com with ESMTPSA id\n\tpc10sm3510283pjb.9.2021.11.30.07.56.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 30 Nov 2021 07:56:19 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"KpZMwVfQ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=NsLHxMNeXQ7lFsLe7Zk5ZpE411R8RH9qkNzSxw4joS4=;\n\tb=KpZMwVfQmOhY4Ia+BnF/ZMCnA1mZJ0c0O9o8444w8Yj5wYSAQBdcJk5dFWUrSLAXin\n\t3CuuD0EBNxfTKL4R/QEb9wscyLSDufti4b0OQ3OetXU1xqH6dQ5Iw2pV9SGEcjU2QVJw\n\tRYh5cqUrVkYA0vrwSp5MgHW/s+5VatnGWvNOM=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=NsLHxMNeXQ7lFsLe7Zk5ZpE411R8RH9qkNzSxw4joS4=;\n\tb=nQW04zgzfs6rVpCooPTwVHpPnlL5EL9coIdcZY2pL/k8kYdfDsFoZam45kSTI3J+rL\n\tqP0etTs2STGJquQaqq2HIAJeGzwa2KJhzaGr5UPfUDimO4krZebZjIuCY/YK1rNt2VTx\n\tJ8henygyv5VT/uYSaQQq2cwx79sz5XzvlPac8xbw60KCllBBIy6TKVuwjwA+fu+MMK3m\n\tDNxfi3n6c8k4etvQHO2Mvlnge94TBgslUQWD+i7d6Krh+2DVgG6ukCRbsFnbaBgRWct0\n\tjSjO4Jzx3pkg4YLqczhm9WMiqNn+HCE1lW6I0BIZg/dZkb+ISqU0TJ0Zn71FuneaBxvU\n\tYElw==", "X-Gm-Message-State": "AOAM530yonSapeun4IDQOVxRmaTZ9a/bHndetmEwb/bpzFEtORHSLQWh\n\tgYCzyGcvVwdL8IS96AkrwHD108H5hhnUKA==", "X-Google-Smtp-Source": "ABdhPJzlfLtqaF4Ejtw+UQiYc5uFNo7FHwc7+ZmhCvwy65E7ZmhWfoVQ85n+DX54IvRGZe7NuzSw+A==", "X-Received": "by 2002:a17:902:f209:b0:141:99d1:7cef with SMTP id\n\tm9-20020a170902f20900b0014199d17cefmr124394plc.70.1638287779809; \n\tTue, 30 Nov 2021 07:56:19 -0800 (PST)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 1 Dec 2021 00:55:55 +0900", "Message-Id": "<20211130155600.2203123-8-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.34.0.rc2.393.gf8c9666880-goog", "In-Reply-To": "<20211130155600.2203123-1-hiroh@chromium.org>", "References": "<20211130155600.2203123-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 07/12] android: camera_hal_manager: Add\n\tthread safety annotation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This applies clang thread safety annotation to CameraHalManager.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/android/camera_hal_manager.h | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h\nindex 765701b2..5395d419 100644\n--- a/src/android/camera_hal_manager.h\n+++ b/src/android/camera_hal_manager.h\n@@ -18,6 +18,7 @@\n \n #include <libcamera/base/class.h>\n #include <libcamera/base/mutex.h>\n+#include <libcamera/base/thread_annotations.h>\n \n #include <libcamera/camera_manager.h>\n \n@@ -53,14 +54,14 @@ private:\n \tvoid cameraAdded(std::shared_ptr<libcamera::Camera> cam);\n \tvoid cameraRemoved(std::shared_ptr<libcamera::Camera> cam);\n \n-\tCameraDevice *cameraDeviceFromHalId(unsigned int id);\n+\tCameraDevice *cameraDeviceFromHalId(unsigned int id) LIBCAMERA_TSA_REQUIRES(mutex_);\n \n \tstd::unique_ptr<libcamera::CameraManager> cameraManager_;\n \tCameraHalConfig halConfig_;\n \n \tconst camera_module_callbacks_t *callbacks_;\n-\tstd::vector<std::unique_ptr<CameraDevice>> cameras_;\n-\tstd::map<std::string, unsigned int> cameraIdsMap_;\n+\tstd::vector<std::unique_ptr<CameraDevice>> cameras_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n+\tstd::map<std::string, unsigned int> cameraIdsMap_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n \tlibcamera::Mutex mutex_;\n \n \tunsigned int numInternalCameras_;\n", "prefixes": [ "libcamera-devel", "v3", "07/12" ] }