Patch Detail
Show a patch.
GET /api/1.1/patches/14878/?format=api
{ "id": 14878, "url": "https://patchwork.libcamera.org/api/1.1/patches/14878/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14878/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211130052253.513278-1-umang.jain@ideasonboard.com>", "date": "2021-11-30T05:22:53", "name": "[libcamera-devel] ipa: ipu3: Rectify gain value reporting in request metadata", "commit_ref": "68e4f70a6937a69339c3f48502cd4e332c3a16ca", "pull_url": null, "state": "accepted", "archived": false, "hash": "b3176f81aac20ddfb735a433e7c02702d8701ae4", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14878/mbox/", "series": [ { "id": 2777, "url": "https://patchwork.libcamera.org/api/1.1/series/2777/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2777", "date": "2021-11-30T05:22:53", "name": "[libcamera-devel] ipa: ipu3: Rectify gain value reporting in request metadata", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2777/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14878/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14878/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77D68BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Nov 2021 05:23:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D94D605A3;\n\tTue, 30 Nov 2021 06:23:02 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F0DEE604FC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Nov 2021 06:23:00 +0100 (CET)", "from perceval.ideasonboard.com (unknown [103.251.226.170])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D8C568F0;\n\tTue, 30 Nov 2021 06:22:59 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dFNubCEc\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638249780;\n\tbh=zqfASILgCGLSIZ6wDq699bEMHTGp5VhfgsI3kUWC/dw=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=dFNubCEcCasFUeZJkMOW5cDhd7i4C3FndyVnRPO/1Es/BKkohhIzNLLxeNvcpjH3O\n\toOQQttzvGQFscR/3ypXiwmzFwC9+ih9RdXxNfxzj3RVfaDTZQVRiLlu/qX9jnJPy5I\n\t6aQMU1P8OKxibVie3lSoG84EGfA94oohdThInXkc=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 30 Nov 2021 10:52:53 +0530", "Message-Id": "<20211130052253.513278-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: ipu3: Rectify gain value reporting\n\tin request metadata", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Report value of sensor's gain pertaining to the current request\ncompletion, as that is the gain value the request completed with.\nThe Agc algorithm processes the gain value for incoming next request\nhence it should not be reported in request's metadata.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex b0c75541..76182587 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -628,7 +628,7 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n \tint64_t frameDuration = (defVBlank_ + sensorInfo_.outputSize.height) * lineDuration_.get<std::micro>();\n \tctrls.set(controls::FrameDuration, frameDuration);\n \n-\tctrls.set(controls::AnalogueGain, context_.frameContext.agc.gain);\n+\tctrls.set(controls::AnalogueGain, context_.frameContext.sensor.gain);\n \n \tctrls.set(controls::ColourTemperature, context_.frameContext.awb.temperatureK);\n \n", "prefixes": [ "libcamera-devel" ] }