Patch Detail
Show a patch.
GET /api/1.1/patches/14856/?format=api
{ "id": 14856, "url": "https://patchwork.libcamera.org/api/1.1/patches/14856/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14856/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211130033820.18235-2-laurent.pinchart@ideasonboard.com>", "date": "2021-11-30T03:37:59", "name": "[libcamera-devel,v4,01/22] libcamera: Move compiler.h to base/", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8ae73e3cbe2a380922ffe21008eccd74446367b7", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14856/mbox/", "series": [ { "id": 2776, "url": "https://patchwork.libcamera.org/api/1.1/series/2776/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2776", "date": "2021-11-30T03:37:58", "name": "libcamera: Introduce UniqueFD", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2776/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14856/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14856/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7CD2BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Nov 2021 03:38:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 351E1605B6;\n\tTue, 30 Nov 2021 04:38:51 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB8A96059E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Nov 2021 04:38:48 +0100 (CET)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 51A9111C5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Nov 2021 04:38:48 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hpcBQrOE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638243528;\n\tbh=mHTkR1XuociDJ7aEHQY71W9VUmG/4yt6XfsRxcbf8DM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=hpcBQrOEH+OvYNvsd2eyHZNZZj4VxTq/xQPPd+pCvMGTcmEmaNd+7NiS+Cv8gHeqG\n\tIVsp4O+5ZykV51YGsZBTxNz/9ceWpiBX6dmdXh5SkH2O16RtRZ07JyBNWBvfblC6rS\n\tkJILOFkL49UCfBJ5xANcRUQQXbeI9edc/Zg67Z6s=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 30 Nov 2021 05:37:59 +0200", "Message-Id": "<20211130033820.18235-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211130033820.18235-1-laurent.pinchart@ideasonboard.com>", "References": "<20211130033820.18235-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 01/22] libcamera: Move compiler.h to\n\tbase/", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In preparation for usage of __nodiscard in the base API, move the\ncompiler.h header to base.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/{ => base}/compiler.h | 0\n include/libcamera/base/meson.build | 1 +\n include/libcamera/geometry.h | 2 +-\n include/libcamera/meson.build | 1 -\n 4 files changed, 2 insertions(+), 2 deletions(-)\n rename include/libcamera/{ => base}/compiler.h (100%)", "diff": "diff --git a/include/libcamera/compiler.h b/include/libcamera/base/compiler.h\nsimilarity index 100%\nrename from include/libcamera/compiler.h\nrename to include/libcamera/base/compiler.h\ndiff --git a/include/libcamera/base/meson.build b/include/libcamera/base/meson.build\nindex 525aba9d2919..23dd4e2023a8 100644\n--- a/include/libcamera/base/meson.build\n+++ b/include/libcamera/base/meson.build\n@@ -6,6 +6,7 @@ libcamera_base_headers = files([\n 'backtrace.h',\n 'bound_method.h',\n 'class.h',\n+ 'compiler.h',\n 'event_dispatcher.h',\n 'event_dispatcher_poll.h',\n 'event_notifier.h',\ndiff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\nindex 713f71c180c6..7838b6793617 100644\n--- a/include/libcamera/geometry.h\n+++ b/include/libcamera/geometry.h\n@@ -10,7 +10,7 @@\n #include <algorithm>\n #include <string>\n \n-#include <libcamera/compiler.h>\n+#include <libcamera/base/compiler.h>\n \n namespace libcamera {\n \ndiff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\nindex 7155ff203f6e..a8cca2a88cad 100644\n--- a/include/libcamera/meson.build\n+++ b/include/libcamera/meson.build\n@@ -5,7 +5,6 @@ libcamera_include_dir = 'libcamera' / 'libcamera'\n libcamera_public_headers = files([\n 'camera.h',\n 'camera_manager.h',\n- 'compiler.h',\n 'controls.h',\n 'file_descriptor.h',\n 'framebuffer.h',\n", "prefixes": [ "libcamera-devel", "v4", "01/22" ] }