Patch Detail
Show a patch.
GET /api/1.1/patches/14850/?format=api
{ "id": 14850, "url": "https://patchwork.libcamera.org/api/1.1/patches/14850/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14850/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211129171032.469605-1-umang.jain@ideasonboard.com>", "date": "2021-11-29T17:10:32", "name": "[libcamera-devel] ipu3: ipa: Report correct exposure in request metadata", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "53b29f07921bf7dc1abbc486b6cbf37b19dc6f76", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14850/mbox/", "series": [ { "id": 2773, "url": "https://patchwork.libcamera.org/api/1.1/series/2773/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2773", "date": "2021-11-29T17:10:32", "name": "[libcamera-devel] ipu3: ipa: Report correct exposure in request metadata", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2773/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14850/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14850/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07BA2BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Nov 2021 17:10:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4AD4D605A4;\n\tMon, 29 Nov 2021 18:10:46 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 797B060592\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Nov 2021 18:10:44 +0100 (CET)", "from perceval.ideasonboard.com (unknown [103.251.226.170])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E49AF1265;\n\tMon, 29 Nov 2021 18:10:42 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Sx59GKWn\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638205844;\n\tbh=cfX1iboCAswCSvuJG6RF7DgPyrB4Q96BTZK4rFCzUis=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Sx59GKWnl0dgom8IdtMJtYFXeD4KNSGZ5VioLqXjLIT2wO/5dlr0M1a6H9PUNWGzt\n\t+y6Jw3PORStkiETP2vU653uqKdJuKYlTrPNxp0ZRjC1UM4vdKi16gdWw3hTTu1QkVT\n\tcT7KPqEFjfOkMg+OhQjVkrQr23EwhGk8Ix5HUZ0A=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 29 Nov 2021 22:40:32 +0530", "Message-Id": "<20211129171032.469605-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipu3: ipa: Report correct exposure in\n\trequest metadata", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "While populating the ControlList for the request's metadata,\nthe exposure value should be used computed from AGC algorithm\ninstead of sensor's exposure.\n\nThe issue is caught while debugging a FULL-level CTS test.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex a8d54a5d..9cd80a02 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -632,7 +632,7 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n \n \tctrls.set(controls::ColourTemperature, context_.frameContext.awb.temperatureK);\n \n-\tctrls.set(controls::ExposureTime, context_.frameContext.sensor.exposure * lineDuration_.get<std::micro>());\n+\tctrls.set(controls::ExposureTime, context_.frameContext.agc.exposure * lineDuration_.get<std::micro>());\n \n \t/*\n \t * \\todo The Metadata provides a path to getting extended data\n", "prefixes": [ "libcamera-devel" ] }