Patch Detail
Show a patch.
GET /api/1.1/patches/14781/?format=api
{ "id": 14781, "url": "https://patchwork.libcamera.org/api/1.1/patches/14781/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14781/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211125131224.927640-3-umang.jain@ideasonboard.com>", "date": "2021-11-25T13:12:24", "name": "[libcamera-devel,v2,2/2] android: Log stream types using PixelFormat::toString()", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "d12f61d47d4db143be57c92d6e81b89adb9861c4", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14781/mbox/", "series": [ { "id": 2755, "url": "https://patchwork.libcamera.org/api/1.1/series/2755/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2755", "date": "2021-11-25T13:12:22", "name": "Improve stream type logging", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2755/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14781/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14781/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB747BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 25 Nov 2021 13:12:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8458760371;\n\tThu, 25 Nov 2021 14:12:40 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1309C6033C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Nov 2021 14:12:39 +0100 (CET)", "from perceval.ideasonboard.com (unknown [103.251.226.170])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0FA0D90E;\n\tThu, 25 Nov 2021 14:12:37 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"a9fKQV4c\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637845958;\n\tbh=uR2rxOM1t0ddp6Il3mV0Rjzhj4umgwobzaVtke29mMY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=a9fKQV4c5DF8Y1Aom5iGNyPj2gcdndt9UrcFr69qDUBb3zoEeCGyg9ULeEc2xq01+\n\tV1/q8t0cobyLIVTTr+Cm0ZDIPNS6p9aCS/wFPRC/F9jZNV2fxJSQGjOdK2W1Rn0SUp\n\te1Y8q5ihCfYXCjpgSXZ67fPGmMxgbyrlPg4eHJaE=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 25 Nov 2021 18:42:24 +0530", "Message-Id": "<20211125131224.927640-3-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20211125131224.927640-1-umang.jain@ideasonboard.com>", "References": "<20211125131224.927640-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/2] android: Log stream types using\n\tPixelFormat::toString()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Log stream types using PixelFormat::toString() instead of hex values,\nsince that is more human readable.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/android/camera_capabilities.cpp | 5 +++--\n src/android/camera_device.cpp | 2 +-\n 2 files changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex f357902e..71f302c4 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -713,7 +713,8 @@ int CameraCapabilities::initializeStreamConfigurations()\n \tLOG(HAL, Debug) << \"Collected stream configuration map: \";\n \tfor (const auto &entry : streamConfigurations_)\n \t\tLOG(HAL, Debug) << \"{ \" << entry.resolution.toString() << \" - \"\n-\t\t\t\t<< utils::hex(entry.androidFormat) << \" }\";\n+\t\t\t\t<< toPixelFormat(entry.androidFormat).toString()\n+\t\t\t\t<< \" }\";\n \n \treturn 0;\n }\n@@ -1303,7 +1304,7 @@ int CameraCapabilities::initializeStaticMetadata()\n \t\tminFrameDurations.push_back(entry.minFrameDurationNsec);\n \n \t\tLOG(HAL, Debug)\n-\t\t\t<< \"Output Stream: \" << utils::hex(entry.androidFormat)\n+\t\t\t<< \"Output Stream: \" << toPixelFormat(entry.androidFormat).toString()\n \t\t\t<< \" (\" << entry.resolution.toString() << \")[\"\n \t\t\t<< entry.minFrameDurationNsec << \"]\"\n \t\t\t<< \"@\" << fps;\ndiff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex ad4bf07c..cc6dccc1 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -566,7 +566,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \t\t\t << \", direction: \" << directionToString(stream->stream_type)\n \t\t\t << \", width: \" << stream->width\n \t\t\t << \", height: \" << stream->height\n-\t\t\t << \", format: \" << utils::hex(stream->format)\n+\t\t\t << \", format: \" << format.toString()\n \t\t\t << \", rotation: \" << rotationToString(stream->rotation)\n #if defined(OS_CHROMEOS)\n \t\t\t << \", crop_rotate_scale_degrees: \"\n", "prefixes": [ "libcamera-devel", "v2", "2/2" ] }