Patch Detail
Show a patch.
GET /api/1.1/patches/14752/?format=api
{ "id": 14752, "url": "https://patchwork.libcamera.org/api/1.1/patches/14752/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14752/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211124134019.110765-4-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-11-24T13:40:11", "name": "[libcamera-devel,v4,03/11] ipa: Do not modify the sensor limits", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c6d60a8994957f240a5431fe0244c8e8b5c8cc63", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14752/mbox/", "series": [ { "id": 2751, "url": "https://patchwork.libcamera.org/api/1.1/series/2751/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2751", "date": "2021-11-24T13:40:08", "name": "Introduce AGC for RkISP1", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2751/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14752/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14752/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4B5EBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 24 Nov 2021 13:40:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 559ED6042B;\n\tWed, 24 Nov 2021 14:40:29 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A67D60128\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Nov 2021 14:40:23 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:968b:bd0c:97fc:7c17])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 51124D78;\n\tWed, 24 Nov 2021 14:40:23 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Vgfr0yng\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637761223;\n\tbh=6pybVIYFXVd1SgQSEoyDZDyd/ijoQp2Fy/E09A9+tuw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Vgfr0yngUrkMlVFQ+wS/FjI0nSSBv0paGowaTVEXqhN6Pxq7J6478ic0+ZR8MjMOf\n\tCPExJTBHu2om838e2rlNhXGkEkYKi5aJ+y2+/nRlMOHRkksFE5oFiIzzT3HP1X6cLt\n\tMnG2Dst4uvDsJvmboWpRlH6jCEQGyOal9blfqV2s=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 24 Nov 2021 14:40:11 +0100", "Message-Id": "<20211124134019.110765-4-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211124134019.110765-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211124134019.110765-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 03/11] ipa: Do not modify the sensor\n\tlimits", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The driver is responsible for setting the proper limits for its\ncontrols.\n\nThe IMX219 has an analogue gain of 1.0 when the gain code is set to 0,\ntherefore we can not clamp to a minimum gain code of 1.\n\nRework this for both IPU3 and RkISP1, for both Exposure and Gain\ncontrols.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 4 ++--\n src/ipa/rkisp1/rkisp1.cpp | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex a8d54a5d..b0c75541 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -444,11 +444,11 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n \t\treturn -EINVAL;\n \t}\n \n-\tminExposure_ = std::max(itExp->second.min().get<int32_t>(), 1);\n+\tminExposure_ = itExp->second.min().get<int32_t>();\n \tmaxExposure_ = itExp->second.max().get<int32_t>();\n \texposure_ = minExposure_;\n \n-\tminGain_ = std::max(itGain->second.min().get<int32_t>(), 1);\n+\tminGain_ = itGain->second.min().get<int32_t>();\n \tmaxGain_ = itGain->second.max().get<int32_t>();\n \tgain_ = minGain_;\n \ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 7ecbf8ae..910ad952 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -139,11 +139,11 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\n \n \tautoExposure_ = true;\n \n-\tminExposure_ = std::max<uint32_t>(itExp->second.min().get<int32_t>(), 1);\n+\tminExposure_ = itExp->second.min().get<int32_t>();\n \tmaxExposure_ = itExp->second.max().get<int32_t>();\n \texposure_ = minExposure_;\n \n-\tminGain_ = std::max<uint32_t>(itGain->second.min().get<int32_t>(), 1);\n+\tminGain_ = itGain->second.min().get<int32_t>();\n \tmaxGain_ = itGain->second.max().get<int32_t>();\n \tgain_ = minGain_;\n \n", "prefixes": [ "libcamera-devel", "v4", "03/11" ] }