Patch Detail
Show a patch.
GET /api/1.1/patches/14750/?format=api
{ "id": 14750, "url": "https://patchwork.libcamera.org/api/1.1/patches/14750/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14750/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211124134019.110765-2-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-11-24T13:40:09", "name": "[libcamera-devel,v4,01/11] libipa: Correct IMX219 in CameraSensorHelper", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "be0b6b6764d00d6f9ac469be8571fdb623cc58c3", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14750/mbox/", "series": [ { "id": 2751, "url": "https://patchwork.libcamera.org/api/1.1/series/2751/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2751", "date": "2021-11-24T13:40:08", "name": "Introduce AGC for RkISP1", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2751/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14750/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14750/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AA99DBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 24 Nov 2021 13:40:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 48B946038B;\n\tWed, 24 Nov 2021 14:40:27 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 38C5160231\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Nov 2021 14:40:23 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:968b:bd0c:97fc:7c17])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E7F76D78;\n\tWed, 24 Nov 2021 14:40:22 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Cm7gr6fB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637761223;\n\tbh=6qkF2Tg7yCai9Xl8kh9FitL+Os2hwaUjtO8oJRvJdwQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Cm7gr6fB/khfnmJARKGuzdDizVxJg4v11wm/371Lf5MN7K1XAhttSa/BNQCSDQTO7\n\t6k9L93IuXgvgKaIPbh01vI5fS/8ycbpYnR3+YNLc3fzrxjLpZCEt15hFELnSnpJuKT\n\tmK+BRFuCcwwCzeT1SHORc43/7lI6s4+t+j10H2SY=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 24 Nov 2021 14:40:09 +0100", "Message-Id": "<20211124134019.110765-2-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211124134019.110765-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211124134019.110765-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 01/11] libipa: Correct IMX219 in\n\tCameraSensorHelper", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The equation is badly reported in the CameraSensorHelper, as m1 and c0\nare inverted. Correct it to have a proper gain calculation.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 0b0eb503..5d052612 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -290,7 +290,7 @@ class CameraSensorHelperImx219 : public CameraSensorHelper\n public:\n \tCameraSensorHelperImx219()\n \t{\n-\t\tanalogueGainConstants_ = { AnalogueGainLinear, 0, -1, 256, 256 };\n+\t\tanalogueGainConstants_ = { AnalogueGainLinear, 0, 256, -1, 256 };\n \t}\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx219\", CameraSensorHelperImx219)\n", "prefixes": [ "libcamera-devel", "v4", "01/11" ] }