Patch Detail
Show a patch.
GET /api/1.1/patches/14746/?format=api
{ "id": 14746, "url": "https://patchwork.libcamera.org/api/1.1/patches/14746/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14746/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211123224015.3619282-16-kieran.bingham@ideasonboard.com>", "date": "2021-11-23T22:40:15", "name": "[libcamera-devel,15/15] v4l2: Convert to pragma once", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "987989b3de14666c2cd1d0d9b8cc183bfeed46be", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/14746/mbox/", "series": [ { "id": 2749, "url": "https://patchwork.libcamera.org/api/1.1/series/2749/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2749", "date": "2021-11-23T22:40:00", "name": "Use pragma once", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2749/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14746/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14746/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8AFDC3250\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Nov 2021 22:40:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8EAE0603C2;\n\tTue, 23 Nov 2021 23:40:41 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CAB56039C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Nov 2021 23:40:24 +0100 (CET)", "from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CE977A1B;\n\tTue, 23 Nov 2021 23:40:23 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hxe83UBz\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637707223;\n\tbh=yYvUufQThQXROZnjJQKHggiNEQAwdpCWMiKXWcXqZAY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hxe83UBzUS0O1vQV3CLWNWovPrYULxLd+cDt9bY0YBYyOnQXXXztQDCMeC3oEqIJ1\n\tur/verOhSoNrdfz7TKgoe3gm/qyx3HpkZWhJStP1fe4HeaqhBFilxP6g/Ee/UKNhCc\n\tq+lKrEkMTPey3eXiPaQ30GNkCojYUrMtYlJE+W/g=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 23 Nov 2021 22:40:15 +0000", "Message-Id": "<20211123224015.3619282-16-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20211123224015.3619282-1-kieran.bingham@ideasonboard.com>", "References": "<20211123224015.3619282-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 15/15] v4l2: Convert to pragma once", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Remove the verbose #ifndef/#define/#endif pattern for maintaining\nheader idempotency, and replace it with a simple #pragma once.\n\nThis simplifies the headers, and prevents redundant changes when\nheader files get moved.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/v4l2/v4l2_camera.h | 5 +----\n src/v4l2/v4l2_camera_file.h | 5 +----\n src/v4l2/v4l2_camera_proxy.h | 5 +----\n src/v4l2/v4l2_compat_manager.h | 5 +----\n 4 files changed, 4 insertions(+), 16 deletions(-)", "diff": "diff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\nindex e81996f21168..94263b2f5db6 100644\n--- a/src/v4l2/v4l2_camera.h\n+++ b/src/v4l2/v4l2_camera.h\n@@ -5,8 +5,7 @@\n * v4l2_camera.h - V4L2 compatibility camera\n */\n \n-#ifndef __V4L2_CAMERA_H__\n-#define __V4L2_CAMERA_H__\n+#pragma once\n \n #include <deque>\n #include <mutex>\n@@ -86,5 +85,3 @@ private:\n \tstd::condition_variable bufferCV_;\n \tunsigned int bufferAvailableCount_;\n };\n-\n-#endif /* __V4L2_CAMERA_H__ */\ndiff --git a/src/v4l2/v4l2_camera_file.h b/src/v4l2/v4l2_camera_file.h\nindex 8f4670a0fa49..6c4cb5d89dbf 100644\n--- a/src/v4l2/v4l2_camera_file.h\n+++ b/src/v4l2/v4l2_camera_file.h\n@@ -5,8 +5,7 @@\n * v4l2_camera_file.h - V4L2 compatibility camera file information\n */\n \n-#ifndef __V4L2_CAMERA_FILE_H__\n-#define __V4L2_CAMERA_FILE_H__\n+#pragma once\n \n #include <linux/videodev2.h>\n \n@@ -33,5 +32,3 @@ private:\n \tint efd_;\n \tenum v4l2_priority priority_;\n };\n-\n-#endif /* __V4L2_CAMERA_FILE_H__ */\ndiff --git a/src/v4l2/v4l2_camera_proxy.h b/src/v4l2/v4l2_camera_proxy.h\nindex 56a45bb76650..fccec241879d 100644\n--- a/src/v4l2/v4l2_camera_proxy.h\n+++ b/src/v4l2/v4l2_camera_proxy.h\n@@ -5,8 +5,7 @@\n * v4l2_camera_proxy.h - Proxy to V4L2 compatibility camera\n */\n \n-#ifndef __V4L2_CAMERA_PROXY_H__\n-#define __V4L2_CAMERA_PROXY_H__\n+#pragma once\n \n #include <linux/videodev2.h>\n #include <map>\n@@ -100,5 +99,3 @@ private:\n \t/* This mutex is to serialize access to the proxy. */\n \tlibcamera::Mutex proxyMutex_;\n };\n-\n-#endif /* __V4L2_CAMERA_PROXY_H__ */\ndiff --git a/src/v4l2/v4l2_compat_manager.h b/src/v4l2/v4l2_compat_manager.h\nindex b11698cc165f..f52069f7b62d 100644\n--- a/src/v4l2/v4l2_compat_manager.h\n+++ b/src/v4l2/v4l2_compat_manager.h\n@@ -5,8 +5,7 @@\n * v4l2_compat_manager.h - V4L2 compatibility manager\n */\n \n-#ifndef __V4L2_COMPAT_MANAGER_H__\n-#define __V4L2_COMPAT_MANAGER_H__\n+#pragma once\n \n #include <fcntl.h>\n #include <map>\n@@ -68,5 +67,3 @@ private:\n \tstd::map<int, std::shared_ptr<V4L2CameraFile>> files_;\n \tstd::map<void *, V4L2CameraProxy *> mmaps_;\n };\n-\n-#endif /* __V4L2_COMPAT_MANAGER_H__ */\n", "prefixes": [ "libcamera-devel", "15/15" ] }