Patch Detail
Show a patch.
GET /api/1.1/patches/14740/?format=api
{ "id": 14740, "url": "https://patchwork.libcamera.org/api/1.1/patches/14740/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14740/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211123224015.3619282-10-kieran.bingham@ideasonboard.com>", "date": "2021-11-23T22:40:09", "name": "[libcamera-devel,09/15] ipa: ipu3: Convert to pragma once", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ac914b22101df780a4399c254d1d5234f3b60b65", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/14740/mbox/", "series": [ { "id": 2749, "url": "https://patchwork.libcamera.org/api/1.1/series/2749/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2749", "date": "2021-11-23T22:40:00", "name": "Use pragma once", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2749/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14740/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14740/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04716C324F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Nov 2021 22:40:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 951056033C;\n\tTue, 23 Nov 2021 23:40:37 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A81F060398\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Nov 2021 23:40:22 +0100 (CET)", "from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5DEFCA1B;\n\tTue, 23 Nov 2021 23:40:22 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LfHFP0Ah\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637707222;\n\tbh=mQKAYdHDiBYDJwPawVQKjRTAdeoTD0GV4aMZBH93E3k=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=LfHFP0AhtCoSCV+No9B753FqM0pni450yh5/8//7q7hDmNowcS8ph8sRQQWfhpcyw\n\tcv8hX+ne8P6p/nrkLHjfo/Tmp26141md2hiaonS5b27fLXlVtobTnjTugox23tM6fm\n\tt5ItxKDsGKH2GfWmOgjeZIBqWEtFEN+UpmbxNlY0=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 23 Nov 2021 22:40:09 +0000", "Message-Id": "<20211123224015.3619282-10-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20211123224015.3619282-1-kieran.bingham@ideasonboard.com>", "References": "<20211123224015.3619282-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 09/15] ipa: ipu3: Convert to pragma once", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Remove the verbose #ifndef/#define/#endif pattern for maintaining\nheader idempotency, and replace it with a simple #pragma once.\n\nThis simplifies the headers, and prevents redundant changes when\nheader files get moved.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/agc.h | 6 ++----\n src/ipa/ipu3/algorithms/algorithm.h | 6 ++----\n src/ipa/ipu3/algorithms/awb.h | 5 ++---\n src/ipa/ipu3/algorithms/blc.h | 6 ++----\n src/ipa/ipu3/algorithms/tone_mapping.h | 6 ++----\n src/ipa/ipu3/ipa_context.h | 6 ++----\n 6 files changed, 12 insertions(+), 23 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/agc.h b/src/ipa/ipu3/algorithms/agc.h\nindex a04a81fb8eae..96ec7005acb6 100644\n--- a/src/ipa/ipu3/algorithms/agc.h\n+++ b/src/ipa/ipu3/algorithms/agc.h\n@@ -4,8 +4,8 @@\n *\n * agc.h - IPU3 AGC/AEC mean-based control algorithm\n */\n-#ifndef __LIBCAMERA_IPU3_ALGORITHMS_AGC_H__\n-#define __LIBCAMERA_IPU3_ALGORITHMS_AGC_H__\n+\n+#pragma once\n \n #include <linux/intel-ipu3.h>\n \n@@ -59,5 +59,3 @@ private:\n } /* namespace ipa::ipu3::algorithms */\n \n } /* namespace libcamera */\n-\n-#endif /* __LIBCAMERA_IPU3_ALGORITHMS_AGC_H__ */\ndiff --git a/src/ipa/ipu3/algorithms/algorithm.h b/src/ipa/ipu3/algorithms/algorithm.h\nindex 43f5d8b058b5..16310ab16985 100644\n--- a/src/ipa/ipu3/algorithms/algorithm.h\n+++ b/src/ipa/ipu3/algorithms/algorithm.h\n@@ -4,8 +4,8 @@\n *\n * algorithm.h - IPU3 control algorithm interface\n */\n-#ifndef __LIBCAMERA_IPA_IPU3_ALGORITHM_H__\n-#define __LIBCAMERA_IPA_IPU3_ALGORITHM_H__\n+\n+#pragma once\n \n #include <libcamera/ipa/ipu3_ipa_interface.h>\n \n@@ -28,5 +28,3 @@ public:\n } /* namespace ipa::ipu3 */\n \n } /* namespace libcamera */\n-\n-#endif /* __LIBCAMERA_IPA_IPU3_ALGORITHM_H__ */\ndiff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\nindex b90782c1cb5c..ab4b0a338369 100644\n--- a/src/ipa/ipu3/algorithms/awb.h\n+++ b/src/ipa/ipu3/algorithms/awb.h\n@@ -4,8 +4,8 @@\n *\n * awb.h - IPU3 AWB control algorithm\n */\n-#ifndef __LIBCAMERA_IPU3_ALGORITHMS_AWB_H__\n-#define __LIBCAMERA_IPU3_ALGORITHMS_AWB_H__\n+\n+#pragma once\n \n #include <vector>\n \n@@ -86,4 +86,3 @@ private:\n } /* namespace ipa::ipu3::algorithms */\n \n } /* namespace libcamera*/\n-#endif /* __LIBCAMERA_IPU3_ALGORITHMS_AWB_H__ */\ndiff --git a/src/ipa/ipu3/algorithms/blc.h b/src/ipa/ipu3/algorithms/blc.h\nindex 4b7cb483fae6..d8da1748baba 100644\n--- a/src/ipa/ipu3/algorithms/blc.h\n+++ b/src/ipa/ipu3/algorithms/blc.h\n@@ -4,8 +4,8 @@\n *\n * black_correction.h - IPU3 Black Level Correction control\n */\n-#ifndef __LIBCAMERA_IPU3_ALGORITHMS_BLC_H__\n-#define __LIBCAMERA_IPU3_ALGORITHMS_BLC_H__\n+\n+#pragma once\n \n #include \"algorithm.h\"\n \n@@ -24,5 +24,3 @@ public:\n } /* namespace ipa::ipu3::algorithms */\n \n } /* namespace libcamera */\n-\n-#endif /* __LIBCAMERA_IPU3_ALGORITHMS_BLC_H__ */\ndiff --git a/src/ipa/ipu3/algorithms/tone_mapping.h b/src/ipa/ipu3/algorithms/tone_mapping.h\nindex 46dd6171b1d5..b727ab1e25a6 100644\n--- a/src/ipa/ipu3/algorithms/tone_mapping.h\n+++ b/src/ipa/ipu3/algorithms/tone_mapping.h\n@@ -4,8 +4,8 @@\n *\n * tone_mapping.h - IPU3 ToneMapping and Gamma control\n */\n-#ifndef __LIBCAMERA_IPU3_ALGORITHMS_TONE_MAPPING_H__\n-#define __LIBCAMERA_IPU3_ALGORITHMS_TONE_MAPPING_H__\n+\n+#pragma once\n \n #include \"algorithm.h\"\n \n@@ -29,5 +29,3 @@ private:\n } /* namespace ipa::ipu3::algorithms */\n \n } /* namespace libcamera */\n-\n-#endif /* __LIBCAMERA_IPU3_ALGORITHMS_TONE_MAPPING_H__ */\ndiff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\nindex fd97e240f3fa..c6dc08147321 100644\n--- a/src/ipa/ipu3/ipa_context.h\n+++ b/src/ipa/ipu3/ipa_context.h\n@@ -5,8 +5,8 @@\n * ipa_context.h - IPU3 IPA Context\n *\n */\n-#ifndef __LIBCAMERA_IPU3_IPA_CONTEXT_H__\n-#define __LIBCAMERA_IPU3_IPA_CONTEXT_H__\n+\n+#pragma once\n \n #include <linux/intel-ipu3.h>\n \n@@ -68,5 +68,3 @@ struct IPAContext {\n } /* namespace ipa::ipu3 */\n \n } /* namespace libcamera*/\n-\n-#endif /* __LIBCAMERA_IPU3_IPA_CONTEXT_H__ */\n", "prefixes": [ "libcamera-devel", "09/15" ] }