Patch Detail
Show a patch.
GET /api/1.1/patches/14735/?format=api
{ "id": 14735, "url": "https://patchwork.libcamera.org/api/1.1/patches/14735/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14735/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211123224015.3619282-5-kieran.bingham@ideasonboard.com>", "date": "2021-11-23T22:40:04", "name": "[libcamera-devel,04/15] libcamera: ipa: Convert to pragma once", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fe095506ed625f15df127b4278a23c8aba944115", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/14735/mbox/", "series": [ { "id": 2749, "url": "https://patchwork.libcamera.org/api/1.1/series/2749/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2749", "date": "2021-11-23T22:40:00", "name": "Use pragma once", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2749/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14735/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14735/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7511BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Nov 2021 22:40:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A91B604F9;\n\tTue, 23 Nov 2021 23:40:28 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E24A60121\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Nov 2021 23:40:21 +0100 (CET)", "from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 36AD0F95;\n\tTue, 23 Nov 2021 23:40:21 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NGuImxCu\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637707221;\n\tbh=PVSnTH2xPr8zG61fjaqufX7gEYVrpN/7MVkm/wrAtTw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NGuImxCuOc7WDUtMcqd8fOBHXSA6ReHWUIgzSfArTop71GeEKhkBGPD6GoQ10z48g\n\tnN5NmyZfr890vfnWdpcadJwLwOkGxAh61yn6QZOP2auzU1GRtBoDilF7HhzIgEDwpI\n\t2fNR8qYd0SLEU8Ja2UEewT/lKMIEStPd8HCaAR1w=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 23 Nov 2021 22:40:04 +0000", "Message-Id": "<20211123224015.3619282-5-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20211123224015.3619282-1-kieran.bingham@ideasonboard.com>", "References": "<20211123224015.3619282-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 04/15] libcamera: ipa: Convert to pragma\n\tonce", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Remove the verbose #ifndef/#define/#endif pattern for maintaining\nheader idempotency, and replace it with a simple #pragma once.\n\nThis simplifies the headers, and prevents redundant changes when\nheader files get moved.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/ipa/ipa_controls.h | 6 ++----\n include/libcamera/ipa/ipa_interface.h | 6 ++----\n include/libcamera/ipa/ipa_module_info.h | 6 ++----\n include/libcamera/ipa/raspberrypi.h | 6 ++----\n 4 files changed, 8 insertions(+), 16 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/ipa_controls.h b/include/libcamera/ipa/ipa_controls.h\nindex eec34d9267af..da1a759618e0 100644\n--- a/include/libcamera/ipa/ipa_controls.h\n+++ b/include/libcamera/ipa/ipa_controls.h\n@@ -4,8 +4,8 @@\n *\n * ipa_controls.h - IPA Control handling\n */\n-#ifndef __LIBCAMERA_IPA_CONTROLS_H__\n-#define __LIBCAMERA_IPA_CONTROLS_H__\n+\n+#pragma once\n \n #include <stdint.h>\n \n@@ -50,5 +50,3 @@ struct ipa_control_info_entry {\n #ifdef __cplusplus\n }\n #endif\n-\n-#endif /* __LIBCAMERA_IPA_CONTROLS_H__ */\ndiff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\nindex 1590584c1fb4..50ca0e7b0359 100644\n--- a/include/libcamera/ipa/ipa_interface.h\n+++ b/include/libcamera/ipa/ipa_interface.h\n@@ -4,8 +4,8 @@\n *\n * ipa_interface.h - Image Processing Algorithm interface\n */\n-#ifndef __LIBCAMERA_IPA_INTERFACE_H__\n-#define __LIBCAMERA_IPA_INTERFACE_H__\n+\n+#pragma once\n \n #include <stddef.h>\n #include <stdint.h>\n@@ -37,5 +37,3 @@ public:\n extern \"C\" {\n libcamera::IPAInterface *ipaCreate();\n }\n-\n-#endif /* __LIBCAMERA_IPA_INTERFACE_H__ */\ndiff --git a/include/libcamera/ipa/ipa_module_info.h b/include/libcamera/ipa/ipa_module_info.h\nindex 3b1c37d2a7f1..b19b00f71a9b 100644\n--- a/include/libcamera/ipa/ipa_module_info.h\n+++ b/include/libcamera/ipa/ipa_module_info.h\n@@ -4,8 +4,8 @@\n *\n * ipa_module_info.h - Image Processing Algorithm module information\n */\n-#ifndef __LIBCAMERA_IPA_MODULE_INFO_H__\n-#define __LIBCAMERA_IPA_MODULE_INFO_H__\n+\n+#pragma once\n \n #include <stdint.h>\n \n@@ -25,5 +25,3 @@ extern const struct IPAModuleInfo ipaModuleInfo;\n }\n \n } /* namespace libcamera */\n-\n-#endif /* __LIBCAMERA_IPA_MODULE_INFO_H__ */\ndiff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\nindex 521eaecd19b2..7f705e49411d 100644\n--- a/include/libcamera/ipa/raspberrypi.h\n+++ b/include/libcamera/ipa/raspberrypi.h\n@@ -4,8 +4,8 @@\n *\n * raspberrypi.h - Image Processing Algorithm interface for Raspberry Pi\n */\n-#ifndef __LIBCAMERA_IPA_INTERFACE_RASPBERRYPI_H__\n-#define __LIBCAMERA_IPA_INTERFACE_RASPBERRYPI_H__\n+\n+#pragma once\n \n #include <stdint.h>\n \n@@ -53,5 +53,3 @@ static const ControlInfoMap Controls({\n } /* namespace libcamera */\n \n #endif /* __DOXYGEN__ */\n-\n-#endif /* __LIBCAMERA_IPA_INTERFACE_RASPBERRYPI_H__ */\n", "prefixes": [ "libcamera-devel", "04/15" ] }