Patch Detail
Show a patch.
GET /api/1.1/patches/14716/?format=api
{ "id": 14716, "url": "https://patchwork.libcamera.org/api/1.1/patches/14716/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14716/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211123150423.125524-4-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-11-23T15:04:15", "name": "[libcamera-devel,v3,03/11] ipa: Do not modify the sensor limits", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c6d60a8994957f240a5431fe0244c8e8b5c8cc63", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14716/mbox/", "series": [ { "id": 2746, "url": "https://patchwork.libcamera.org/api/1.1/series/2746/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2746", "date": "2021-11-23T15:04:12", "name": "Introduce AGC for RkISP1", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2746/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14716/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14716/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20008BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Nov 2021 15:04:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A1BA6022F;\n\tTue, 23 Nov 2021 16:04:35 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 42AAF60230\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Nov 2021 16:04:28 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:3c3b:9149:b:8aa9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE2D2993;\n\tTue, 23 Nov 2021 16:04:27 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Dmn+Vkr4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637679868;\n\tbh=RjPFSEqcQzvjL+C53oA43iFIzoqXgn3nfL7xrF1B5w0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Dmn+Vkr4gNmGPMh6cKquBMOeuSvm18SPmcn9ZXbpRB2QWuc3aZUR7iSCaV4Un+S0S\n\tXCvQWA6YE1ZdtPlFoskB36TkmyyG6pktt6qnBFkinh2pxfaD41M3C98sGzhwAGX/K5\n\tVib0gTBvSgrZroGpAekizt+mP91l/Q7OFZ6Nf7yU=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 23 Nov 2021 16:04:15 +0100", "Message-Id": "<20211123150423.125524-4-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211123150423.125524-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211123150423.125524-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 03/11] ipa: Do not modify the sensor\n\tlimits", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The driver is responsible of setting the proper limits for its controls.\nFor instance, imx219 has an analogue gain of 1.0 when the gain code is\nset to 0. The minimum analogue is forced to be at least 1, which for\nimx219 sets it to 1.00329. Rework this for both IPU3 and RkISP1.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 4 ++--\n src/ipa/rkisp1/rkisp1.cpp | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex a8d54a5d..b0c75541 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -444,11 +444,11 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n \t\treturn -EINVAL;\n \t}\n \n-\tminExposure_ = std::max(itExp->second.min().get<int32_t>(), 1);\n+\tminExposure_ = itExp->second.min().get<int32_t>();\n \tmaxExposure_ = itExp->second.max().get<int32_t>();\n \texposure_ = minExposure_;\n \n-\tminGain_ = std::max(itGain->second.min().get<int32_t>(), 1);\n+\tminGain_ = itGain->second.min().get<int32_t>();\n \tmaxGain_ = itGain->second.max().get<int32_t>();\n \tgain_ = minGain_;\n \ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 7ecbf8ae..910ad952 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -139,11 +139,11 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\n \n \tautoExposure_ = true;\n \n-\tminExposure_ = std::max<uint32_t>(itExp->second.min().get<int32_t>(), 1);\n+\tminExposure_ = itExp->second.min().get<int32_t>();\n \tmaxExposure_ = itExp->second.max().get<int32_t>();\n \texposure_ = minExposure_;\n \n-\tminGain_ = std::max<uint32_t>(itGain->second.min().get<int32_t>(), 1);\n+\tminGain_ = itGain->second.min().get<int32_t>();\n \tmaxGain_ = itGain->second.max().get<int32_t>();\n \tgain_ = minGain_;\n \n", "prefixes": [ "libcamera-devel", "v3", "03/11" ] }