Patch Detail
Show a patch.
GET /api/1.1/patches/14699/?format=api
{ "id": 14699, "url": "https://patchwork.libcamera.org/api/1.1/patches/14699/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14699/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211123104042.3100902-4-paul.elder@ideasonboard.com>", "date": "2021-11-23T10:40:38", "name": "[libcamera-devel,3/7] android: camera_metadata: Add appendEntry helper", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "02d0d9cee3a0e8b20e5315cef132fced09330117", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/14699/mbox/", "series": [ { "id": 2742, "url": "https://patchwork.libcamera.org/api/1.1/series/2742/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2742", "date": "2021-11-23T10:40:35", "name": "android: Miscellaneous fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2742/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14699/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14699/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DCFB3BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Nov 2021 10:41:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 96B1860398;\n\tTue, 23 Nov 2021 11:41:07 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2AED06033C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Nov 2021 11:41:04 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C292DA1B;\n\tTue, 23 Nov 2021 11:41:02 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qQbBa1Lx\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637664064;\n\tbh=s9Rs+u6OhvJblp2sk0T3CF3w3kgC5jPMWV7ntWkFZkU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=qQbBa1Lx50RnHHTpIGiEfHTc8lwI8kIS88bX50LLrAyQG5aMhusgS0PjfD77zmTpt\n\tyJjPePmbpwe/iGsgQR1Gsaj6tllKHLm44gE8KoSKxG8hYBURTITbVvlMrQkqJNjysu\n\tcfFJZuVGbNDPDTf5cZEHPrGorgNIluua8flRWeBw=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 23 Nov 2021 19:40:38 +0900", "Message-Id": "<20211123104042.3100902-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20211123104042.3100902-1-paul.elder@ideasonboard.com>", "References": "<20211123104042.3100902-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/7] android: camera_metadata: Add\n\tappendEntry helper", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add appendEntry() helper, that automatically detects if updateEntry() or\naddEntry() should be used.\n\nFor now only implement it for enums and arithmetic values, as they will\nmainly be used in populating templates, where the preview template\ngenerator may or may not have (based on capabilities) already added a\nkey.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/android/camera_metadata.h | 11 +++++++++++\n 1 file changed, 11 insertions(+)", "diff": "diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\nindex 8555c7c3..cca14d6c 100644\n--- a/src/android/camera_metadata.h\n+++ b/src/android/camera_metadata.h\n@@ -33,6 +33,17 @@ public:\n \n \tbool hasEntry(uint32_t tag) const;\n \n+\ttemplate<typename T,\n+\t\t std::enable_if_t<std::is_arithmetic_v<T> ||\n+\t\t\t\t std::is_enum_v<T>> * = nullptr>\n+\tbool appendEntry(uint32_t tag, const T &data)\n+\t{\n+\t\tif (hasEntry(tag))\n+\t\t\treturn updateEntry(tag, &data, 1, sizeof(T));\n+\t\telse\n+\t\t\treturn addEntry(tag, &data, 1, sizeof(T));\n+\t}\n+\n \ttemplate<typename T,\n \t\t std::enable_if_t<std::is_arithmetic_v<T> ||\n \t\t\t\t std::is_enum_v<T>> * = nullptr>\n", "prefixes": [ "libcamera-devel", "3/7" ] }