Patch Detail
Show a patch.
GET /api/1.1/patches/14693/?format=api
{ "id": 14693, "url": "https://patchwork.libcamera.org/api/1.1/patches/14693/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14693/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211123091451.67404-8-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-11-23T09:14:47", "name": "[libcamera-devel,v2,07/11] ipa: ipu3: Document AWB Algorithm overriden functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d6fd3cf1b1b81b64da068acd4b9e7c7cf1c20585", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14693/mbox/", "series": [ { "id": 2741, "url": "https://patchwork.libcamera.org/api/1.1/series/2741/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2741", "date": "2021-11-23T09:14:40", "name": "Introduce AGC for RkISP1", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2741/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14693/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14693/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2C7D3BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Nov 2021 09:15:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C8611603C4;\n\tTue, 23 Nov 2021 10:15:10 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2FBBB60121\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Nov 2021 10:14:58 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:3c3b:9149:b:8aa9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E4844A1B;\n\tTue, 23 Nov 2021 10:14:57 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M34pn5Ns\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637658898;\n\tbh=tFVCTeHjMgZumUa9l1ICA2t2tlOhFc2vD6qmehqHlX8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=M34pn5Nsnf8ViFHN626qEOpliSkwow8znJHKUcdItfdEW16RqorJB+HqFj4MQng1y\n\t1gHs2q0w+zYeqy+XkDjJGu0r0Iu/rWyr8TiK1K4MHyScf+9c47GoHmpHU6asjoCc8Z\n\tLtedErdfdzlwR8m8B17w1cBqejoNjAsK6aUeo4co=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 23 Nov 2021 10:14:47 +0100", "Message-Id": "<20211123091451.67404-8-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211123091451.67404-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211123091451.67404-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 07/11] ipa: ipu3: Document AWB\n\tAlgorithm overriden functions", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that Algorithm is defined in libipa, we miss documentation for the\nfunctions implemented in IPU3::Awb. Fix it.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/awb.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex c7bcb20e..85205333 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -193,6 +193,9 @@ Awb::Awb()\n \n Awb::~Awb() = default;\n \n+/**\n+ * \\brief Configure the AWB given a configInfo\n+ */\n int Awb::configure(IPAContext &context,\n \t\t [[maybe_unused]] const IPAConfigInfo &configInfo)\n {\n@@ -373,6 +376,9 @@ void Awb::calculateWBGains(const ipu3_uapi_stats_3a *stats)\n \t}\n }\n \n+/**\n+ * \\brief Process IPU3 statistics, and run algorithm operations\n+ */\n void Awb::process(IPAContext &context, const ipu3_uapi_stats_3a *stats)\n {\n \tcalculateWBGains(stats);\n@@ -394,6 +400,9 @@ constexpr uint16_t Awb::threshold(float value)\n \treturn value * 8191;\n }\n \n+/**\n+ * \\brief Fill the \\a params buffer with IPU3 processing parameters for a frame\n+ */\n void Awb::prepare(IPAContext &context, ipu3_uapi_params *params)\n {\n \t/*\n", "prefixes": [ "libcamera-devel", "v2", "07/11" ] }