Patch Detail
Show a patch.
GET /api/1.1/patches/14634/?format=api
{ "id": 14634, "url": "https://patchwork.libcamera.org/api/1.1/patches/14634/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14634/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211118164216.2669449-2-naush@raspberrypi.com>", "date": "2021-11-18T16:42:13", "name": "[libcamera-devel,v3,1/4] pipeline: raspberrypi: Add const qualifer in isRaw()", "commit_ref": "e0b870e615dda0b43e2b5778cfd797ba19aa4ba5", "pull_url": null, "state": "accepted", "archived": false, "hash": "bea63309db0714abca4b5bcbdb271f58de5f418c", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14634/mbox/", "series": [ { "id": 2727, "url": "https://patchwork.libcamera.org/api/1.1/series/2727/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2727", "date": "2021-11-18T16:42:12", "name": "raspberrypi: Rework the internal buffer allocation scheme", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2727/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14634/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14634/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 46D39BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Nov 2021 16:43:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EECEC60378;\n\tThu, 18 Nov 2021 17:43:11 +0100 (CET)", "from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n\t[IPv6:2a00:1450:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D23A660231\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Nov 2021 17:43:10 +0100 (CET)", "by mail-wr1-x433.google.com with SMTP id u1so12719149wru.13\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Nov 2021 08:43:10 -0800 (PST)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:328d:499d:f54a:e461])\n\tby smtp.gmail.com with ESMTPSA id\n\ta1sm496246wri.89.2021.11.18.08.43.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 18 Nov 2021 08:43:03 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"SEiecxE/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=cXVNeGLXDz6JtvQxKGu1TUTRWymUo0eSitm6CGOcfkI=;\n\tb=SEiecxE/Rw9nDwpAV7Awd0e5H6AkwVhFZFawFE4fo3xflHUH91SBneN2FSplL6kD+3\n\tDGne+S2yNFl6gJGsTxJlXb233G89HE1Nq7Blv0CgCPbp6dsT9n9vgyoDR8VFTEOQsRAt\n\t/6P4RHZdDdMrWnE9sePLuXPqTKghAHoMdod9i8gfibv4D5O+fXzlJ6PA2soHS+WoGr3S\n\tNvIzAe2NhP9N0FT/mckJA6MAz5DG77lsN3qpSNUqBmg41J8NzxxTiexfPOvLCrWi036d\n\tikD7F7zMoj7u1mASTBcZzd80MzahiKgd6YWUqk6vAjloKpj5klso9XbujnWaPH2zT7Oe\n\tF8Jg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=cXVNeGLXDz6JtvQxKGu1TUTRWymUo0eSitm6CGOcfkI=;\n\tb=MnLJRV7xprtzeCoFm3Y5K7tdQAfNN/CVeMpvCrfOuNC6kZ5iCkD3i5afHP0Bio75b1\n\tZ7vSKk5OTHbBa+eaCd52KuCcu62Qn7EYhZa76KjZm0TisTNev3Bdv1Ht5jrv4RzANFo4\n\tmrbiPRHhCwM4Q6Tvg/g6ZQxtYfnOyD4jeuJmc3zGgr1k8KvbW/StdS7pimk/PrDV+acQ\n\trZS8qVk9MhLnfRIOL5yatsrFQ1wjgqKxxIkHXIGdf4ojoWcjoR5B7U/kUVVzF5msp6XU\n\t8Uaq1QD4lTPK407EnVAlU8GwsrWQfh+joDdkxkfXdcdpaYSHrSrmRDwdyoBTi6WAu1al\n\tFDlw==", "X-Gm-Message-State": "AOAM531u3nTuT+ikaiaXPZek+X8FTZKO2kMNyIWWignuiqV9VQzDNJjv\n\t7MHbFtATSzdUdHonYQsvoDEDRcCcPWKewBpu", "X-Google-Smtp-Source": "ABdhPJxdnghQUjowsnulE3ES4nKut4RJ/6HoUyiy+UD2iWSdCFYt2wxtyzdQtpIg99Y7C92CbncEow==", "X-Received": "by 2002:a5d:43c5:: with SMTP id v5mr33502486wrr.11.1637253790421;\n\tThu, 18 Nov 2021 08:43:10 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 18 Nov 2021 16:42:13 +0000", "Message-Id": "<20211118164216.2669449-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211118164216.2669449-1-naush@raspberrypi.com>", "References": "<20211118164216.2669449-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 1/4] pipeline: raspberrypi: Add const\n\tqualifer in isRaw()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This function does not modify the pixFmt parameter, so use a const qualifier.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 5e1f227398a9..11d3c2b120dd 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -96,7 +96,7 @@ V4L2DeviceFormat toV4L2DeviceFormat(const V4L2SubdeviceFormat &format,\n \treturn deviceFormat;\n }\n \n-bool isRaw(PixelFormat &pixFmt)\n+bool isRaw(const PixelFormat &pixFmt)\n {\n \t/*\n \t * The isRaw test might be redundant right now the pipeline handler only\n", "prefixes": [ "libcamera-devel", "v3", "1/4" ] }