Patch Detail
Show a patch.
GET /api/1.1/patches/14580/?format=api
{ "id": 14580, "url": "https://patchwork.libcamera.org/api/1.1/patches/14580/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14580/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211111140928.136111-11-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-11-11T14:09:24", "name": "[libcamera-devel,v4,10/14] ipa: ipu3: awb: Add support for color temperature", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3134f68a04c9112b9d04b81e4ff3a6a24a4a8ce6", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14580/mbox/", "series": [ { "id": 2714, "url": "https://patchwork.libcamera.org/api/1.1/series/2714/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2714", "date": "2021-11-11T14:09:14", "name": "IPA: IPU3: Introduce per-frame controls", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2714/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14580/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14580/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B8CAC324F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 11 Nov 2021 14:09:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12252603C2;\n\tThu, 11 Nov 2021 15:09:44 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CDA760345\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Nov 2021 15:09:33 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:e627:8337:a781:d98])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D8EE4180D;\n\tThu, 11 Nov 2021 15:09:32 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WZDbrs1c\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636639772;\n\tbh=4tNa6FTLtligxhLvhqy7ErCQZN9FVjZQl++ok5GJQiU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WZDbrs1cq4cIl+PtS99WDqlKUUcaH7+szCUhYYEzQag4LW0I8OmmRDMeErSS0c8Pu\n\t/8f9+zYRzzDxQBg5CpzA1+wpUbCWz68Gg3JqM2+0c1u4dp/lo9h7qButmp9Q3VORbo\n\t8X/bi06Evh3uJXLKrKzarfRaMu9Foe42hZvGvtG0=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 11 Nov 2021 15:09:24 +0100", "Message-Id": "<20211111140928.136111-11-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211111140928.136111-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211111140928.136111-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 10/14] ipa: ipu3: awb: Add support for\n\tcolor temperature", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The AWB estimates the color temperature, but it is not used at all. It\ncan be useful for debug purpose at least, but also for lux estimation\nlater, to be able to know the temperature estimated for a given frame.\n\nAdd a new member to the IPAFrameContext::awb for this purpose, and\nupdate the value in AWB.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/awb.cpp | 1 +\n src/ipa/ipu3/ipa_context.cpp | 3 +++\n src/ipa/ipu3/ipa_context.h | 2 ++\n 3 files changed, 6 insertions(+)", "diff": "diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex a4114659..c7bcb20e 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -385,6 +385,7 @@ void Awb::process(IPAContext &context, const ipu3_uapi_stats_3a *stats)\n \tcontext.frameContext.awb.gains.blue = asyncResults_.blueGain;\n \tcontext.frameContext.awb.gains.green = asyncResults_.greenGain;\n \tcontext.frameContext.awb.gains.red = asyncResults_.redGain;\n+\tcontext.frameContext.awb.temperatureK = asyncResults_.temperatureK;\n }\n \n constexpr uint16_t Awb::threshold(float value)\ndiff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\nindex a7ff957d..99caf9ad 100644\n--- a/src/ipa/ipu3/ipa_context.cpp\n+++ b/src/ipa/ipu3/ipa_context.cpp\n@@ -117,6 +117,9 @@ namespace libcamera::ipa::ipu3 {\n *\n * \\var IPAFrameContext::awb.gains.blue\n * \\brief White balance gain for B channel\n+ *\n+ * \\var IPAFrameContext::awb.temperatureK\n+ * \\brief Estimated color temperature\n */\n \n /**\ndiff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\nindex a5a19800..fd97e240 100644\n--- a/src/ipa/ipu3/ipa_context.h\n+++ b/src/ipa/ipu3/ipa_context.h\n@@ -45,6 +45,8 @@ struct IPAFrameContext {\n \t\t\tdouble green;\n \t\t\tdouble blue;\n \t\t} gains;\n+\n+\t\tdouble temperatureK;\n \t} awb;\n \n \tstruct {\n", "prefixes": [ "libcamera-devel", "v4", "10/14" ] }