Patch Detail
Show a patch.
GET /api/1.1/patches/14534/?format=api
{ "id": 14534, "url": "https://patchwork.libcamera.org/api/1.1/patches/14534/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14534/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211110195901.85597-7-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-11-10T19:58:53", "name": "[libcamera-devel,v2,06/14] ipa: ipu3: agc: Refactor ev gain calculation and testing", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "559b8f8d92010904d13c89db615754eab49ac511", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14534/mbox/", "series": [ { "id": 2708, "url": "https://patchwork.libcamera.org/api/1.1/series/2708/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2708", "date": "2021-11-10T19:58:47", "name": "IPA: IPU3: Introduce per-frame controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2708/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14534/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14534/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1CC4FC324F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Nov 2021 19:59:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7AAA6038C;\n\tWed, 10 Nov 2021 20:59:14 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CFF460362\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Nov 2021 20:59:07 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:7713:3465:89e6:c5cd])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F29CB8BB;\n\tWed, 10 Nov 2021 20:59:06 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cJDo7MCg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636574347;\n\tbh=xYoyXO2xIpO0T3PlvfATsenTDcmVIxKJiA7AEOKpRI8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cJDo7MCgHXXSaR1wrzFVYT/mRopkIUd8971w2Xk1P/WaRFNhWx9rjF7CGmayVQsmt\n\t9pva2VxnobjhfadEmf1ydFkw7bbdMyQ2416xaD3mgdM0yOrvAX4RBXM9ZYsxp10EiD\n\tfTXw8BVgMnqTmwIPxoyYZfI4WTKbLjRUlJp4UHm4=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 10 Nov 2021 20:58:53 +0100", "Message-Id": "<20211110195901.85597-7-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211110195901.85597-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211110195901.85597-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 06/14] ipa: ipu3: agc: Refactor ev gain\n\tcalculation and testing", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When we compute the new gain, we use the iqMean_ and estimate an\nexposure value gain to apply. Return early when the gain is less than\n1%.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/agc.cpp | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 133f5931..119a7938 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -189,17 +189,15 @@ void Agc::filterExposure()\n */\n void Agc::computeExposure(uint32_t &exposure, double &analogueGain)\n {\n+\t/* Estimate the gain needed to have the proportion wanted */\n+\tdouble evGain = kEvGainTarget * knumHistogramBins / iqMean_;\n \n-\t/* Are we correctly exposed ? */\n-\tif (std::abs(iqMean_ - kEvGainTarget * knumHistogramBins) <= 1) {\n+\tif (std::abs(evGain - 1.0) < 0.01) {\n \t\tLOG(IPU3Agc, Debug) << \"We are well exposed (iqMean = \"\n \t\t\t\t << iqMean_ << \")\";\n \t\treturn;\n \t}\n \n-\t/* Estimate the gain needed to have the proportion wanted */\n-\tdouble evGain = kEvGainTarget * knumHistogramBins / iqMean_;\n-\n \t/* extracted from Rpi::Agc::computeTargetExposure */\n \t/* Calculate the shutter time in seconds */\n \tutils::Duration currentShutter = exposure * lineDuration_;\n", "prefixes": [ "libcamera-devel", "v2", "06/14" ] }