Patch Detail
Show a patch.
GET /api/1.1/patches/14527/?format=api
{ "id": 14527, "url": "https://patchwork.libcamera.org/api/1.1/patches/14527/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14527/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211027230005.10649-1-laurent.pinchart@ideasonboard.com>", "date": "2021-10-27T23:00:05", "name": "[libcamera-devel] Documentation: Fixed build when the IPU3 pipeline handler is disabled", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8e42dc58e78824753a8bd7dd9ad3d57ad099ea3e", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14527/mbox/", "series": [ { "id": 2707, "url": "https://patchwork.libcamera.org/api/1.1/series/2707/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2707", "date": "2021-10-27T23:00:05", "name": "[libcamera-devel] Documentation: Fixed build when the IPU3 pipeline handler is disabled", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2707/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14527/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14527/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": [ "parsemail@patchwork.libcamera.org", "kbingham@ideasonboard.com" ], "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4F9DBDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Nov 2021 14:02:43 +0000 (UTC)", "from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 36474501\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Nov 2021 15:02:43 +0100 (CET)", "from perceval.ideasonboard.com\n\tby perceval.ideasonboard.com with LMTP id IL13MhHaeWH/NwAA4E0KoQ\n\t(envelope-from <libcamera-devel-bounces@lists.libcamera.org>)\n\tfor <kbingham@ideasonboard.com>; Thu, 28 Oct 2021 01:00:33 +0200", "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\tby perceval.ideasonboard.com (Postfix) with ESMTPS\n\tid B907A276;\tThu, 28 Oct 2021 01:00:33 +0200 (CEST)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 772A16487F;\n\tThu, 28 Oct 2021 01:00:33 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CAB6660128\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 Oct 2021 01:00:31 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6B876276\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 Oct 2021 01:00:31 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636552963;\n\tbh=IkjsaVC+TF1Y88oB+1SnMMSrHkHXT9WDkJYgV87hxjo=;\n\th=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\tList-Post:List-Help:List-Subscribe:Resent-From:Resent-To:From;\n\tb=d3EE5CVki9DqtPiRPMAHdfaEklvAf+0thSkCS3M3p4W/cKOwhTOqnNspUZDhB34MV\n\tidblhE2IYYNagPscG3Lz5DeZFsSSPN52oPR9l9v6wOdbmCHXU2/Gas5/MkUtze0YdZ\n\tkUBJhPx4imKUU4cYnbzc8n7Ibkq/iN1IXFABGwYE=", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635375631;\n\tbh=IkjsaVC+TF1Y88oB+1SnMMSrHkHXT9WDkJYgV87hxjo=;\n\th=From:To:Subject:Date:From;\n\tb=kwDGedCLyF/7qBYyvpXUtK7TVrhKvKFRWFPqs/iV5ff8JCpGQpyUknfxTQtA+miZP\n\tRxk/9dWwx2MhTD+Gr+M/543arhKujJt2EhciWfqs1YOcXv4ivueBhlZm27HwUtlTVA\n\t7dRXOqmPPO8mn67TIMLeE0StjGn7TCXxmfWVZR4w=" ], "Authentication-Results": [ "perceval.ideasonboard.com;\n\tdkim=fail reason=\"signature\n\tverification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com header.b=\"kwDGedCL\";\tdkim-atps=neutral", "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature\n\tverification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com header.b=\"kwDGedCL\";\tdkim-atps=neutral" ], "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 28 Oct 2021 02:00:05 +0300", "Message-Id": "<20211027230005.10649-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] Documentation: Fixed build when the IPU3\n\tpipeline handler is disabled", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>", "X-TUID": "CW4ZYe/rPrvk", "Resent-From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Resent-To": "parsemail@patchwork.libcamera.org" }, "content": "When the IPU3 pipeline handler is disabled, the corresponding IPA module\nisn't compiled, which results in the meson ipu3_ipa_sources variable to\nbe undefined. The variable is used unconditionally as part of the\nDoxygen inputs, so Meson complains at configuration time that it is\nundefined.\n\nFix it by including the IPU3 IPA documentation in the Doxygen build only\nwhen the IPU3 pipeline handler is enabled.\n\nFixes: 45dd51988952 (\"Documentation: Include IPU3 in Doxygen build\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n Documentation/meson.build | 31 ++++++++++++++++++-------------\n 1 file changed, 18 insertions(+), 13 deletions(-)\n\nbase-commit: 76bd9f3d80cb99a3391832b644b65a619427ed00", "diff": "diff --git a/Documentation/meson.build b/Documentation/meson.build\nindex df36a808dfb5..4c9726754a92 100644\n--- a/Documentation/meson.build\n+++ b/Documentation/meson.build\n@@ -19,20 +19,25 @@ if doxygen.found() and dot.found()\n output : 'Doxyfile',\n configuration : cdata)\n \n+ doxygen_input = [\n+ doxyfile,\n+ libcamera_base_headers,\n+ libcamera_base_sources,\n+ libcamera_internal_headers,\n+ libcamera_ipa_headers,\n+ libcamera_ipa_interfaces,\n+ libcamera_public_headers,\n+ libcamera_sources,\n+ libipa_headers,\n+ libipa_sources,\n+ ]\n+\n+ if is_variable('ipu3_ipa_sources')\n+ doxygen_input += [ipu3_ipa_sources]\n+ endif\n+\n custom_target('doxygen',\n- input : [\n- doxyfile,\n- ipu3_ipa_sources,\n- libcamera_base_headers,\n- libcamera_base_sources,\n- libcamera_internal_headers,\n- libcamera_ipa_headers,\n- libcamera_ipa_interfaces,\n- libcamera_public_headers,\n- libcamera_sources,\n- libipa_headers,\n- libipa_sources,\n- ],\n+ input : doxygen_input,\n output : 'api-html',\n command : [doxygen, doxyfile],\n install : true,\n", "prefixes": [ "libcamera-devel" ] }