Patch Detail
Show a patch.
GET /api/1.1/patches/14504/?format=api
{ "id": 14504, "url": "https://patchwork.libcamera.org/api/1.1/patches/14504/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14504/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211110020433.2778691-1-hiroh@chromium.org>", "date": "2021-11-10T02:04:33", "name": "[libcamera-devel,v3] lc-compliance: Build with gtest in subprojects", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bf7c1b01bad8ee06236db0dbb415d71e4494cfd3", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14504/mbox/", "series": [ { "id": 2699, "url": "https://patchwork.libcamera.org/api/1.1/series/2699/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2699", "date": "2021-11-10T02:04:33", "name": "[libcamera-devel,v3] lc-compliance: Build with gtest in subprojects", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2699/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14504/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14504/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1BC64BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Nov 2021 03:05:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53ADE6034E;\n\tWed, 10 Nov 2021 04:05:08 +0100 (CET)", "from mail-pl1-x636.google.com (mail-pl1-x636.google.com\n\t[IPv6:2607:f8b0:4864:20::636])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B84A260234\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Nov 2021 04:05:06 +0100 (CET)", "by mail-pl1-x636.google.com with SMTP id n8so1824367plf.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 09 Nov 2021 19:05:06 -0800 (PST)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:4a73:e1bd:9b3f:4903])\n\tby smtp.gmail.com with ESMTPSA id\n\tmz7sm4183349pjb.7.2021.11.09.19.05.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Nov 2021 19:05:04 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"LiyIElrn\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=YE5KQnJ22RaCNYBTSjV2YzUxCwMlx+/X3tplBUGoB4Y=;\n\tb=LiyIElrn4ocgvNPKEx85Qbl+jRzE2epquV+oyp1p14MduIRpU/3TB5+ihLT3dbWQ7A\n\tlU8ILSNumQ0Kz4TQ75jvp5IfSDp359Pxu9GQzxOsJ0j2F3PVWMEDjurCTHrFG3E8PRhG\n\t3Q7JuMjn9bpoO86hMr+94PVahL6BTDhssoDnA=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=YE5KQnJ22RaCNYBTSjV2YzUxCwMlx+/X3tplBUGoB4Y=;\n\tb=m3TogeByEioyC4TAEFxeV83kyNpAdA2+FXLusPIW7B3UKC8/50c3NCXqxzHY+Ldcpz\n\tSNp30QoZiNPFP8xmqX2R1qbJOtpfwlNXnnxtQIv4Z8L9SHrzFNP/vypIlNoJBujqIyO0\n\tdkHuEItJ91/fWGZgEqZmrwhIRxrWD+h4nH/04D+/EZwOCAs4bVwxbk1UY/toKhIaSPtd\n\tCYVaskB22i/5QYJkoBUUf8qblL1RQQ1pPLatupvzXu5YVE+uWlhRlVPu/kX3oxXYXVuW\n\tJYb3zRflpH/4PnZ1xyQ445MGivcLQW+1B0kAUy1ur4iuK1uoPWbTQ4e9GNhPDIus8fqq\n\tWPPg==", "X-Gm-Message-State": "AOAM533N2yIhs8XvD2cpnNHQU0dp705Gbp8rgkvIbjwRLXbkk62/op4/\n\tzXSVNK9TYCrx8TWo9iplDMp72U/31OlH+g==", "X-Google-Smtp-Source": "ABdhPJzXkpedlALplSC+PCBmxdxeSeC+mqFvctFIrhR0XZPGiT4PBF/1jU0KHMPGlTEbqfzp8914sg==", "X-Received": "by 2002:a17:90b:1bcf:: with SMTP id\n\toa15mr13223180pjb.161.1636513504660; \n\tTue, 09 Nov 2021 19:05:04 -0800 (PST)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 10 Nov 2021 11:04:33 +0900", "Message-Id": "<20211110020433.2778691-1-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.34.0.rc0.344.g81b53c2807-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3] lc-compliance: Build with gtest in\n\tsubprojects", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "libgtest-dev is provided as a static library at least Debian 10.\nThe compiler and linker to create the static library might be\ndifferent from ones used for libcamera. This causes a problem\nupon linking.\n\nThis puts gtest code to subprojects, builds the code and link it\nfor lc-compliance. However, libgtest is locally built as a library on\nChromeOS and thus the used compiler and linker are the same as one\nused for libcamera. We don't do these on ChromeOS build environment.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nTested-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n README.rst | 2 +-\n src/lc-compliance/meson.build | 16 ++++++++++++++--\n subprojects/.gitignore | 4 +++-\n subprojects/gtest.wrap | 14 ++++++++++++++\n 4 files changed, 32 insertions(+), 4 deletions(-)\n create mode 100644 subprojects/gtest.wrap", "diff": "diff --git a/README.rst b/README.rst\nindex 8af5f118..c48b4dba 100644\n--- a/README.rst\n+++ b/README.rst\n@@ -99,7 +99,7 @@ for android: [optional]\n libexif-dev libjpeg-dev libyaml-dev\n \n for lc-compliance: [optional]\n- libevent-dev libgtest-dev\n+ libevent-dev\n \n Using GStreamer plugin\n ~~~~~~~~~~~~~~~~~~~~~~\ndiff --git a/src/lc-compliance/meson.build b/src/lc-compliance/meson.build\nindex aa5852f6..8c43ef12 100644\n--- a/src/lc-compliance/meson.build\n+++ b/src/lc-compliance/meson.build\n@@ -1,15 +1,27 @@\n # SPDX-License-Identifier: CC0-1.0\n \n libevent = dependency('libevent_pthreads', required : get_option('lc-compliance'))\n-libgtest = dependency('gtest', required : get_option('lc-compliance'))\n \n-if not (libevent.found() and libgtest.found())\n+if not libevent.found()\n lc_compliance_enabled = false\n subdir_done()\n endif\n \n lc_compliance_enabled = true\n \n+if get_option('android_platform') == 'cros'\n+ libgtest = dependency('gtest', required : get_option('lc-compliance'))\n+\n+ if not libgtest.found()\n+ lc_compliance_enabled = false\n+ subdir_done()\n+ endif\n+\n+else\n+ libgtest_sp = subproject('gtest')\n+ libgtest = libgtest_sp.get_variable('gtest_dep')\n+endif\n+\n lc_compliance_sources = files([\n '../cam/event_loop.cpp',\n '../cam/options.cpp',\ndiff --git a/subprojects/.gitignore b/subprojects/.gitignore\nindex 410b8bd6..391fde2c 100644\n--- a/subprojects/.gitignore\n+++ b/subprojects/.gitignore\n@@ -1 +1,3 @@\n-/libyuv\n\\ No newline at end of file\n+/googletest-release*\n+/libyuv\n+/packagecache\n\\ No newline at end of file\ndiff --git a/subprojects/gtest.wrap b/subprojects/gtest.wrap\nnew file mode 100644\nindex 00000000..40128b35\n--- /dev/null\n+++ b/subprojects/gtest.wrap\n@@ -0,0 +1,14 @@\n+[wrap-file]\n+directory = googletest-release-1.11.0\n+source_url = https://github.com/google/googletest/archive/release-1.11.0.zip\n+source_filename = gtest-1.11.0.zip\n+source_hash = 353571c2440176ded91c2de6d6cd88ddd41401d14692ec1f99e35d013feda55a\n+patch_filename = gtest_1.11.0-1_patch.zip\n+patch_url = https://wrapdb.mesonbuild.com/v2/gtest_1.11.0-1/get_patch\n+patch_hash = d38c39184384608b08419be52aed1d0f9d9d1b5ed71c0c35e51cccbdddab7084\n+\n+[provide]\n+gtest = gtest_dep\n+gtest_main = gtest_main_dep\n+gmock = gmock_dep\n+gmock_main = gmock_main_dep\n", "prefixes": [ "libcamera-devel", "v3" ] }