Patch Detail
Show a patch.
GET /api/1.1/patches/14478/?format=api
{ "id": 14478, "url": "https://patchwork.libcamera.org/api/1.1/patches/14478/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14478/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211108131350.130665-9-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-11-08T13:13:36", "name": "[libcamera-devel,08/22] ipa: ipu3: agc: Update previous exposure value", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ae419cc7f8d68d14f3320610cc7aa7afc5cfe8bd", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14478/mbox/", "series": [ { "id": 2696, "url": "https://patchwork.libcamera.org/api/1.1/series/2696/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2696", "date": "2021-11-08T13:13:28", "name": "IPA: IPU3: Introduce per-frame controls", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2696/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14478/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14478/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35F94C324F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 8 Nov 2021 13:14:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B65A160362;\n\tMon, 8 Nov 2021 14:14:11 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6AE060369\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 8 Nov 2021 14:14:00 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:c2bb:76d0:68d7:a9a5])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 98EC8187C;\n\tMon, 8 Nov 2021 14:14:00 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"S+mVIz0q\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636377240;\n\tbh=C/oCPXfue5HN2TLOPr7mAjPhdhZpXtoy5/swaT55odc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=S+mVIz0qFE/Vk+P4k6xHvE3j1XNRyylHcYERLeoRsmUrPNTwtvGB3Nmp7xJ/8Fvoz\n\t3yRQ154t2ZaG+Wabk+ZC79yc9PfvoK+z1kI8JMhD2JMtAvq6/vr6+3N5LqdxFd5pbl\n\tbfMjqwJv4Ap4uYPYbY781GOC6B7H2IQJ6aSFAbMM=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 8 Nov 2021 14:13:36 +0100", "Message-Id": "<20211108131350.130665-9-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 08/22] ipa: ipu3: agc: Update previous\n\texposure value", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Previous exposure value is calculated based on the estimated shutter\ntime and gain applied. Now that we have the real values for the current\nframe, use those before estimating the next one.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/agc.cpp | 19 +++----------------\n 1 file changed, 3 insertions(+), 16 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex e4048d40..475e715f 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -193,15 +193,12 @@ void Agc::computeExposure(uint32_t &exposure, double &analogueGain, double curre\n \t/* Estimate the gain needed to have the proportion wanted */\n \tdouble evGain = kEvGainTarget * knumHistogramBins / iqMean_;\n \n-\tif (std::abs(evGain - 1.0) < 0.01) {\n-\t\tLOG(IPU3Agc, Debug) << \"We are well exposed (iqMean = \"\n-\t\t\t\t << iqMean_ << \")\";\n-\t\treturn;\n-\t}\n-\n \t/* extracted from Rpi::Agc::computeTargetExposure */\n \t/* Calculate the shutter time in seconds */\n \tutils::Duration currentShutter = exposure * lineDuration_;\n+\t/* Update the exposure value for the next computation. */\n+\tprevExposureValue_ = currentShutter * analogueGain;\n+\n \tLOG(IPU3Agc, Debug) << \"Actual total exposure \" << currentShutter * analogueGain\n \t\t\t << \" Shutter speed \" << currentShutter\n \t\t\t << \" Gain \" << analogueGain\n@@ -250,16 +247,6 @@ void Agc::computeExposure(uint32_t &exposure, double &analogueGain, double curre\n \n \texposure = shutterTime / lineDuration_;\n \tanalogueGain = stepGain;\n-\n-\t/*\n-\t * Update the exposure value for the next process call.\n-\t *\n-\t * \\todo Obtain the values of the exposure time and analog gain\n-\t * that were actually used by the sensor, either from embedded\n-\t * data when available, or from the delayed controls\n-\t * infrastructure in case a slow down caused a mismatch.\n-\t */\n-\tprevExposureValue_ = shutterTime * analogueGain;\n }\n \n /**\n", "prefixes": [ "libcamera-devel", "08/22" ] }