Patch Detail
Show a patch.
GET /api/1.1/patches/14472/?format=api
{ "id": 14472, "url": "https://patchwork.libcamera.org/api/1.1/patches/14472/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14472/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211108131350.130665-4-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-11-08T13:13:31", "name": "[libcamera-devel,03/22] ipa: ipu3: Use sensor controls to update frameContext", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b21a8c55972c9e35fc605e1266090828e4a2b0ad", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14472/mbox/", "series": [ { "id": 2696, "url": "https://patchwork.libcamera.org/api/1.1/series/2696/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2696", "date": "2021-11-08T13:13:28", "name": "IPA: IPU3: Introduce per-frame controls", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2696/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14472/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14472/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8AE7EBDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 8 Nov 2021 13:14:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 84C63603C4;\n\tMon, 8 Nov 2021 14:14:06 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08A3A6035D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 8 Nov 2021 14:14:00 +0100 (CET)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:c2bb:76d0:68d7:a9a5])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B8EAA18CE;\n\tMon, 8 Nov 2021 14:13:59 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WPxF2VzG\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636377239;\n\tbh=HIy4L0Vz8vpJyU8EqvVV7m8w9ft2/jrhgSbi7EG/G+g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WPxF2VzGqiWptQr6e7/uxMdT6WE2defVocxGyGzv2wqRrA3/qf9N2oEpio4U7hx4E\n\tI358T04y6q+ULYENASO1JKDtJ9Y3+WtSUKxAsYQwDMWSUFK0VnFhfKNiGBlC66pLcp\n\tK4cyaZsUyUDf3et3/0kxdDskds/vgxtC3CjPhhr0=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 8 Nov 2021 14:13:31 +0100", "Message-Id": "<20211108131350.130665-4-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211108131350.130665-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 03/22] ipa: ipu3: Use sensor controls to\n\tupdate frameContext", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The pipeline handler populates the new sensrControls ControlList, to\nhave the effective exposure and gain values for the current frame. This\nis done when a statistics buffer is received.\n\nMake those values the frameContext::agc values for the frame when the\nEventStatReady event is received.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex bcc3863b..b4e0d49f 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -549,6 +549,10 @@ void IPAIPU3::processEvent(const IPU3Event &event)\n \t\tconst ipu3_uapi_stats_3a *stats =\n \t\t\treinterpret_cast<ipu3_uapi_stats_3a *>(mem.data());\n \n+\t\t/* \\todo move those into processControls */\n+\t\tcontext_.frameContext.agc.exposure = event.sensorControls.get(V4L2_CID_EXPOSURE).get<int32_t>();\n+\t\tcontext_.frameContext.agc.gain = camHelper_->gain(event.sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get<int32_t>());\n+\n \t\tparseStatistics(event.frame, event.frameTimestamp, stats);\n \t\tbreak;\n \t}\n", "prefixes": [ "libcamera-devel", "03/22" ] }