Patch Detail
Show a patch.
GET /api/1.1/patches/14455/?format=api
{ "id": 14455, "url": "https://patchwork.libcamera.org/api/1.1/patches/14455/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14455/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211104111347.3781990-1-kieran.bingham@ideasonboard.com>", "date": "2021-11-04T11:13:47", "name": "[libcamera-devel] libcamera: framebuffer: Fix iscontiguous log message", "commit_ref": "4b8c50bda21aa77fd8ae356dbf4def50add7c184", "pull_url": null, "state": "accepted", "archived": false, "hash": "d7209cc52b2c88a150ce322cbbb2eb9a11d06152", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14455/mbox/", "series": [ { "id": 2689, "url": "https://patchwork.libcamera.org/api/1.1/series/2689/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2689", "date": "2021-11-04T11:13:47", "name": "[libcamera-devel] libcamera: framebuffer: Fix iscontiguous log message", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2689/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14455/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14455/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96E72BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 4 Nov 2021 11:13:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB55A6032F;\n\tThu, 4 Nov 2021 12:13:53 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03F926032C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Nov 2021 12:13:51 +0100 (CET)", "from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5EFFFE52;\n\tThu, 4 Nov 2021 12:13:51 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UhAn1CwE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636024431;\n\tbh=WGIO7PHNvpg/OzQhgKc9iOkoWC+pSuy0sBYjEqQ5Bms=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=UhAn1CwEXcBdlQAbBR0yoUeRYkE92a7RcsUfK2fJGDR5qo9oYCE2JdmT0no61m/fd\n\tYX8K1jtlqtDy0XKPJO8gaMNolMsOD7MwQRLgV4o2MNcfCnNRFVGF9IpCF++mIA/yqP\n\tkWcgo7uNkLw5Ox7+BY9lhgMCRk2N9crDniJY1d/c=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 4 Nov 2021 11:13:47 +0000", "Message-Id": "<20211104111347.3781990-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: framebuffer: Fix iscontiguous\n\tlog message", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Roman Stratiienko <roman.o.stratiienko@globallogic.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The isContiguous debug message is inverted.\nCorrect the logic.\n\nReported-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/framebuffer.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp\nindex d44a98babd05..337ea1155a38 100644\n--- a/src/libcamera/framebuffer.cpp\n+++ b/src/libcamera/framebuffer.cpp\n@@ -247,7 +247,7 @@ FrameBuffer::FrameBuffer(const std::vector<Plane> &planes, unsigned int cookie)\n \t}\n \n \tLOG(Buffer, Debug)\n-\t\t<< \"Buffer is \" << (isContiguous ? \"not \" : \"\") << \"contiguous\";\n+\t\t<< \"Buffer is \" << (isContiguous ? \"\" : \"not \") << \"contiguous\";\n \n \t_d()->isContiguous_ = isContiguous;\n }\n", "prefixes": [ "libcamera-devel" ] }