Patch Detail
Show a patch.
GET /api/1.1/patches/14454/?format=api
{ "id": 14454, "url": "https://patchwork.libcamera.org/api/1.1/patches/14454/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14454/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211104064252.2091330-4-hiroh@chromium.org>", "date": "2021-11-04T06:42:52", "name": "[libcamera-devel,v4,3/3] libcamera: pipeline: ipu3: Apply the requested test pattern mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e487c8a99ffafd3438ad258fbdf19c682486e5c2", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14454/mbox/", "series": [ { "id": 2688, "url": "https://patchwork.libcamera.org/api/1.1/series/2688/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2688", "date": "2021-11-04T06:42:49", "name": "Apply a sensor test pattern mode", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2688/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14454/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14454/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BBA70C324E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 4 Nov 2021 06:43:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 57F316033D;\n\tThu, 4 Nov 2021 07:43:06 +0100 (CET)", "from mail-pl1-x629.google.com (mail-pl1-x629.google.com\n\t[IPv6:2607:f8b0:4864:20::629])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0CF986033D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Nov 2021 07:43:05 +0100 (CET)", "by mail-pl1-x629.google.com with SMTP id k4so5628944plx.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 03 Nov 2021 23:43:04 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:9022:fd2e:f66e:b99b])\n\tby smtp.gmail.com with ESMTPSA id\n\ts6sm4265580pfu.137.2021.11.03.23.43.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 03 Nov 2021 23:43:02 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"EN025RLr\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=GlBe5o3IfiKGRsb6hEZvnIPGee2xBRdPPb3dmgbxfzA=;\n\tb=EN025RLrb1OtdI0RcqX/5ILp7vGKfw7W2J5CGhRD8AbftSUsVoEjn1VksP1eFbwuQE\n\t/lDDQ8NjUhQiYqKF/6vuvU9wkkLsxCFzxhleIJnC1v4znXksFSrImmXhRCvfOd849Lvk\n\tOQRuQJk/RyzgbXTHmsprFKfYJAUuX8QlVUwJU=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=GlBe5o3IfiKGRsb6hEZvnIPGee2xBRdPPb3dmgbxfzA=;\n\tb=qeZptontKhzLaigPAgxi8Zne23wDdKGnpZQ3JEPmqnblGUplnsPn35eoWuXNrw3vLc\n\tv0fNRHCNNOtMx11sWWSlerwEZPdMeYWWAss1yIR2XyzF0jKNpMkfdzLO4WZ94DA5ztMT\n\tswSFPO4jmi3HyNNny4J1ddx0oAIQEtB70kvM3r+I6BrcYsxpCVRZJIK8y+OoAXkV7xz1\n\tRegKHDhl3S9PvWlJ71aTLVr+qSHz1saCG4rnXcEL7MlNPpZ9Wp5trLaM7hy8yBIKpue1\n\tT3NLbm6hsrul0dHt8cZeErN0f8baLX9lnouG+b1B20aoEWSv5KLmT8wh5otIpwRCmVmW\n\tRP8A==", "X-Gm-Message-State": "AOAM530Hfa+aVsaPRBunyoKMo9gpZ0rz+20BE777cpu89hRtI3oxtKPF\n\t7WBzuZaLADUZcfrA3fTC13A+XnBlQBwaCA==", "X-Google-Smtp-Source": "ABdhPJyETqHxDglpztu0soOMFhojfs5OjW1rAOz6VuXu98D938zG4aHI1EBA7OsRuuKPEFSrMraZsQ==", "X-Received": "by 2002:a17:90b:4a89:: with SMTP id\n\tlp9mr20162763pjb.6.1636008183423; \n\tWed, 03 Nov 2021 23:43:03 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 4 Nov 2021 15:42:52 +0900", "Message-Id": "<20211104064252.2091330-4-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.33.1.1089.g2158813163f-goog", "In-Reply-To": "<20211104064252.2091330-1-hiroh@chromium.org>", "References": "<20211104064252.2091330-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 3/3] libcamera: pipeline: ipu3: Apply\n\tthe requested test pattern mode", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This enables ipu3 pipeline handler to apply the test pattern mode\nper frame.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 28 ++++++++++++++++++++++++++--\n 1 file changed, 26 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 63cb7f11..cb141ba9 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -59,6 +59,7 @@ public:\n \tvoid statBufferReady(FrameBuffer *buffer);\n \tvoid queuePendingRequests();\n \tvoid cancelPendingRequests();\n+\tvoid frameStart(uint32_t sequence);\n \n \tCIO2Device cio2_;\n \tImgUDevice *imgu_;\n@@ -78,6 +79,7 @@ public:\n \tstd::unique_ptr<ipa::ipu3::IPAProxyIPU3> ipa_;\n \n \tstd::queue<Request *> pendingRequests_;\n+\tstd::queue<Request *> processingRequests_;\n \n \tControlInfoMap ipaControls_;\n \n@@ -569,6 +571,8 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \tcio2->sensor()->sensorInfo(&sensorInfo);\n \tdata->cropRegion_ = sensorInfo.analogCrop;\n \n+\tcio2->sensor()->setTestPatternMode(controls::draft::TestPatternModeOff);\n+\n \t/*\n \t * Configure the H/V flip controls based on the combination of\n \t * the sensor and user transform.\n@@ -797,11 +801,13 @@ void PipelineHandlerIPU3::stop(Camera *camera)\n \tint ret = 0;\n \n \tdata->cancelPendingRequests();\n+\tdata->processingRequests_ = {};\n \n \tdata->ipa_->stop();\n \n \tret |= data->imgu_->stop();\n \tret |= data->cio2_.stop();\n+\n \tif (ret)\n \t\tLOG(IPU3, Warning) << \"Failed to stop camera \" << camera->id();\n \n@@ -852,6 +858,8 @@ void IPU3CameraData::queuePendingRequests()\n \n \t\tinfo->rawBuffer = rawBuffer;\n \n+\t\tprocessingRequests_.push(request);\n+\n \t\tipa::ipu3::IPU3Event ev;\n \t\tev.op = ipa::ipu3::EventProcessControls;\n \t\tev.frame = info->id;\n@@ -1131,8 +1139,8 @@ int PipelineHandlerIPU3::registerCameras()\n \t\tdata->delayedCtrls_ =\n \t\t\tstd::make_unique<DelayedControls>(cio2->sensor()->device(),\n \t\t\t\t\t\t\t params);\n-\t\tdata->cio2_.frameStart().connect(data->delayedCtrls_.get(),\n-\t\t\t\t\t\t &DelayedControls::applyControls);\n+\t\tdata->cio2_.frameStart().connect(data.get(),\n+\t\t\t\t\t\t &IPU3CameraData::frameStart);\n \n \t\t/* Convert the sensor rotation to a transformation */\n \t\tint32_t rotation = 0;\n@@ -1423,6 +1431,22 @@ void IPU3CameraData::statBufferReady(FrameBuffer *buffer)\n \tipa_->processEvent(ev);\n }\n \n+void IPU3CameraData::frameStart(uint32_t sequence)\n+{\n+\tif (!processingRequests_.empty()) {\n+\t\t/* Assumes applying the test pattern mode affects immediately. */\n+\t\tRequest *request = processingRequests_.front();\n+\t\tprocessingRequests_.pop();\n+\n+\t\tint ret = cio2_.sensor()->applyRequestControls(request);\n+\t\tif (ret)\n+\t\t\tLOG(IPU3, Error) << \"Failed applying controls: \" << ret;\n+\t}\n+\n+\t/* Controls that don't affect immediately are applied in delayedCtrls. */\n+\tdelayedCtrls_->applyControls(sequence);\n+}\n+\n REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3)\n \n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v4", "3/3" ] }