Patch Detail
Show a patch.
GET /api/1.1/patches/14445/?format=api
{ "id": 14445, "url": "https://patchwork.libcamera.org/api/1.1/patches/14445/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14445/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211101091510.23204-11-naush@raspberrypi.com>", "date": "2021-11-01T09:15:09", "name": "[libcamera-devel,v5,10/11] pipeline: raspberrypi: Remove \"unpacked\" format penalty in mode selection", "commit_ref": "ca67bf09f16900d0aa5480f7494b759d791efd4a", "pull_url": null, "state": "accepted", "archived": false, "hash": "a79f89c59e8a918bcaceeeb618a458a07c67eeeb", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14445/mbox/", "series": [ { "id": 2684, "url": "https://patchwork.libcamera.org/api/1.1/series/2684/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2684", "date": "2021-11-01T09:14:59", "name": "Raspberry Pi: Conversion to media controller", "version": 5, "mbox": "https://patchwork.libcamera.org/series/2684/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14445/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14445/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5FEC6C3250\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 1 Nov 2021 09:15:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 185A360253;\n\tMon, 1 Nov 2021 10:15:26 +0100 (CET)", "from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\n\t[IPv6:2a00:1450:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF4B2600C3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 1 Nov 2021 10:15:20 +0100 (CET)", "by mail-wr1-x42e.google.com with SMTP id k7so27090266wrd.13\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 01 Nov 2021 02:15:20 -0700 (PDT)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:3a2b:9d8c:92b9:ece6])\n\tby smtp.gmail.com with ESMTPSA id\n\tw10sm13168849wrq.88.2021.11.01.02.15.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 01 Nov 2021 02:15:19 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"nTvif4Eq\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=pNLu50p/bpoSwik19pLTW1p9L6Hq5BR0d1Kqq9L4id8=;\n\tb=nTvif4EqM9rGa+sartidXDNBQGwx0DR+dJTIysNxh7iRSfL2/22XQHzsIy4RjhZiE7\n\t3ZVnF1ZEqXnrvKcs06oEQe8vibmuWKQQ84uwp1nHcrNVu8oLCqSAhr78GMaRCuFwgowv\n\t4MnGFhqIPH2Vrb6eUhdHFPtvYiS3uEpg0ul+Xwx7KHvy91Lezz8tHhd/tRpC0L5kPtUJ\n\tmdlm5O9rAPwAiQHiHOkscVK+FeJmV4tjAPOrb7Sb/uHfVzzQTUMHcrYwbn1+Vj8frVkc\n\tSV4WyPT9XSaSINxWucitrGty+05lCI7acpxMRuSwOM5Tbz+0x7LTyLmwlB4rfpNziAY5\n\ttW7Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=pNLu50p/bpoSwik19pLTW1p9L6Hq5BR0d1Kqq9L4id8=;\n\tb=3S1ojf/u576l1vRrV5QAiOURXyWMpo2eIsnMzLc4k7S8CT2U+0VndzS7s5YLC8d2k8\n\tdycYT2WDuyCxDQN8QXvBHG8z9HVgq1v/mVNUb+Eae7nGTMG2408GQhXEBZwRhc1g2yec\n\tDLRezbF0pk8y42Emga4ZMtmHs16Tia/5U3pOUUTpgPdUSoWT24c5mGeluOWkRbhYKbFd\n\teY6nwr1mheW0hDNuwmYgrwkeI52agmqMj2vZ0XgHTMRjTxmpeezLJkKSioIJ41AkRaSi\n\t2igKAnVH2t2ehcCLO1oSP/Co145zbLWC7CO4dExuM5zlwuv7bZyPsOCddRNgVV+fUB6C\n\t+P9g==", "X-Gm-Message-State": "AOAM530v64jANHlRs24u5z8PAwTk1oP4YLrUbdsxeptwYFjFpYpPeWZE\n\tNrzF4GwiYCNb0emoWB/BkqxBsB12IzZ0/O1b", "X-Google-Smtp-Source": "ABdhPJzuDArb94LDBeoC77LY9mvs83IDRVZaBQWLyCJTHCn83KQap8VZrs05eqLTslIQlWIN/5xa7A==", "X-Received": "by 2002:adf:a2d7:: with SMTP id\n\tt23mr37582496wra.156.1635758120200; \n\tMon, 01 Nov 2021 02:15:20 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 1 Nov 2021 09:15:09 +0000", "Message-Id": "<20211101091510.23204-11-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211101091510.23204-1-naush@raspberrypi.com>", "References": "<20211101091510.23204-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 10/11] pipeline: raspberrypi: Remove\n\t\"unpacked\" format penalty in mode selection", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the recent change to switch to programming the sensor device directly,\nthe notion of packed vs unpacked modes are not relevent, since that is a\nUnicam format construct. Remove any scoring based on packed/unpacked modes.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 863516b997b2..996743cf48ef 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -131,7 +131,6 @@ V4L2SubdeviceFormat findBestFormat(const SensorFormats &formatsMap, const Size &\n #define PENALTY_8BIT\t\t2000.0\n #define PENALTY_10BIT\t\t1000.0\n #define PENALTY_12BIT\t\t 0.0\n-#define PENALTY_UNPACKED\t 500.0\n \n \t/* Calculate the closest/best mode from the user requested size. */\n \tfor (const auto &iter : formatsMap) {\n@@ -150,9 +149,6 @@ V4L2SubdeviceFormat findBestFormat(const SensorFormats &formatsMap, const Size &\n \t\t\tscore += PENALTY_AR * scoreFormat(reqAr, fmtAr);\n \n \t\t\t/* Add any penalties... this is not an exact science! */\n-\t\t\tif (!info.packed)\n-\t\t\t\tscore += PENALTY_UNPACKED;\n-\n \t\t\tif (info.bitsPerPixel == 12)\n \t\t\t\tscore += PENALTY_12BIT;\n \t\t\telse if (info.bitsPerPixel == 10)\n", "prefixes": [ "libcamera-devel", "v5", "10/11" ] }