Patch Detail
Show a patch.
GET /api/1.1/patches/14416/?format=api
{ "id": 14416, "url": "https://patchwork.libcamera.org/api/1.1/patches/14416/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14416/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211029115917.2467936-2-hanlinchen@chromium.org>", "date": "2021-10-29T11:59:15", "name": "[libcamera-devel,v2,2/4] ipu3: ipa: Report effective sensor controls with stastistics to IPA", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b9896c449966dbad2362097d27a36e541e9364b8", "submitter": { "id": 98, "url": "https://patchwork.libcamera.org/api/1.1/people/98/?format=api", "name": "Hanlin Chen", "email": "hanlinchen@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14416/mbox/", "series": [ { "id": 2680, "url": "https://patchwork.libcamera.org/api/1.1/series/2680/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2680", "date": "2021-10-29T11:59:14", "name": "[libcamera-devel,v2,1/4] ipa: ipu3: Extend ipu3 ipa interface for sensor and lens controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2680/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14416/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14416/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7FB2FBDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 29 Oct 2021 11:59:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3407A600BF;\n\tFri, 29 Oct 2021 13:59:33 +0200 (CEST)", "from mail-pg1-x534.google.com (mail-pg1-x534.google.com\n\t[IPv6:2607:f8b0:4864:20::534])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82B78600B8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Oct 2021 13:59:32 +0200 (CEST)", "by mail-pg1-x534.google.com with SMTP id e65so9689451pgc.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Oct 2021 04:59:32 -0700 (PDT)", "from localhost ([2401:fa00:1:10:35fe:d53b:684:b538])\n\tby smtp.gmail.com with UTF8SMTPSA id\n\ts6sm7058044pfu.137.2021.10.29.04.59.29\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tFri, 29 Oct 2021 04:59:30 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"bC5AkYXb\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=hjzU0vcbMQNXt//9GoOQNFctvc5bljeO++zFwPQaJEY=;\n\tb=bC5AkYXb0sxmIZsXY7v6NMpg2ZXYgqxa9HDGU5I94+8YiYIA2pS1RPvWriNfSAqLNS\n\t8UD0UgU2shih1BrV14A0VUqp00JwNZOnLieTeieAT4lNU1Kd1x0CXn+ExJcqMmhq0Xxk\n\tVs0Jfy+cKWDq2wl5fgd59aODzsHW56IVeRav0=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=hjzU0vcbMQNXt//9GoOQNFctvc5bljeO++zFwPQaJEY=;\n\tb=SucsQhQ1K6XCrQOMT6P3MedyuCCNfeAWddu4LBDkmz3inE+KFA1+4WqT0Ws+8ZaUcQ\n\tnEs3xYaLZjdUVu5mlPEHx7Hmr2wrDd3pLoVG8WaYg1+gvfv/3QrwxWOTgXEqge7qEfUx\n\tGcE505bXIpHdsv1f610HbPQZCyApPW1FB+A0McPM1wye8hiIryXRpo0FB0SNGaesTp//\n\t4zCl+bh4V5BX2NpOY1iYIUCefKFOreEKupMYF80t8xQZfaDeIClBial8g0gZSpWSQQ2E\n\tX7MChuQEWrwjHt0bdGT8dWOKMcbgRfhQlowkABoTe3+wuR2NDYQXB0aZ0CB/oiMkyzhr\n\t7LOA==", "X-Gm-Message-State": "AOAM532Ch25BSD3H60PEOi5NqSznuG54SnMCnaSid4ruFihN2T1r4m7t\n\t6bcVupsr88MEeWMlbx3qJ1wH/8/RRFsyGVOQ", "X-Google-Smtp-Source": "ABdhPJzvqLcLCLS7y0XS6pEBWgplhrm52gKHpiOCj7wPDIROWlczNSzh6DRA0CXM2bypwpzsHFL/PQ==", "X-Received": "by 2002:aa7:9633:0:b0:47b:ea78:f399 with SMTP id\n\tr19-20020aa79633000000b0047bea78f399mr10213250pfg.62.1635508770253; \n\tFri, 29 Oct 2021 04:59:30 -0700 (PDT)", "From": "Han-Lin Chen <hanlinchen@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 29 Oct 2021 19:59:15 +0800", "Message-Id": "<20211029115917.2467936-2-hanlinchen@chromium.org>", "X-Mailer": "git-send-email 2.33.1.1089.g2158813163f-goog", "In-Reply-To": "<20211029115917.2467936-1-hanlinchen@chromium.org>", "References": "<20211029115917.2467936-1-hanlinchen@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/4] ipu3: ipa: Report effective sensor\n\tcontrols with stastistics to IPA", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Intel close sourced IPA requires the effective controls applied to\nthe sensor when the stastistics are generated. Report effective sensor controls\nwith the stastistics to IPA.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\n---\n src/libcamera/pipeline/ipu3/frames.h | 3 +++\n src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +++++\n 2 files changed, 8 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/frames.h b/src/libcamera/pipeline/ipu3/frames.h\nindex 3ef7e445..a897e307 100644\n--- a/src/libcamera/pipeline/ipu3/frames.h\n+++ b/src/libcamera/pipeline/ipu3/frames.h\n@@ -12,6 +12,7 @@\n #include <queue>\n #include <vector>\n \n+#include <libcamera/controls.h>\n #include <libcamera/base/signal.h>\n \n namespace libcamera {\n@@ -34,6 +35,8 @@ public:\n \t\tFrameBuffer *paramBuffer;\n \t\tFrameBuffer *statBuffer;\n \n+\t\tControlList effectiveSensorControls;\n+\n \t\tbool paramDequeued;\n \t\tbool metadataProcessed;\n \t};\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 8816efc5..6a7f5b9a 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -667,6 +667,8 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \t\treturn ret;\n \t}\n \n+\tdata->delayedCtrls_->reset();\n+\n \treturn updateControls(data);\n }\n \n@@ -1363,6 +1365,8 @@ void IPU3CameraData::cio2BufferReady(FrameBuffer *buffer)\n \trequest->metadata().set(controls::SensorTimestamp,\n \t\t\t\tbuffer->metadata().timestamp);\n \n+\tinfo->effectiveSensorControls = delayedCtrls_->get(buffer->metadata().sequence);\n+\n \tif (request->findBuffer(&rawStream_))\n \t\tpipe()->completeBuffer(request, buffer);\n \n@@ -1419,6 +1423,7 @@ void IPU3CameraData::statBufferReady(FrameBuffer *buffer)\n \tev.frame = info->id;\n \tev.bufferId = info->statBuffer->cookie();\n \tev.frameTimestamp = request->metadata().get(controls::SensorTimestamp);\n+\tev.sensorControls = info->effectiveSensorControls;\n \tipa_->processEvent(ev);\n }\n \n", "prefixes": [ "libcamera-devel", "v2", "2/4" ] }