Patch Detail
Show a patch.
GET /api/1.1/patches/14367/?format=api
{ "id": 14367, "url": "https://patchwork.libcamera.org/api/1.1/patches/14367/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14367/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211027124147.356651-1-umang.jain@ideasonboard.com>", "date": "2021-10-27T12:41:47", "name": "[libcamera-devel] android: Camera3RequestDescriptor: Provide a constructor for StreamBuffer", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "21249f71032b6ff041f3d5c45083bf64f1ff1a9e", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14367/mbox/", "series": [ { "id": 2664, "url": "https://patchwork.libcamera.org/api/1.1/series/2664/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2664", "date": "2021-10-27T12:41:47", "name": "[libcamera-devel] android: Camera3RequestDescriptor: Provide a constructor for StreamBuffer", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2664/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14367/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14367/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F156BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 27 Oct 2021 12:41:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BFF806487F;\n\tWed, 27 Oct 2021 14:41:55 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2BFDB60123\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 27 Oct 2021 14:41:54 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.211])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 033B8596;\n\tWed, 27 Oct 2021 14:41:52 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AA/uRH1f\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635338513;\n\tbh=aFBQ1/k0w7h4CUShvra+HucLvAN7MX5MTP+ldvslHas=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=AA/uRH1f+OboeFWl868ORSmIr9g2GgkCFj7nA6FoJhwB7pJ8m9CfPzk7L91uuxTKV\n\tljNLpXzpzyP4BN75U+zeVqxmC8hbDM+vwpmEJRDzm1SGYWvT2T/ClEVF+KMOtbt6zb\n\tqWWi900FWxgTkyC0YkKOqNszVrkbC1Q1Pl9FU6s0=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 27 Oct 2021 18:11:47 +0530", "Message-Id": "<20211027124147.356651-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] android: Camera3RequestDescriptor:\n\tProvide a constructor for StreamBuffer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide a constructor for StreamBuffer and use that while populating\nCamera3RequestDescriptor::buffers_ vector. Also provide the default\nmove-constructor (required as StreamBuffer is stored in a vector in\nCamera3RequestDescriptor) and destructor for the StreamBuffer struct.\n\nAlso initialize pointers members in the StreamBuffer struct to nullptr,\nwith StreamBuffer::status set to Status::Success.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/android/camera_request.cpp | 16 +++++++++++++---\n src/android/camera_request.h | 12 +++++++++---\n 2 files changed, 22 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/android/camera_request.cpp b/src/android/camera_request.cpp\nindex 5bac1b8f..0b2946fb 100644\n--- a/src/android/camera_request.cpp\n+++ b/src/android/camera_request.cpp\n@@ -37,9 +37,7 @@ Camera3RequestDescriptor::Camera3RequestDescriptor(\n \t\tCameraStream *stream =\n \t\t\tstatic_cast<CameraStream *>(buffer.stream->priv);\n \n-\t\tbuffers_.push_back({ stream, buffer.buffer, nullptr,\n-\t\t\t\t buffer.acquire_fence, Status::Success,\n-\t\t\t\t nullptr, nullptr, nullptr, this });\n+\t\tbuffers_.emplace_back(stream, buffer, this);\n \t}\n \n \t/* Clone the controls associated with the camera3 request. */\n@@ -54,3 +52,15 @@ Camera3RequestDescriptor::Camera3RequestDescriptor(\n }\n \n Camera3RequestDescriptor::~Camera3RequestDescriptor() = default;\n+\n+Camera3RequestDescriptor::StreamBuffer::StreamBuffer(\n+\tCameraStream *stream, const camera3_stream_buffer_t &buffer,\n+\tCamera3RequestDescriptor *request)\n+\t: camera3Buffer(buffer.buffer), fence(buffer.acquire_fence),\n+\t stream(stream), request(request)\n+{\n+}\n+\n+Camera3RequestDescriptor::StreamBuffer::~StreamBuffer() = default;\n+\n+Camera3RequestDescriptor::StreamBuffer::StreamBuffer(StreamBuffer &&other) = default;\ndiff --git a/src/android/camera_request.h b/src/android/camera_request.h\nindex cfafa445..0a744aca 100644\n--- a/src/android/camera_request.h\n+++ b/src/android/camera_request.h\n@@ -34,13 +34,19 @@ public:\n \t};\n \n \tstruct StreamBuffer {\n+\t\tStreamBuffer(CameraStream *stream,\n+\t\t\t const camera3_stream_buffer_t &buffer,\n+\t\t\t Camera3RequestDescriptor *request);\n+\t\tStreamBuffer(StreamBuffer &&other);\n+\t\t~StreamBuffer();\n+\n \t\tCameraStream *stream;\n \t\tbuffer_handle_t *camera3Buffer;\n \t\tstd::unique_ptr<libcamera::FrameBuffer> frameBuffer;\n \t\tint fence;\n-\t\tStatus status;\n-\t\tlibcamera::FrameBuffer *internalBuffer;\n-\t\tconst libcamera::FrameBuffer *srcBuffer;\n+\t\tStatus status = Status::Success;\n+\t\tlibcamera::FrameBuffer *internalBuffer = nullptr;\n+\t\tconst libcamera::FrameBuffer *srcBuffer = nullptr;\n \t\tstd::unique_ptr<CameraBuffer> dstBuffer;\n \t\tCamera3RequestDescriptor *request;\n \t};\n", "prefixes": [ "libcamera-devel" ] }