Patch Detail
Show a patch.
GET /api/1.1/patches/14295/?format=api
{ "id": 14295, "url": "https://patchwork.libcamera.org/api/1.1/patches/14295/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14295/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211025203833.122460-2-umang.jain@ideasonboard.com>", "date": "2021-10-25T20:38:27", "name": "[libcamera-devel,v7,1/7] android: camera_stream: Replace post-processor nullptr check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6115da5402a5fce179ff181ce96ace089506fa0f", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/1.1/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/14295/mbox/", "series": [ { "id": 2653, "url": "https://patchwork.libcamera.org/api/1.1/series/2653/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2653", "date": "2021-10-25T20:38:26", "name": "Async Post Processor", "version": 7, "mbox": "https://patchwork.libcamera.org/series/2653/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14295/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14295/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2426BBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 25 Oct 2021 20:38:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA84C6487B;\n\tMon, 25 Oct 2021 22:38:45 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62F586486E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Oct 2021 22:38:44 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.211])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D52B7119F;\n\tMon, 25 Oct 2021 22:38:42 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OpuzZ8c6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635194324;\n\tbh=Rfs5vxK5XN2WVTefTRqQ59wwjvesdClvoK29ikEUPZ4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OpuzZ8c6erYemdSX7LwbITsmt6SaroiDoCjpQZtI73BXPdJmaHr+Yj0Lc8l1hPzr+\n\t2yRw7nY3gtp8ZdAI4NhQa307dNy9qW6CFn/UiGzJFExQmkqECKvm3h/s1vSF9tg4q6\n\taEWDe9lQr3xIPQjXuFUyOrRhCGZNs6fsMPnp+014=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 26 Oct 2021 02:08:27 +0530", "Message-Id": "<20211025203833.122460-2-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20211025203833.122460-1-umang.jain@ideasonboard.com>", "References": "<20211025203833.122460-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v7 1/7] android: camera_stream: Replace\n\tpost-processor nullptr check", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Instead of checking postProcessor for nullptr, replace this\ncheck with an assertion that checks if the camera stream's\ntype is not Type::Direct. Since it makes no sense to call\nCameraStream::process() on a Type::Direct camera stream.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/android/camera_stream.cpp | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\nindex f44a2717..5d991fe5 100644\n--- a/src/android/camera_stream.cpp\n+++ b/src/android/camera_stream.cpp\n@@ -150,6 +150,8 @@ int CameraStream::process(const FrameBuffer &source,\n \t\t\t Camera3RequestDescriptor::StreamBuffer &dest,\n \t\t\t Camera3RequestDescriptor *request)\n {\n+\tASSERT(type_ != Type::Direct);\n+\n \t/* Handle waiting on fences on the destination buffer. */\n \tif (dest.fence != -1) {\n \t\tint ret = waitFence(dest.fence);\n@@ -163,9 +165,6 @@ int CameraStream::process(const FrameBuffer &source,\n \t\tdest.fence = -1;\n \t}\n \n-\tif (!postProcessor_)\n-\t\treturn 0;\n-\n \t/*\n \t * \\todo Buffer mapping and processing should be moved to a\n \t * separate thread.\n", "prefixes": [ "libcamera-devel", "v7", "1/7" ] }