Patch Detail
Show a patch.
GET /api/1.1/patches/14284/?format=api
{ "id": 14284, "url": "https://patchwork.libcamera.org/api/1.1/patches/14284/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14284/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211022151218.111966-19-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-10-22T15:12:17", "name": "[libcamera-devel,v3,18/19] ipa: ipu3: Implement an empty stop() function", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "7996667df25a9beeee00d940bc67e75d38262b2e", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14284/mbox/", "series": [ { "id": 2651, "url": "https://patchwork.libcamera.org/api/1.1/series/2651/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2651", "date": "2021-10-22T15:11:59", "name": "Document IPU3 IPA", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2651/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14284/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14284/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A70A0BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 22 Oct 2021 15:12:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 601AB68F71;\n\tFri, 22 Oct 2021 17:12:44 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 218C668F6A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Oct 2021 17:12:26 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:22cc:3af6:5ccb:8367])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DA00989A;\n\tFri, 22 Oct 2021 17:12:25 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vIjcFy6t\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634915545;\n\tbh=sb/gkO9T+GeIq/CFczwhpcGPSzK7bkn1UEnszacwOfU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vIjcFy6t/vd3UVuOcmWpMUY2e0Ylfp+mYTobSYYStHV6FSliGQT/dmNu2ALmnTp0o\n\tip8+C0BwNe3dJp2L3LsG2uJutAzMQCEYZ500CROEMkiMzH1G5vvwA/B16IEVzwfDJI\n\t5EOBfPSYD4cnYchcHv3+ephxoFqrIpMPvdDVt96c=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 22 Oct 2021 17:12:17 +0200", "Message-Id": "<20211022151218.111966-19-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 18/19] ipa: ipu3: Implement an empty\n\tstop() function", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "While the stop() method does not currently perform any action, it forms\npart of the IPA interface and is a public function in the class.\n\nPromote it to a full (but basic) function implementation and begin the\ndocumentation accordingly so that there is an appropriate stub to\nperform stop operations if they come up.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 065febf8..ea54413a 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -131,7 +131,7 @@ public:\n \t\t ControlInfoMap *ipaControls) override;\n \n \tint start() override;\n-\tvoid stop() override {}\n+\tvoid stop() override;\n \n \tint configure(const IPAConfigInfo &configInfo,\n \t\t ControlInfoMap *ipaControls) override;\n@@ -319,6 +319,13 @@ int IPAIPU3::start()\n \treturn 0;\n }\n \n+/**\n+ * \\brief Ensure that all processing has completed.\n+ */\n+void IPAIPU3::stop()\n+{\n+}\n+\n /**\n * \\brief Calculate a grid for the AWB statistics\n *\n", "prefixes": [ "libcamera-devel", "v3", "18/19" ] }