Patch Detail
Show a patch.
GET /api/1.1/patches/14270/?format=api
{ "id": 14270, "url": "https://patchwork.libcamera.org/api/1.1/patches/14270/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14270/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211022151218.111966-5-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-10-22T15:12:03", "name": "[libcamera-devel,v3,04/19] ipa: ipu3: Explicitly use the statistics parameter", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "e8878f21f3d71f0398f6d20542728593317f44d9", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14270/mbox/", "series": [ { "id": 2651, "url": "https://patchwork.libcamera.org/api/1.1/series/2651/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2651", "date": "2021-10-22T15:11:59", "name": "Document IPU3 IPA", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2651/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14270/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14270/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 300C3BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 22 Oct 2021 15:12:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B174E68F71;\n\tFri, 22 Oct 2021 17:12:30 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8517168F5B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Oct 2021 17:12:23 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:22cc:3af6:5ccb:8367])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3E80489A;\n\tFri, 22 Oct 2021 17:12:23 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l8iOcSf6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634915543;\n\tbh=82GZF8LJZgDgxaKpAMQ6XuH4NMBLE53kfrCRJ+WxE+0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=l8iOcSf6XF0Vqge2skd8+pkVDu14QWNozBFWm3X8ZQmvzEzHo8+V4fvIPG3qixNIz\n\tV+KhvONvnX11vqsGzBmjlc8oWZj0sa/N0KVWIOPiCOtIZwYY0s+1tx99fkEzBXnIgI\n\turAx7DjpRisFcb1bxWuRnNeRNBmNDbyAQbLi/Cig=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 22 Oct 2021 17:12:03 +0200", "Message-Id": "<20211022151218.111966-5-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211022151218.111966-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 04/19] ipa: ipu3: Explicitly use the\n\tstatistics parameter", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The stats pointer is marked as [[maybe_unused]]. This is a leftover from\na previous commit which was here to keep the compatibility while\ntransitioning to the new iterative algorithms.\n\nRemove this attribute to make it explicit that stats are really used to\nfeed the algorithms.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex c5461d8e..cd27872b 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -715,7 +715,7 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)\n */\n void IPAIPU3::parseStatistics(unsigned int frame,\n \t\t\t [[maybe_unused]] int64_t frameTimestamp,\n-\t\t\t [[maybe_unused]] const ipu3_uapi_stats_3a *stats)\n+\t\t\t const ipu3_uapi_stats_3a *stats)\n {\n \tControlList ctrls(controls::controls);\n \n", "prefixes": [ "libcamera-devel", "v3", "04/19" ] }