Patch Detail
Show a patch.
GET /api/1.1/patches/14263/?format=api
{ "id": 14263, "url": "https://patchwork.libcamera.org/api/1.1/patches/14263/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14263/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211022143907.3089419-5-naush@raspberrypi.com>", "date": "2021-10-22T14:39:05", "name": "[libcamera-devel,v2,4/6] pipeline: raspberrypi: Remove \"unpacked\" format penalty in mode selection", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0d89507c5d1ff80c09f02e6445097340fdd91b15", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14263/mbox/", "series": [ { "id": 2650, "url": "https://patchwork.libcamera.org/api/1.1/series/2650/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2650", "date": "2021-10-22T14:39:01", "name": "Raspberry Pi: Conversion to media controller", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2650/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14263/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14263/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8DE7BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 22 Oct 2021 14:40:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6A6468F6B;\n\tFri, 22 Oct 2021 16:40:18 +0200 (CEST)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F5FC6012A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Oct 2021 16:40:16 +0200 (CEST)", "by mail-wm1-x335.google.com with SMTP id\n\ty22-20020a1c7d16000000b003231ea3d705so3623206wmc.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Oct 2021 07:40:16 -0700 (PDT)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:f00d:ddf0:61b0:a4cd])\n\tby smtp.gmail.com with ESMTPSA id\n\tr205sm8577878wma.3.2021.10.22.07.40.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 22 Oct 2021 07:40:15 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"CF7R+4n9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=LPz2Ck+cam+tyTq1UgTzhzey7O0P6Ctm4/xvxMVlKak=;\n\tb=CF7R+4n9LPN9R0s6yF8WHf9Aj+aFI1s+2/upYLGakqLx3aseZtb/FqHFEHU+L/hWd4\n\t43EdDotsMEzrMZGFQfMgSLJnlWGkxYy35LU2ena1AGmiYzq+q797Adue8g4JL3IY2TcE\n\tP9rLV+MZbH8jK17y1QyIhUiH3LbwhdrqLZ1681l78xlkfnYOY2YWn+S/QdIwPjHaJYeV\n\tXKyYnlDw2+ph44kOJ84j5jhxdJLb+Kx6SQo+7wVBTGVmj0+dUGpTvcp7SoTDs34hF5Sf\n\tZZuf30fvdO8b/Yk/dmMSMMpJG7epealDbbxkLHt/Z2W+/Y50zYmGnckugIf0nZFvoe4T\n\tt7sw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=LPz2Ck+cam+tyTq1UgTzhzey7O0P6Ctm4/xvxMVlKak=;\n\tb=sUp7J7q747+LwOLnF4hfDa7bE/IrysShaUluNKmdUyugs8pVCwlDEA0haSGiQLHEek\n\tjVxhTS/Q9Mf7pj+k4Pe1lr8X1jrZkVzvTcglKU4Bohz6hpUJQr00iwuOTNhZGyaxpjWd\n\tDrmXZirvUW+1pFgXH7xmYs9OzxWqHtW6++cEQghiJk2AUUy57sgpixYdK6hfZg5UwOWa\n\t3dfjROT9AbL0S5WlPFllbkqpVekCs5MTP1sX7KUoBvn/EUJ2kzwquVczPjgmR4TC9o3u\n\tLkV85m7GmsRG/tVOQMCXobyrgvoFseL326/COsqTkC0sKGyomADzFtrrxJ4+4Eil0lLx\n\tFLxg==", "X-Gm-Message-State": "AOAM533y0hD4/7awrJMjICYnh66lYDeTLlGpaUWQlEsSEp4+Aze0tNNA\n\tzOdrKW/EgN/9DwWQazJINFAxHIevkkQNWDQ/", "X-Google-Smtp-Source": "ABdhPJztNC+0vmIcLRFyyo/xK34xRnkkxf+vswD15Ju9KH72gfUZaNuZno0cV2fzeoWgKvUpbrCsbQ==", "X-Received": "by 2002:a7b:c088:: with SMTP id\n\tr8mr29495440wmh.120.1634913615823; \n\tFri, 22 Oct 2021 07:40:15 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 22 Oct 2021 15:39:05 +0100", "Message-Id": "<20211022143907.3089419-5-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211022143907.3089419-1-naush@raspberrypi.com>", "References": "<20211022143907.3089419-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 4/6] pipeline: raspberrypi: Remove\n\t\"unpacked\" format penalty in mode selection", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the recent change to switch to programming the sensor device directly,\nthe notion of packed vs unpacked modes are not relevent, since that is a\nUnicam format construct. Remove any scoring based on packed/unpacked modes.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 45725527d66e..2b70b877e70a 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -109,7 +109,6 @@ V4L2SubdeviceFormat findBestMode(const SensorFormats &formatsMap, const Size &re\n #define PENALTY_8BIT\t\t2000.0\n #define PENALTY_10BIT\t\t1000.0\n #define PENALTY_12BIT\t\t 0.0\n-#define PENALTY_UNPACKED\t 500.0\n \n \t/* Calculate the closest/best mode from the user requested size. */\n \tfor (const auto &iter : formatsMap) {\n@@ -127,9 +126,6 @@ V4L2SubdeviceFormat findBestMode(const SensorFormats &formatsMap, const Size &re\n \t\t\tscore += PENALTY_AR * scoreFormat(reqAr, modeAr);\n \n \t\t\t/* Add any penalties... this is not an exact science! */\n-\t\t\tif (!info.packed)\n-\t\t\t\tscore += PENALTY_UNPACKED;\n-\n \t\t\tif (info.bitsPerPixel == 12)\n \t\t\t\tscore += PENALTY_12BIT;\n \t\t\telse if (info.bitsPerPixel == 10)\n", "prefixes": [ "libcamera-devel", "v2", "4/6" ] }