Patch Detail
Show a patch.
GET /api/1.1/patches/14256/?format=api
{ "id": 14256, "url": "https://patchwork.libcamera.org/api/1.1/patches/14256/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14256/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211022115537.2964533-5-naush@raspberrypi.com>", "date": "2021-10-22T11:55:35", "name": "[libcamera-devel,4/6] pipeline: raspberrypi: Remove \"unpacked\" format penalty in mode selection", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0d89507c5d1ff80c09f02e6445097340fdd91b15", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14256/mbox/", "series": [ { "id": 2649, "url": "https://patchwork.libcamera.org/api/1.1/series/2649/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2649", "date": "2021-10-22T11:55:31", "name": "Raspberry Pi: Conversion to media controller", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2649/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14256/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14256/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 821C7BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 22 Oct 2021 11:55:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 186D168F57;\n\tFri, 22 Oct 2021 13:55:49 +0200 (CEST)", "from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66BAE6012A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Oct 2021 13:55:45 +0200 (CEST)", "by mail-wr1-x436.google.com with SMTP id d13so4337360wrf.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Oct 2021 04:55:45 -0700 (PDT)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:f00d:ddf0:61b0:a4cd])\n\tby smtp.gmail.com with ESMTPSA id\n\tl5sm7853364wru.24.2021.10.22.04.55.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 22 Oct 2021 04:55:44 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"OPHQN6od\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=PDQBlbl4qInGaGsRRpYvBAqua2Eo/HUT+WJSofI6L8c=;\n\tb=OPHQN6oddmyjbEQMIoUE/Lzf6TG0icVOlzxnMOYQoqH16z0pO6FSnxGcAdmWL4N5dY\n\twiES6vLY2jN21/CjrtNY0qSPEnktoRzv7m5xM9IxKrEdomUI0pBjxt6cLY87pzvlo99z\n\tHBCwIggkH3MzbrnXrerN4UvBBgd7Q8V2ZFLXkVOiRoEiwMduswXpK7CilW4VlGXCiPDV\n\t3d/uxiSZfUOeO56n+Kdp6FB0nyA64HapGp3gOYpvXoj9O+ipaRznfQdDW98VkeDwYL5v\n\t5Nn3KH/GiYfsh9dIcQ1Bzb0rv84PIxlvoZiIrfVzjRpPLvizSsLXabPmRYZdL9GUsh//\n\tDtzQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=PDQBlbl4qInGaGsRRpYvBAqua2Eo/HUT+WJSofI6L8c=;\n\tb=h/V9i8+HxUemPqe+TDQWfKubTDDYHcTBlWG9x3rozCZFamqnKZ88WzGofw6SCkOTbv\n\twfBxGo5QefuVR7xm4CkV+kq0MAPRtBCXL8U2l32y4XcvCSCQwW36negK0Pu92YDDTw+x\n\tSKa4z0t23zVKE6Hs3bpcoBwsXKeg8RYcsgOnkYutyPXrxTtA2JfPa+LQqUG2YW949HWj\n\thLBOFa8JBobTV22qqZQJ+dsQn4ucZPXIOm/eidbsqCSlSp6ugC0jdL9/0jCxHEc5Nf48\n\t/a7P4fp86u+9/AJYY5yy5LfT83D62Q4JDu9BmOKMeoYI7UVibm6F+Rwaq0teAy67hfqB\n\tBAsA==", "X-Gm-Message-State": "AOAM533BszkThF8mjlngWB4jtQCJ07zauoCJ9fEiQPmgO03skHo0Ni15\n\trFEFu8WoNKIl25bRcn24E2uur5Ut1ZdYtNIJ", "X-Google-Smtp-Source": "ABdhPJx0Zq3y8ryWrwZy+Tz3UHK33wGcMvEaV3dN7gZySF0KU1RJg4IBXsDFnuWXcRqm8KNM4Jj89A==", "X-Received": "by 2002:a5d:59aa:: with SMTP id\n\tp10mr15040842wrr.45.1634903744912; \n\tFri, 22 Oct 2021 04:55:44 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 22 Oct 2021 12:55:35 +0100", "Message-Id": "<20211022115537.2964533-5-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211022115537.2964533-1-naush@raspberrypi.com>", "References": "<20211022115537.2964533-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 4/6] pipeline: raspberrypi: Remove\n\t\"unpacked\" format penalty in mode selection", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the recent change to switch to programming the sensor device directly,\nthe notion of packed vs unpacked modes are not relevent, since that is a\nUnicam format construct. Remove any scoring based on packed/unpacked modes.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 0f13127a7748..fc190e39732a 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -125,7 +125,6 @@ SensorMode findBestMode(const SensorFormats &formatsMap, const Size &req)\n #define PENALTY_8BIT\t\t2000.0\n #define PENALTY_10BIT\t\t1000.0\n #define PENALTY_12BIT\t\t 0.0\n-#define PENALTY_UNPACKED\t 500.0\n \n \t/* Calculate the closest/best mode from the user requested size. */\n \tfor (const auto &iter : formatsMap) {\n@@ -143,9 +142,6 @@ SensorMode findBestMode(const SensorFormats &formatsMap, const Size &req)\n \t\t\tscore += PENALTY_AR * scoreFormat(reqAr, modeAr);\n \n \t\t\t/* Add any penalties... this is not an exact science! */\n-\t\t\tif (!info.packed)\n-\t\t\t\tscore += PENALTY_UNPACKED;\n-\n \t\t\tif (info.bitsPerPixel == 12)\n \t\t\t\tscore += PENALTY_12BIT;\n \t\t\telse if (info.bitsPerPixel == 10)\n", "prefixes": [ "libcamera-devel", "4/6" ] }