Patch Detail
Show a patch.
GET /api/1.1/patches/14241/?format=api
{ "id": 14241, "url": "https://patchwork.libcamera.org/api/1.1/patches/14241/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14241/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211022073249.35084-6-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-10-22T07:32:40", "name": "[libcamera-devel,v4,05/14] ipa: ipu3: agc: Rename exposure values properly", "commit_ref": "02686a052a0c46741592079bc403b25ee716c356", "pull_url": null, "state": "accepted", "archived": false, "hash": "c72fc06640b653091f141f06a68fae644a728957", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14241/mbox/", "series": [ { "id": 2647, "url": "https://patchwork.libcamera.org/api/1.1/series/2647/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2647", "date": "2021-10-22T07:32:35", "name": "ipa: ipu3: Fix AGC bugs", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2647/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14241/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14241/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95665BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 22 Oct 2021 07:33:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 171B968F68;\n\tFri, 22 Oct 2021 09:33:03 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23B1F60128\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Oct 2021 09:32:55 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:22cc:3af6:5ccb:8367])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CC0451908;\n\tFri, 22 Oct 2021 09:32:54 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Z6MIjKJx\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634887974;\n\tbh=l+Mz/wHRifSiN6OzVUIf7GYOxdpXJIVhxxPXpPt0Sko=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Z6MIjKJxpcIdCQfK0ObD8FlyApHuE68abQVuIEzYfQW1PRolBV2ghFp7gLKGBPPWV\n\tm6xDVkSxMevSpVWGdRJmBYd/3JQ7q50h7OWwMW7Rcmz30q5trtVM+7lrqiLZaMcs9J\n\tC2GQoa3kSDRBwL8/0Yb6HUJF3HJ7UEh74MhjMOPQ=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 22 Oct 2021 09:32:40 +0200", "Message-Id": "<20211022073249.35084-6-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211022073249.35084-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211022073249.35084-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 05/14] ipa: ipu3: agc: Rename exposure\n\tvalues properly", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The exposure value is filtered in filterExposure() using the\ncurrentExposure_ and setting a prevExposure_ variable. This is misnamed\nas it is not the previous exposure, but a filtered value.\n\nRename it accordingly.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/agc.cpp | 28 ++++++++++++++--------------\n src/ipa/ipu3/algorithms/agc.h | 4 ++--\n 2 files changed, 16 insertions(+), 16 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 828e822c..62ea0916 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -49,7 +49,7 @@ static constexpr double kEvGainTarget = 0.5;\n \n Agc::Agc()\n \t: frameCount_(0), lastFrame_(0), iqMean_(0.0), lineDuration_(0s),\n-\t maxExposureTime_(0s), prevExposure_(0s), prevExposureNoDg_(0s),\n+\t maxExposureTime_(0s), filteredExposure_(0s), filteredExposureNoDg_(0s),\n \t currentExposure_(0s), currentExposureNoDg_(0s)\n {\n }\n@@ -100,24 +100,24 @@ void Agc::processBrightness(const ipu3_uapi_stats_3a *stats,\n void Agc::filterExposure()\n {\n \tdouble speed = 0.2;\n-\tif (prevExposure_ == 0s) {\n+\tif (filteredExposure_ == 0s) {\n \t\t/* DG stands for digital gain.*/\n-\t\tprevExposure_ = currentExposure_;\n-\t\tprevExposureNoDg_ = currentExposureNoDg_;\n+\t\tfilteredExposure_ = currentExposure_;\n+\t\tfilteredExposureNoDg_ = currentExposureNoDg_;\n \t} else {\n \t\t/*\n \t\t * If we are close to the desired result, go faster to avoid making\n \t\t * multiple micro-adjustments.\n \t\t * \\ todo: Make this customisable?\n \t\t */\n-\t\tif (prevExposure_ < 1.2 * currentExposure_ &&\n-\t\t prevExposure_ > 0.8 * currentExposure_)\n+\t\tif (filteredExposure_ < 1.2 * currentExposure_ &&\n+\t\t filteredExposure_ > 0.8 * currentExposure_)\n \t\t\tspeed = sqrt(speed);\n \n-\t\tprevExposure_ = speed * currentExposure_ +\n-\t\t\t\tprevExposure_ * (1.0 - speed);\n-\t\tprevExposureNoDg_ = speed * currentExposureNoDg_ +\n-\t\t\t\tprevExposureNoDg_ * (1.0 - speed);\n+\t\tfilteredExposure_ = speed * currentExposure_ +\n+\t\t\t\tfilteredExposure_ * (1.0 - speed);\n+\t\tfilteredExposureNoDg_ = speed * currentExposureNoDg_ +\n+\t\t\t\tfilteredExposureNoDg_ * (1.0 - speed);\n \t}\n \t/*\n \t * We can't let the no_dg exposure deviate too far below the\n@@ -125,10 +125,10 @@ void Agc::filterExposure()\n \t * in the ISP to hide it (which will cause nasty oscillation).\n \t */\n \tdouble fastReduceThreshold = 0.4;\n-\tif (prevExposureNoDg_ <\n-\t prevExposure_ * fastReduceThreshold)\n-\t\tprevExposureNoDg_ = prevExposure_ * fastReduceThreshold;\n-\tLOG(IPU3Agc, Debug) << \"After filtering, total_exposure \" << prevExposure_;\n+\tif (filteredExposureNoDg_ <\n+\t filteredExposure_ * fastReduceThreshold)\n+\t\tfilteredExposureNoDg_ = filteredExposure_ * fastReduceThreshold;\n+\tLOG(IPU3Agc, Debug) << \"After filtering, total_exposure \" << filteredExposure_;\n }\n \n void Agc::lockExposureGain(uint32_t &exposure, double &gain)\ndiff --git a/src/ipa/ipu3/algorithms/agc.h b/src/ipa/ipu3/algorithms/agc.h\nindex e0c315fc..16b9fa0a 100644\n--- a/src/ipa/ipu3/algorithms/agc.h\n+++ b/src/ipa/ipu3/algorithms/agc.h\n@@ -44,8 +44,8 @@ private:\n \tutils::Duration lineDuration_;\n \tutils::Duration maxExposureTime_;\n \n-\tutils::Duration prevExposure_;\n-\tutils::Duration prevExposureNoDg_;\n+\tutils::Duration filteredExposure_;\n+\tutils::Duration filteredExposureNoDg_;\n \tutils::Duration currentExposure_;\n \tutils::Duration currentExposureNoDg_;\n \n", "prefixes": [ "libcamera-devel", "v4", "05/14" ] }