Patch Detail
Show a patch.
GET /api/1.1/patches/14230/?format=api
{ "id": 14230, "url": "https://patchwork.libcamera.org/api/1.1/patches/14230/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14230/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211021164401.110033-8-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-10-21T16:43:54", "name": "[libcamera-devel,v3,07/14] ipa: ipu3: agc: Change analogue gain limits", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0e2fca823f5287330429c4f5e9042e25ecdf3c57", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14230/mbox/", "series": [ { "id": 2646, "url": "https://patchwork.libcamera.org/api/1.1/series/2646/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2646", "date": "2021-10-21T16:43:47", "name": "ipa: ipu3: Fix AGC bugs", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2646/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14230/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14230/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 204FEC324F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Oct 2021 16:44:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C706168F6A;\n\tThu, 21 Oct 2021 18:44:17 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E645C68F63\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Oct 2021 18:44:06 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:f9d:5926:ad90:4996])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 86AD61B43;\n\tThu, 21 Oct 2021 18:44:06 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kkVqLmsi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634834646;\n\tbh=XTkopjKBNdiyvaIsQDg5GdSEqax9j7HZwEP8P0M4210=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kkVqLmsifURK8igc4KpJ7Va3y8imVttkWL8dtGjM9ky82xqXli6q8ZQdls3N/lhyv\n\tj2C3RGyHtw0VtD15CgSjT3iRoqi0oOalpOuGYeql6ZaNqosdV/ADlQCETUCr8NTNxa\n\tBB9awRVed2xECnPt498Ki2H2Dxlhlb6vAeJTarbo=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 21 Oct 2021 18:43:54 +0200", "Message-Id": "<20211021164401.110033-8-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211021164401.110033-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211021164401.110033-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 07/14] ipa: ipu3: agc: Change analogue\n\tgain limits", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The gains is currently set as a uint32_t while the analogue gain is\npassed as a double. We also have a default maximum analogue gain of 15\nwhich is quite high for a number of sensors.\n\nUse a maximum value of 8 which should really be configured by the IPA\nand not fixed as it is now. While at it make it a double.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/agc.cpp | 14 ++++++--------\n 1 file changed, 6 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex 58872410..984aed53 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -30,14 +30,10 @@ static constexpr uint32_t kInitialFrameMinAECount = 4;\n /* Number of frames to wait between new gain/exposure estimations */\n static constexpr uint32_t kFrameSkipCount = 6;\n \n-/* Maximum ISO value for analogue gain */\n-static constexpr uint32_t kMinISO = 100;\n-static constexpr uint32_t kMaxISO = 1500;\n-\n /* Maximum analogue gain value\n * \\todo grab it from a camera helper */\n-static constexpr uint32_t kMinGain = kMinISO / 100;\n-static constexpr uint32_t kMaxGain = kMaxISO / 100;\n+static constexpr double kMinGain = 1.0;\n+static constexpr double kMaxGain = 8.0;\n \n /* Histogram constants */\n static constexpr uint32_t knumHistogramBins = 256;\n@@ -166,9 +162,11 @@ void Agc::lockExposureGain(uint32_t &exposure, double &gain)\n \t\t\t\t\t\t\tminExposureLines_,\n \t\t\t\t\t\t\tmaxExposureLines_);\n \t\t\tnewExposure = currentExposure_ / exposure;\n-\t\t\tgain = std::clamp(static_cast<uint32_t>(gain * currentExposure_ / newExposure), kMinGain, kMaxGain);\n+\t\t\tgain = std::clamp(gain * currentExposure_ / newExposure,\n+\t\t\t\t\t kMinGain, kMaxGain);\n \t\t} else {\n-\t\t\tgain = std::clamp(static_cast<uint32_t>(gain * currentExposure_ / currentExposureNoDg_), kMinGain, kMaxGain);\n+\t\t\tgain = std::clamp(gain * currentExposure_ / currentExposureNoDg_,\n+\t\t\t\t\t kMinGain, kMaxGain);\n \t\t\tnewExposure = currentExposure_ / gain;\n \t\t\texposure = std::clamp<uint32_t>(exposure * currentExposure_ / newExposure,\n \t\t\t\t\t\t\tminExposureLines_,\n", "prefixes": [ "libcamera-devel", "v3", "07/14" ] }