Patch Detail
Show a patch.
GET /api/1.1/patches/14225/?format=api
{ "id": 14225, "url": "https://patchwork.libcamera.org/api/1.1/patches/14225/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14225/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211021164401.110033-5-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-10-21T16:43:51", "name": "[libcamera-devel,v3,04/14] ipa: ipu3: awb: Change minimal green threshold value", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ca25213f0e62be1cee92e26fcb343a2b98582774", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14225/mbox/", "series": [ { "id": 2646, "url": "https://patchwork.libcamera.org/api/1.1/series/2646/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2646", "date": "2021-10-21T16:43:47", "name": "ipa: ipu3: Fix AGC bugs", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2646/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14225/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14225/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A384EBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Oct 2021 16:44:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E55468F75;\n\tThu, 21 Oct 2021 18:44:12 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 31FCC604FE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Oct 2021 18:44:06 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:f9d:5926:ad90:4996])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D6D681B43;\n\tThu, 21 Oct 2021 18:44:05 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"D80qY1yC\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634834645;\n\tbh=E216AD2M1rlwmKEgOdZoe323Nvn2NliIkjgje2A59EU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=D80qY1yC/9LmieTGjUXoOYCJtPVR2y94uX60ngUSURqH+wUlKE5udsQgjpyRCE9uC\n\tegPUuecJatk4YeczzoBDS547k6ngJiKurCXOY/ewdRwPY5wVbmk8232r+lqfgJmgQ0\n\t+Bug6x2hciH8ha/bpjL1AZ7jvWRofOzE7UtXf2js=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 21 Oct 2021 18:43:51 +0200", "Message-Id": "<20211021164401.110033-5-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211021164401.110033-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211021164401.110033-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 04/14] ipa: ipu3: awb: Change minimal\n\tgreen threshold value", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When zones are used for the grey world algorithm, they are only\nconsidered if their average green value is at least 32/255 to exclude\nzones that are too dark and don't provide relevant colour information\n(on the opposite side of the spectrum, saturated regions are excluded by\nthe ImgU statistics engine).\n\nThe algorithm requires a minimal number of zones that meet this criteria\nin order to run. Now that we correct the black level, the 32/255 minimal\nvalue is a bit high and prevents the algorithm for running in low-light\nconditions. Lower the value to 16/255 to fix it.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/awb.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex ce01791b..ae78cb87 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -17,7 +17,14 @@ namespace ipa::ipu3::algorithms {\n \n LOG_DEFINE_CATEGORY(IPU3Awb)\n \n-static constexpr uint32_t kMinGreenLevelInZone = 32;\n+/*\n+ * When zones are used for the grey world algorithm, they are only considered if\n+ * their average green value is at least 16/255 (after black level subtraction)\n+ * to exclude zones that are too dark and don't provide relevant colour\n+ * information (on the opposite side of the spectrum, saturated regions are\n+ * excluded by the ImgU statistics engine).\n+ */\n+static constexpr uint32_t kMinGreenLevelInZone = 16;\n \n /*\n * Minimum proportion of non-saturated cells in a zone for the zone to be used\n", "prefixes": [ "libcamera-devel", "v3", "04/14" ] }