Patch Detail
Show a patch.
GET /api/1.1/patches/14222/?format=api
{ "id": 14222, "url": "https://patchwork.libcamera.org/api/1.1/patches/14222/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14222/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211021164401.110033-2-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-10-21T16:43:48", "name": "[libcamera-devel,v3,01/14] ipa: ipu3: awb: Set a threshold for the green saturation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "dc6a5c4665ce8c164b97edfd9917850445c8bc1c", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14222/mbox/", "series": [ { "id": 2646, "url": "https://patchwork.libcamera.org/api/1.1/series/2646/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2646", "date": "2021-10-21T16:43:47", "name": "ipa: ipu3: Fix AGC bugs", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2646/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14222/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14222/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E967CBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Oct 2021 16:44:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32C5168F6D;\n\tThu, 21 Oct 2021 18:44:08 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5C0968F56\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Oct 2021 18:44:05 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:f9d:5926:ad90:4996])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 432081B43;\n\tThu, 21 Oct 2021 18:44:05 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DeAgWwtg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634834645;\n\tbh=DTB9tOM4k7ndNUbPWAAzFJdPZ+bZP+oAf6jSfKyEqEE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DeAgWwtgwYBwb7i7eU6pvC7LqRLQwnhW1+QfE1Uub2Y40YKEzN3HcGNxpHmgchN2m\n\tHz3pNN92NBqgd0gl2iAUJlNVNA3mzdlvVI4WNV0M8Vv2jU2bBHLF6Vs8/U3k8HC0nX\n\tLmwFAf+dVeiHBiJNOaAZ8CcY0dZyw8AI5v8xVcFE=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 21 Oct 2021 18:43:48 +0200", "Message-Id": "<20211021164401.110033-2-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211021164401.110033-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211021164401.110033-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 01/14] ipa: ipu3: awb: Set a threshold\n\tfor the green saturation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We can have a saturation ratio per cell, giving the percentage of pixels\nover a threshold within a cell where 100% is set to 0xff.\n\nThe parameter structure 'ipu3_uapi_awb_config_s' contains four fields to\nset the threshold, one per channel.\nThe blue field is also used to configure the ImgU and make it calculate\nthe saturation ratio or not.\n\nSet a green value saturated when it is more than 230 (90% of the maximum\nvalue 255, coded as 8191). As this is the only channel used for AGC,\nthere is no need to apply it to the other ones.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/awb.cpp | 27 +++++++++++++++++++++------\n src/ipa/ipu3/algorithms/awb.h | 1 +\n 2 files changed, 22 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 809de66a..4364928c 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -328,14 +328,29 @@ void Awb::process(IPAContext &context, const ipu3_uapi_stats_3a *stats)\n \tcontext.frameContext.awb.gains.red = asyncResults_.redGain;\n }\n \n+constexpr uint16_t Awb::threshold(float value)\n+{\n+\t/* AWB thresholds are in the range [0, 8191] */\n+\treturn value * 8191;\n+}\n+\n void Awb::prepare(IPAContext &context, ipu3_uapi_params *params)\n {\n-\tparams->acc_param.awb.config.rgbs_thr_gr = 8191;\n-\tparams->acc_param.awb.config.rgbs_thr_r = 8191;\n-\tparams->acc_param.awb.config.rgbs_thr_gb = 8191;\n-\tparams->acc_param.awb.config.rgbs_thr_b = IPU3_UAPI_AWB_RGBS_THR_B_INCL_SAT\n-\t\t\t\t\t | IPU3_UAPI_AWB_RGBS_THR_B_EN\n-\t\t\t\t\t | 8191;\n+\t/*\n+\t * Green saturation thresholds are reduced because we are using the\n+\t * green channel only in the exposure computation.\n+\t */\n+\tparams->acc_param.awb.config.rgbs_thr_r = threshold(1.0);\n+\tparams->acc_param.awb.config.rgbs_thr_gr = threshold(0.9);\n+\tparams->acc_param.awb.config.rgbs_thr_gb = threshold(0.9);\n+\tparams->acc_param.awb.config.rgbs_thr_b = threshold(1.0);\n+\n+\t/*\n+\t * Enable saturation inclusion on thr_b for ImgU to update the\n+\t * ipu3_uapi_awb_set_item->sat_ratio field.\n+\t */\n+\tparams->acc_param.awb.config.rgbs_thr_b |= IPU3_UAPI_AWB_RGBS_THR_B_INCL_SAT |\n+\t\t\t\t\t\t IPU3_UAPI_AWB_RGBS_THR_B_EN;\n \n \tconst ipu3_uapi_grid_config &grid = context.configuration.grid.bdsGrid;\n \ndiff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\nindex 3b81f600..0c81e39e 100644\n--- a/src/ipa/ipu3/algorithms/awb.h\n+++ b/src/ipa/ipu3/algorithms/awb.h\n@@ -70,6 +70,7 @@ private:\n \tvoid clearAwbStats();\n \tvoid awbGreyWorld();\n \tuint32_t estimateCCT(double red, double green, double blue);\n+\tstatic constexpr uint16_t threshold(float value);\n \n \tstd::vector<RGB> zones_;\n \tAccumulator awbStats_[kAwbStatsSizeX * kAwbStatsSizeY];\n", "prefixes": [ "libcamera-devel", "v3", "01/14" ] }