Patch Detail
Show a patch.
GET /api/1.1/patches/14210/?format=api
{ "id": 14210, "url": "https://patchwork.libcamera.org/api/1.1/patches/14210/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14210/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211020154607.180161-4-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-10-20T15:45:57", "name": "[libcamera-devel,v2,03/13] ipa: ipu3: awb: Use saturation under 90%", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e6c45ad0096740a90a89d9e969a7ccbdee24f7d5", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14210/mbox/", "series": [ { "id": 2645, "url": "https://patchwork.libcamera.org/api/1.1/series/2645/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2645", "date": "2021-10-20T15:45:54", "name": "ipa: ipu3: Fix AGC bugs", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2645/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14210/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14210/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2858BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 20 Oct 2021 15:46:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D93A68F66;\n\tWed, 20 Oct 2021 17:46:19 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C3C5C68F5A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 20 Oct 2021 17:46:13 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:ce4b:1c5f:7302:b899])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 82F852A5;\n\tWed, 20 Oct 2021 17:46:13 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CpzobZ24\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634744773;\n\tbh=VyawnqAtBI7O7x84f+93SWS7bCNTq5+BA5dB1OpS82A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=CpzobZ24ZKi73uBiZ1Y51VsawU9fBA2HNHv0mTvK67gfuC6KQ3iJ10uqqRwydZEZl\n\t3znnag+lNT6991ZW97PAD7A9+OMs0qVjeTd3keO26U2UsekEOsRssE9amwBYg6zLLz\n\tBPuKInjJSHdghFPdScsG95bDiJ4wmR0rGLXAfeys=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 20 Oct 2021 17:45:57 +0200", "Message-Id": "<20211020154607.180161-4-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211020154607.180161-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211020154607.180161-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 03/13] ipa: ipu3: awb: Use saturation\n\tunder 90%", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The AWB grey world algorithm tries to find a grey value and it can't do\nit on over-exposed images. To exclude those, the saturation ratio is\nused for each cell, and the cell is included only if this ratio is 0.\n\nNow that we have changed the threshold, more cells may be considered as\npartially saturated and excluded, preventing the algorithm from running\nefficiently.\n\nChange that behaviour, and consider 90% as a good enough ratio.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/awb.cpp | 22 ++++++++++++++++++++--\n 1 file changed, 20 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex e44bbd6c..62c72cce 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -19,6 +19,12 @@ LOG_DEFINE_CATEGORY(IPU3Awb)\n \n static constexpr uint32_t kMinGreenLevelInZone = 32;\n \n+/* Minimum proportion of cells counted within a zone for it to be relevant */\n+static constexpr double kMinRelevantCellsRatio = 0.8;\n+\n+/* Number of cells below the saturation ratio */\n+static constexpr uint32_t kSaturationThreshold = 255 * 90 / 100;\n+\n /**\n * \\struct Accumulator\n * \\brief RGB statistics for a given zone\n@@ -160,7 +166,8 @@ int Awb::configure(IPAContext &context,\n \t * for it to be relevant for the grey world algorithm.\n \t * \\todo This proportion could be configured.\n \t */\n-\tcellsPerZoneThreshold_ = cellsPerZoneX_ * cellsPerZoneY_ * 80 / 100;\n+\tcellsPerZoneThreshold_ = cellsPerZoneX_ * cellsPerZoneY_ * kMinRelevantCellsRatio;\n+\tLOG(IPU3Awb, Debug) << \"Threshold for AWB is set to \" << cellsPerZoneThreshold_;\n \n \treturn 0;\n }\n@@ -234,7 +241,18 @@ void Awb::generateAwbStats(const ipu3_uapi_stats_3a *stats)\n \t\t\t\treinterpret_cast<const ipu3_uapi_awb_set_item *>(\n \t\t\t\t\t&stats->awb_raw_buffer.meta_data[cellPosition]\n \t\t\t\t);\n-\t\t\tif (currentCell->sat_ratio == 0) {\n+\n+\t\t\t/*\n+\t\t\t * Use cells which have less than 90%\n+\t\t\t * saturation as an initial means to include\n+\t\t\t * otherwise bright cells which are not fully\n+\t\t\t * saturated.\n+\t\t\t *\n+\t\t\t * \\todo The 90% saturation rate may require\n+\t\t\t * further empirical measurements and\n+\t\t\t * optimisation during camera tuning phases.\n+\t\t\t */\n+\t\t\tif (currentCell->sat_ratio <= kSaturationThreshold) {\n \t\t\t\t/* The cell is not saturated, use the current cell */\n \t\t\t\tawbStats_[awbZonePosition].counted++;\n \t\t\t\tuint32_t greenValue = currentCell->Gr_avg + currentCell->Gb_avg;\n", "prefixes": [ "libcamera-devel", "v2", "03/13" ] }