Patch Detail
Show a patch.
GET /api/1.1/patches/14143/?format=api
{ "id": 14143, "url": "https://patchwork.libcamera.org/api/1.1/patches/14143/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14143/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211014174208.50509-8-jacopo@jmondi.org>", "date": "2021-10-14T17:41:59", "name": "[libcamera-devel,v4,07/16] android: capabilities: Initialize camera state when building properties", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "02e68a89657e766b86d92fea6b8acf69c933516c", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14143/mbox/", "series": [ { "id": 2628, "url": "https://patchwork.libcamera.org/api/1.1/series/2628/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2628", "date": "2021-10-14T17:41:52", "name": "IPU3 control info update and HAL frame durations", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2628/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14143/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14143/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E079C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 14 Oct 2021 17:41:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50BB268F64;\n\tThu, 14 Oct 2021 19:41:33 +0200 (CEST)", "from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC43368F4D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 14 Oct 2021 19:41:31 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id A7971FF80A;\n\tThu, 14 Oct 2021 17:41:30 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 14 Oct 2021 19:41:59 +0200", "Message-Id": "<20211014174208.50509-8-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20211014174208.50509-1-jacopo@jmondi.org>", "References": "<20211014174208.50509-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 07/16] android: capabilities:\n\tInitialize camera state when building properties", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that building the list of supported stream configuration requires\napplying a configuration to the Camera, re-initialize the camera\ncontrols by applying a configuration generated for the Viewfinder stream\nrole before building the list of static metadata.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/camera_capabilities.cpp | 28 +++++++++++++++++++++++++---\n 1 file changed, 25 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 1583a0a09cee..a98e6099bb77 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -394,11 +394,14 @@ int CameraCapabilities::initialize(std::shared_ptr<Camera> camera,\n \t}\n \n \tret = initializeStreamConfigurations();\n-\tcamera_->release();\n-\tif (ret)\n+\tif (ret) {\n+\t\tcamera_->release();\n \t\treturn ret;\n+\t}\n \n-\treturn initializeStaticMetadata();\n+\tret = initializeStaticMetadata();\n+\tcamera_->release();\n+\treturn ret;\n }\n \n std::vector<Size>\n@@ -696,6 +699,25 @@ int CameraCapabilities::initializeStaticMetadata()\n \t\treturn -EINVAL;\n \t}\n \n+\t/*\n+\t * Generate and apply a new configuration for the Viewfinder role to\n+\t * collect control limits and properties from a known state.\n+\t */\n+\tstd::unique_ptr<CameraConfiguration> cameraConfig =\n+\t\tcamera_->generateConfiguration({ StreamRole::Viewfinder });\n+\tif (!cameraConfig) {\n+\t\tLOG(HAL, Error) << \"Failed to generate camera configuration\";\n+\t\tstaticMetadata_.reset();\n+\t\treturn -ENODEV;\n+\t}\n+\n+\tint ret = camera_->configure(cameraConfig.get());\n+\tif (ret) {\n+\t\tLOG(HAL, Error) << \"Failed to initialize the camera state\";\n+\t\tstaticMetadata_.reset();\n+\t\treturn ret;\n+\t}\n+\n \tconst ControlInfoMap &controlsInfo = camera_->controls();\n \tconst ControlList &properties = camera_->properties();\n \n", "prefixes": [ "libcamera-devel", "v4", "07/16" ] }