Patch Detail
Show a patch.
GET /api/1.1/patches/14120/?format=api
{ "id": 14120, "url": "https://patchwork.libcamera.org/api/1.1/patches/14120/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14120/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211013154125.133419-5-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-10-13T15:41:16", "name": "[libcamera-devel,04/13] ipa: ipu3: awb: Change minimal green threshold value", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f8dccfd5c0829b4f324f03722a6aea0d0c944e4b", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14120/mbox/", "series": [ { "id": 2623, "url": "https://patchwork.libcamera.org/api/1.1/series/2623/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2623", "date": "2021-10-13T15:41:13", "name": "ipa: ipu3: Fix AGC bugs", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2623/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14120/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14120/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CEB28BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 13 Oct 2021 15:41:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5CDE68F69;\n\tWed, 13 Oct 2021 17:41:36 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0136168F50\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Oct 2021 17:41:32 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:3857:aa01:4281:bd9f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2756F1B4D;\n\tWed, 13 Oct 2021 17:41:31 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hUI/xH4o\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1634139691;\n\tbh=Xo5pyqmaQHBMNzCCpoSxQ6BAemMpHgSuBhOPMijpnhU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hUI/xH4o66Fi4ER2WTNUjFB2iPf3Kl+F3YMi7zLwZSImFlCisnaPLU/VTpX201aXS\n\tpUwmlfWFJTZIk/M6R45G6U38CqKlDLZmuxw+ziW1nObtysrBrx6D9S6HHL2jaLpqxB\n\tVq2uUXq5/TLlZaOMW8zIOl4ooxKkl44aMjnr+yXQ=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 13 Oct 2021 17:41:16 +0200", "Message-Id": "<20211013154125.133419-5-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20211013154125.133419-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211013154125.133419-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 04/13] ipa: ipu3: awb: Change minimal\n\tgreen threshold value", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When the zones are used for the grey world algorithm, we need a minimal\nnumber of zones to make it relevant, and we want the green values to be\nat least 32 today (with a maximum of 255).\n\nThis value is a bit high, as we now are correcting the black levels, and\na sudden change of colors can be visible for the end user when the gains\nare applied.\n\nLower the value to 16.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/awb.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 30693923..b18874a3 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -17,7 +17,7 @@ namespace ipa::ipu3::algorithms {\n \n LOG_DEFINE_CATEGORY(IPU3Awb)\n \n-static constexpr uint32_t kMinGreenLevelInZone = 32;\n+static constexpr uint32_t kMinGreenLevelInZone = 16;\n \n /**\n * \\struct Accumulator\n", "prefixes": [ "libcamera-devel", "04/13" ] }