Patch Detail
Show a patch.
GET /api/1.1/patches/14096/?format=api
{ "id": 14096, "url": "https://patchwork.libcamera.org/api/1.1/patches/14096/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14096/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211011151154.72856-13-jacopo@jmondi.org>", "date": "2021-10-11T15:11:50", "name": "[libcamera-devel,v3,12/16] android: Filter preview streams on FPS", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3a40a44decb1477e68edcc55890e74e84bf07151", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14096/mbox/", "series": [ { "id": 2613, "url": "https://patchwork.libcamera.org/api/1.1/series/2613/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2613", "date": "2021-10-11T15:11:38", "name": "IPU3 control info update and HAL frame durations", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2613/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14096/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14096/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE703C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 11 Oct 2021 15:11:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B6C068F63;\n\tMon, 11 Oct 2021 17:11:26 +0200 (CEST)", "from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A34568F54\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 11 Oct 2021 17:11:23 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 3E35EE0003;\n\tMon, 11 Oct 2021 15:11:22 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 11 Oct 2021 17:11:50 +0200", "Message-Id": "<20211011151154.72856-13-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20211011151154.72856-1-jacopo@jmondi.org>", "References": "<20211011151154.72856-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 12/16] android: Filter preview streams\n\ton FPS", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Register as preview streams only streams capable of producing at least\n30 FPS.\n\nThis requirement comes from inspecting the existing HAL implementation\non Intel IPU3 platform.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/android/camera_capabilities.cpp | 22 ++++++++++++++++++++++\n 1 file changed, 22 insertions(+)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex ddba1bbbea85..a281be646696 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1268,6 +1268,23 @@ int CameraCapabilities::initializeStaticMetadata()\n \tstd::vector<uint32_t> availableStreamConfigurations;\n \tavailableStreamConfigurations.reserve(streamConfigurations_.size() * 4);\n \tfor (const auto &entry : streamConfigurations_) {\n+\t\t/*\n+\t\t * Filter out YUV streams not capable of running at 30 FPS.\n+\t\t *\n+\t\t * This requirement comes from CTS RecordingTest failures most\n+\t\t * probably related to a requirement of the camcoder video\n+\t\t * recording profile. Inspecting the Intel IPU3 HAL\n+\t\t * implementation confirms this but no reference has been found\n+\t\t * in the metadata documentation.\n+\t\t *\n+\t\t * Calculate FPS as CTS does: see\n+\t\t * Camera2SurfaceViewTestCase.java:getSuitableFpsRangeForDuration()\n+\t\t */\n+\t\tunsigned int fps = static_cast<unsigned int>\n+\t\t\t\t (floor(1e9 / entry.minFrameDurationNsec + 0.05f));\n+\t\tif (entry.androidFormat != HAL_PIXEL_FORMAT_BLOB && fps < 30)\n+\t\t\tcontinue;\n+\n \t\tavailableStreamConfigurations.push_back(entry.androidFormat);\n \t\tavailableStreamConfigurations.push_back(entry.resolution.width);\n \t\tavailableStreamConfigurations.push_back(entry.resolution.height);\n@@ -1280,6 +1297,11 @@ int CameraCapabilities::initializeStaticMetadata()\n \tstd::vector<int64_t> minFrameDurations;\n \tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n \tfor (const auto &entry : streamConfigurations_) {\n+\t\tunsigned int fps = static_cast<unsigned int>\n+\t\t\t\t (floor(1e9 / entry.minFrameDurationNsec + 0.05f));\n+\t\tif (entry.androidFormat != HAL_PIXEL_FORMAT_BLOB && fps < 30)\n+\t\t\tcontinue;\n+\n \t\tminFrameDurations.push_back(entry.androidFormat);\n \t\tminFrameDurations.push_back(entry.resolution.width);\n \t\tminFrameDurations.push_back(entry.resolution.height);\n", "prefixes": [ "libcamera-devel", "v3", "12/16" ] }