Patch Detail
Show a patch.
GET /api/1.1/patches/14095/?format=api
{ "id": 14095, "url": "https://patchwork.libcamera.org/api/1.1/patches/14095/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14095/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211011151154.72856-12-jacopo@jmondi.org>", "date": "2021-10-11T15:11:49", "name": "[libcamera-devel,v3,11/16] android: capabilities: Collect absolute max frame durations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0a70295f4e4a2977503e36d24750921da154e151", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14095/mbox/", "series": [ { "id": 2613, "url": "https://patchwork.libcamera.org/api/1.1/series/2613/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2613", "date": "2021-10-11T15:11:38", "name": "IPU3 control info update and HAL frame durations", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2613/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14095/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14095/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1978BC323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 11 Oct 2021 15:11:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE0E66027F;\n\tMon, 11 Oct 2021 17:11:25 +0200 (CEST)", "from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A2D56027F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 11 Oct 2021 17:11:22 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 0CAD0E000D;\n\tMon, 11 Oct 2021 15:11:20 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 11 Oct 2021 17:11:49 +0200", "Message-Id": "<20211011151154.72856-12-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20211011151154.72856-1-jacopo@jmondi.org>", "References": "<20211011151154.72856-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 11/16] android: capabilities: Collect\n\tabsolute max frame durations", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "While building the list of supported stream configurations also collect\nthe absolute max frame durations to be used to populate the sensor\nmaximum frame duration.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/camera_capabilities.cpp | 9 ++++++---\n src/android/camera_capabilities.h | 1 +\n 2 files changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex d29342e382e7..ddba1bbbea85 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -385,6 +385,7 @@ int CameraCapabilities::initialize(std::shared_ptr<Camera> camera,\n \torientation_ = orientation;\n \tfacing_ = facing;\n \trawStreamAvailable_ = false;\n+\tmaxFrameDuration_ = 0;\n \n \t/* Acquire the camera and initialize available stream configurations. */\n \tint ret = camera_->acquire();\n@@ -662,6 +663,9 @@ int CameraCapabilities::initializeStreamConfigurations()\n \t\t\t\t});\n \t\t\t\tmaxJpegSize = std::max(maxJpegSize, res);\n \t\t\t}\n+\n+\t\t\tmaxFrameDuration_ = std::max(maxFrameDuration_,\n+\t\t\t\t\t\t maxFrameDuration);\n \t\t}\n \n \t\t/*\n@@ -1143,9 +1147,8 @@ int CameraCapabilities::initializeStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_TIMESTAMP_SOURCE,\n \t\t\t\t timestampSource);\n \n-\tif (maxFrameDurationNsec > 0)\n-\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_MAX_FRAME_DURATION,\n-\t\t\t\t\t maxFrameDurationNsec);\n+\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_MAX_FRAME_DURATION,\n+\t\t\t\t maxFrameDuration_);\n \n \t/* Statistics static metadata. */\n \tuint8_t faceDetectMode = ANDROID_STATISTICS_FACE_DETECT_MODE_OFF;\ndiff --git a/src/android/camera_capabilities.h b/src/android/camera_capabilities.h\nindex 6e55ddab445e..2cf97ae80095 100644\n--- a/src/android/camera_capabilities.h\n+++ b/src/android/camera_capabilities.h\n@@ -71,6 +71,7 @@ private:\n \tint facing_;\n \tint orientation_;\n \tbool rawStreamAvailable_;\n+\tint64_t maxFrameDuration_;\n \tcamera_metadata_enum_android_info_supported_hardware_level hwLevel_;\n \tstd::set<camera_metadata_enum_android_request_available_capabilities> capabilities_;\n \n", "prefixes": [ "libcamera-devel", "v3", "11/16" ] }