Patch Detail
Show a patch.
GET /api/1.1/patches/14014/?format=api
{ "id": 14014, "url": "https://patchwork.libcamera.org/api/1.1/patches/14014/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14014/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210930095513.76213-18-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-09-30T09:55:12", "name": "[libcamera-devel,17/18] ipa: ipu3: Fix badly documented context variables", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "ed86ecc5ee8805eb64ba42165adc42af986ffb26", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14014/mbox/", "series": [ { "id": 2588, "url": "https://patchwork.libcamera.org/api/1.1/series/2588/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2588", "date": "2021-09-30T09:54:55", "name": "Document IPU3 IPA", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2588/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14014/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14014/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8F00CC3243\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Sep 2021 09:55:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4B00D691CE;\n\tThu, 30 Sep 2021 11:55:39 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 442D3691C0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Sep 2021 11:55:21 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:bab4:22c5:662d:e478])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8CDB41AFA;\n\tThu, 30 Sep 2021 11:55:20 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dxoOpLXp\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632995720;\n\tbh=CG01d/s9BCS/Njg9FnQjNARQBt5oCZ0zZEiOIWJjcGc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=dxoOpLXpcU+hTzgnPwtsG5GPvsl/jTAILVWipWyZf58HGo57lxNMU0Z1zfmjCciqX\n\thGjUHt/IJPKQ/SkLd/2qQadQFpA3ks9oPQ4E80IeHnFS+ze9tK6f6iEk2KtPX8I1XT\n\thYqw7tVZhWEMJpNRFWyN1ameLtkLAeYGJ3dAqj8c=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 30 Sep 2021 11:55:12 +0200", "Message-Id": "<20210930095513.76213-18-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210930095513.76213-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210930095513.76213-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 17/18] ipa: ipu3: Fix badly documented\n\tcontext variables", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Doxygen warns us because the structures are referenced as \\struct while\nthey should be \\var. Fix it.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/ipa_context.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\nindex a38e6053..5a4c48f1 100644\n--- a/src/ipa/ipu3/ipa_context.cpp\n+++ b/src/ipa/ipu3/ipa_context.cpp\n@@ -56,7 +56,7 @@ namespace libcamera::ipa::ipu3 {\n */\n \n /**\n- * \\struct IPASessionConfiguration::grid\n+ * \\var IPASessionConfiguration::grid\n * \\brief Grid configuration of the IPA\n *\n * \\var IPASessionConfiguration::bdsGrid\n@@ -67,7 +67,7 @@ namespace libcamera::ipa::ipu3 {\n */\n \n /**\n- * \\struct IPAFrameContext::agc\n+ * \\var IPAFrameContext::agc\n * \\brief Context for the Automatic Gain Control algorithm\n *\n * The exposure and gain determined are expected to be applied to the sensor\n@@ -83,7 +83,7 @@ namespace libcamera::ipa::ipu3 {\n */\n \n /**\n- * \\struct IPAFrameContext::awb\n+ * \\var IPAFrameContext::awb\n * \\brief Context for the Automatic White Balance algorithm\n *\n * \\struct IPAFrameContext::awb::gains\n@@ -100,7 +100,7 @@ namespace libcamera::ipa::ipu3 {\n */\n \n /**\n- * \\struct IPAFrameContext::toneMapping\n+ * \\var IPAFrameContext::toneMapping\n * \\brief Context for ToneMapping and Gamma control\n *\n * \\var IPAFrameContext::gamma\n", "prefixes": [ "libcamera-devel", "17/18" ] }