Patch Detail
Show a patch.
GET /api/1.1/patches/14011/?format=api
{ "id": 14011, "url": "https://patchwork.libcamera.org/api/1.1/patches/14011/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14011/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210930095513.76213-15-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-09-30T09:55:09", "name": "[libcamera-devel,14/18] ipa: ipu3: ipa_context: Fix doxygen references", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "fb55464b0118211e153aaf76cd566eababd118b9", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14011/mbox/", "series": [ { "id": 2588, "url": "https://patchwork.libcamera.org/api/1.1/series/2588/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2588", "date": "2021-09-30T09:54:55", "name": "Document IPU3 IPA", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2588/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14011/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14011/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C143BC3243\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Sep 2021 09:55:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 821E4691C8;\n\tThu, 30 Sep 2021 11:55:37 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 156A3691BE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Sep 2021 11:55:21 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:bab4:22c5:662d:e478])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EA7A52A8;\n\tThu, 30 Sep 2021 11:55:19 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"E6+eBIxC\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632995720;\n\tbh=ZDsC5U9elk9Kl89mk/8RV4aoN2ujV09pb+sjRK5GPHo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=E6+eBIxCi6Wuq4VtWesda1impfZD9VL24Q47LESzit+okRh4jORfmuso1Ch8CT4EB\n\tn6eN/hO8qkPvj2W0Z2dfe+XvDtzIpqtU159+TrhL+iWLfDAql6tlRARg+FkfSlPZDa\n\tjrY8MUNbLnXu3XiFpphEaQZuC4Ro6YSVRe2Ig4A0=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 30 Sep 2021 11:55:09 +0200", "Message-Id": "<20210930095513.76213-15-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210930095513.76213-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210930095513.76213-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 14/18] ipa: ipu3: ipa_context: Fix doxygen\n\treferences", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nThe IPAFrameContext use unamed structures to group items.\nDoxygen can not reference the member variables of the container structures\nthrough the variable names, and expects the structure type name. As this is not\ngiven, the structure variables are referenced from the parent structure.\n\nRemove the member name from the annonymous type to allow Doxygen to\nmatch the implementation from the documentation.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/ipu3/ipa_context.cpp | 19 +++++++++++--------\n 1 file changed, 11 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\nindex 40d79772..a38e6053 100644\n--- a/src/ipa/ipu3/ipa_context.cpp\n+++ b/src/ipa/ipu3/ipa_context.cpp\n@@ -59,10 +59,10 @@ namespace libcamera::ipa::ipu3 {\n * \\struct IPASessionConfiguration::grid\n * \\brief Grid configuration of the IPA\n *\n- * \\var IPASessionConfiguration::grid::bdsGrid\n+ * \\var IPASessionConfiguration::bdsGrid\n * \\brief Bayer Down Scaler grid plane config used by the kernel\n *\n- * \\var IPASessionConfiguration::grid::bdsOutputSize\n+ * \\var IPASessionConfiguration::bdsOutputSize\n * \\brief BDS output size configured by the pipeline handler\n */\n \n@@ -73,10 +73,10 @@ namespace libcamera::ipa::ipu3 {\n * The exposure and gain determined are expected to be applied to the sensor\n * at the earliest opportunity.\n *\n- * \\var IPAFrameContext::agc::exposure\n+ * \\var IPAFrameContext::exposure\n * \\brief Exposure time expressed as a number of lines\n *\n- * \\var IPAFrameContext::agc::gain\n+ * \\var IPAFrameContext::gain\n * \\brief Analogue gain multiplier\n *\n * The gain should be adapted to the sensor specific gain code before applying.\n@@ -89,13 +89,13 @@ namespace libcamera::ipa::ipu3 {\n * \\struct IPAFrameContext::awb::gains\n * \\brief White balance gains\n *\n- * \\var IPAFrameContext::awb::gains::red\n+ * \\var IPAFrameContext::red\n * \\brief White balance gain for R channel\n *\n- * \\var IPAFrameContext::awb::gains::green\n+ * \\var IPAFrameContext::green\n * \\brief White balance gain for G channel\n *\n- * \\var IPAFrameContext::awb::gains::blue\n+ * \\var IPAFrameContext::blue\n * \\brief White balance gain for B channel\n */\n \n@@ -103,7 +103,10 @@ namespace libcamera::ipa::ipu3 {\n * \\struct IPAFrameContext::toneMapping\n * \\brief Context for ToneMapping and Gamma control\n *\n- * \\var IPAFrameContext::toneMapping::gammaCorrection\n+ * \\var IPAFrameContext::gamma\n+ * \\brief Gamma value for the LUT\n+ *\n+ * \\var IPAFrameContext::gammaCorrection\n * \\brief Per-pixel tone mapping implemented as a LUT\n *\n * The LUT structure is defined by the IPU3 kernel interface. See\n", "prefixes": [ "libcamera-devel", "14/18" ] }