Patch Detail
Show a patch.
GET /api/1.1/patches/13997/?format=api
{ "id": 13997, "url": "https://patchwork.libcamera.org/api/1.1/patches/13997/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13997/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210930095513.76213-2-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-09-30T09:54:56", "name": "[libcamera-devel,01/18] ipa: ipu3: Document IPAIPU3 class interface", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "1449a8bc50dca3cc8fa7bc2920df2bdd39996e4a", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13997/mbox/", "series": [ { "id": 2588, "url": "https://patchwork.libcamera.org/api/1.1/series/2588/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2588", "date": "2021-09-30T09:54:55", "name": "Document IPU3 IPA", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2588/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13997/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13997/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8FD7DC3243\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Sep 2021 09:55:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C3126691B0;\n\tThu, 30 Sep 2021 11:55:20 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99387691A3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Sep 2021 11:55:17 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:bab4:22c5:662d:e478])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 32C65B2B;\n\tThu, 30 Sep 2021 11:55:17 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"af9Tq6aM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632995717;\n\tbh=E2mESPxTMSuWK8k3JEjStbjEpEKFAesMcH1KthhAQQ8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=af9Tq6aMBBPkPybJdDoOQU+igkp1hL0p39xw744Fv9ZYmcHwKeHeTLbmGw7grjUv1\n\tKmSOxoLYXdUlDTA+JUu9Pzo4oBvkzx5LyKBIT5r6GcHgOVGW2BN8pxX5Ishf+2OAaH\n\tUkwHyeOJxHwQr4q9Bk4NHO6ja5r6dwIDsCyncj0o=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 30 Sep 2021 11:54:56 +0200", "Message-Id": "<20210930095513.76213-2-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210930095513.76213-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210930095513.76213-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 01/18] ipa: ipu3: Document IPAIPU3 class\n\tinterface", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The IPU3 IPA is maturing to a modular and extensible system capable of\nhandling specific algorithms for the accelleration clusters on the ImgU.\n\nProvide a top-level class documentation to provide an overview of the\nIPA, detailing what events are used and what algorithms are currently\nsupported, as well as the limitations currently imposed.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 64 +++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 64 insertions(+)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 7cc0fb89..bf8fc1e8 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -157,6 +157,70 @@ LOG_DEFINE_CATEGORY(IPAIPU3)\n \n namespace ipa::ipu3 {\n \n+/**\n+ * \\brief The IPU3 IPA implementation\n+ *\n+ * The IPU3 Pipeline defines an IPU3 specific interface for communication\n+ * between the PipelineHandler, and the IPA module.\n+ *\n+ * We extend the IPAIPU3Interface to implement our algorithms and handle events\n+ * from the IPU3 PipelineHandler to satisfy requests from the application.\n+ *\n+ * At initialisation time, a CameraSensorHelper is instantiated to support\n+ * camera specific calculations, while the default controls are computed, and\n+ * the algorithms are constructed and placed in an ordered list.\n+ *\n+ * The IPU3 ImgU operates with a grid layout to divide the overall frame into\n+ * rectangular cells of pixels. When the IPA is configured, we determine the\n+ * best grid for the statistics based on the pipeline handler Bayer Down Scaler\n+ * output size.\n+ *\n+ * Two main events are then handled to facilitate the operation of the IPU3 ImgU\n+ * by populating its parameter buffer, and adapting the settings of the sensor\n+ * attached to the IPU3 CIO2 through sensor specific V4L2 controls.\n+ *\n+ * When the event \\a EventFillParams occurs we populate the ImgU parameter\n+ * buffer with settings to configure the device in preparation for handling the\n+ * frame queued in the Request.\n+ *\n+ * When the frame has completed processing, the ImgU will generate a statistics\n+ * buffer which is given to the IPA as part of the \\a EventStatReady event. At\n+ * this event we run the algorithms to parse the statistics and cache any\n+ * results for the next \\a EventFillParams event.\n+ *\n+ * The individual algorithms are split into modular components that are called\n+ * iteratively to allow them to process statistics from the ImgU in a defined\n+ * order.\n+ *\n+ * The current implementation supports three core algorithms:\n+ * - Automatic white balance (AWB)\n+ * - Automatic gain and exposure control (AGC)\n+ * - Tonemapping (Gamma)\n+ *\n+ * AWB is implemented using a Greyworld algorithm, and calculates the red and\n+ * blue gains to apply to generate a neutral grey frame overall.\n+ *\n+ * AGC is handled by calculating a histogram of the green channel to estimate an\n+ * analogue gain and shutter time which will provide a well exposed frame. An\n+ * IIR filter is used to smooth the changes to the sensor to reduce perceivable\n+ * steps.\n+ *\n+ * The Tonemapping algorithm provides a gamma correction table to improve the\n+ * contrast of the scene.\n+ *\n+ * The IPU3 ImgU has further accellerator clusters to support image quality\n+ * improvements through bayer and temporal noise reductions, however those are\n+ * not supported in the current implementation, and will use default settings as\n+ * provided by the kernel driver.\n+ *\n+ * Demosaicing is operating on the default values and could be further optimised\n+ * to provide improved sharpening coefficients, checker artifact removal, and\n+ * false color correction.\n+ *\n+ * Additional image enhancements can be made by providing lens and sensor\n+ * specific tuning to adapt for Black Level compensation (BLC), Lens shading\n+ * correction (SHD) and Color correction (CCM)\n+ */\n class IPAIPU3 : public IPAIPU3Interface\n {\n public:\n", "prefixes": [ "libcamera-devel", "01/18" ] }