Patch Detail
Show a patch.
GET /api/1.1/patches/13940/?format=api
{ "id": 13940, "url": "https://patchwork.libcamera.org/api/1.1/patches/13940/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13940/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210926212108.22510-1-laurent.pinchart@ideasonboard.com>", "date": "2021-09-26T21:21:06", "name": "[libcamera-devel,1/3] Documentation: application-developer: Make global variable static", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7f0a548274c752b66a89c587437c8e9fbd043c6e", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13940/mbox/", "series": [ { "id": 2571, "url": "https://patchwork.libcamera.org/api/1.1/series/2571/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2571", "date": "2021-09-26T21:21:06", "name": "[libcamera-devel,1/3] Documentation: application-developer: Make global variable static", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2571/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13940/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13940/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23F55BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 26 Sep 2021 21:21:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 59B4069193;\n\tSun, 26 Sep 2021 23:21:19 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27C626012D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 26 Sep 2021 23:21:17 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 975CBEF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 26 Sep 2021 23:21:16 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"anQp44m4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632691276;\n\tbh=3UhWg7gW0Xx2VJ2FBz+Mv1x1xOFk6RFxLW2QcxI08oY=;\n\th=From:To:Subject:Date:From;\n\tb=anQp44m4hGw/Q/CmcizBxCCaEmapBwEhULerG9itoESU2/8BgUW8U9k07YpfrBztq\n\t65vovotP5tGZvr11HPQOClz4miAZqE1A0UvRAozimOtKYMNwDOg/+7hwsLTfMntjUL\n\teq7AvWr4D20OtC5wIewDLQKkRNRQ9aBOp4lJyCEc=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 27 Sep 2021 00:21:06 +0300", "Message-Id": "<20210926212108.22510-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/3] Documentation: application-developer:\n\tMake global variable static", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The global \"camera\" variable isn't accessed outside of its compilation\nunit. Make it static.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n Documentation/guides/application-developer.rst | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 72e8e03719aa552abce7eeee8a6e4a9b8eb8443e", "diff": "diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\nindex ae28c96b5aca..3de13060db08 100644\n--- a/Documentation/guides/application-developer.rst\n+++ b/Documentation/guides/application-developer.rst\n@@ -58,7 +58,7 @@ variable for the camera to support the event call back later:\n \n .. code:: cpp\n \n- std::shared_ptr<Camera> camera;\n+ static std::shared_ptr<Camera> camera;\n \n Create a Camera Manager instance at the beginning of the main function, and then\n start it. An application must only create a single Camera Manager instance.\n", "prefixes": [ "libcamera-devel", "1/3" ] }